1. 04 Nov, 2019 3 commits
    • Simon McVittie's avatar
      Make ld executable configurable · 81936ca5
      Simon McVittie authored
      Tools like this should be configurable in a cross or native file. In
      particular, if we are cross-compiling (with an executable wrapper like
      qemu-arm), the build system ld is not necessarily able to manipulate
      host system objects.
      Signed-off-by: Simon McVittie's avatarSimon McVittie <smcv@collabora.com>
      81936ca5
    • Simon McVittie's avatar
      gdbus-server-auth test: Include gcredentialsprivate.h · 49eccfbe
      Simon McVittie authored
      Otherwise we'll never test the EXTERNAL-only mode, because that relies
      on testing the private macros
      G_CREDENTIALS_UNIX_CREDENTIALS_MESSAGE_SUPPORTED and
      G_CREDENTIALS_SOCKET_GET_CREDENTIALS_SUPPORTED.
      
      Fixes: 9f962ebe "Add a test for GDBusServer authentication"
      Signed-off-by: Simon McVittie's avatarSimon McVittie <smcv@collabora.com>
      49eccfbe
    • Simon McVittie's avatar
      gdbus-peer: Specifically listen on 127.0.0.1 · 7021b84f
      Simon McVittie authored
      This bypasses any issues we might have with containers where IPv6 is
      returned by name resolution (particularly since !616) but
      doesn't necessarily actually work.
      
      This comes at a minor test-coverage cost: we don't test GDBusServer's
      default behaviour when told to listen on "tcp:" or "nonce-tcp:", and
      on systems where IPv6 is available, we don't test it. If we want to
      do those, we should perhaps do them in separate tests, and disable
      those tests when binding to ::1 doesn't work.
      
      Mitigates: #1912Signed-off-by: Simon McVittie's avatarSimon McVittie <smcv@collabora.com>
      7021b84f
  2. 30 Oct, 2019 3 commits
  3. 29 Oct, 2019 4 commits
  4. 28 Oct, 2019 4 commits
  5. 26 Oct, 2019 1 commit
  6. 18 Oct, 2019 2 commits
  7. 10 Oct, 2019 2 commits
  8. 08 Oct, 2019 1 commit
  9. 02 Oct, 2019 1 commit
  10. 30 Sep, 2019 2 commits
  11. 21 Sep, 2019 1 commit
    • Philip Withnall's avatar
      gatomic: Add various casts to use of g_atomic_*()s to fix warnings · 55f9c6d2
      Philip Withnall authored
      When compiling GLib with `-Wsign-conversion`, we get various warnings
      about the atomic calls. A lot of these were fixed by
      3ad375a6, but some remain. Fix them by
      adding appropriate casts at the call sites.
      
      Note that `g_atomic_int_{and,or,xor}()` actually all operate on `guint`s
      rather than `gint`s (which is what the rest of the `g_atomic_int_*()`
      functions operate on). I can’t find any written reasoning for this, but
      assume that it’s because signedness is irrelevant when you’re using an
      integer as a bit field. It’s unfortunate that they’re named a
      `g_atomic_int_*()` rather than `g_atomic_uint_*()` functions.
      
      Tested by compiling GLib as:
      ```
      CFLAGS=-Wsign-conversion jhbuild make -ac |& grep atomic
      ```
      
      I’m not going to add `-Wsign-conversion` to the set of default warnings
      for building GLib, because it mostly produces false positives throughout
      the rest of GLib.
      Signed-off-by: Philip Withnall's avatarPhilip Withnall <withnall@endlessm.com>
      
      Fixes: #1565
      55f9c6d2
  12. 05 Sep, 2019 2 commits
  13. 02 Sep, 2019 3 commits
    • Will Thompson's avatar
      gdbus-codegen: emit GUnixFDLists if an arg has type 'h' · 4aba0356
      Will Thompson authored
      Previously, if a method was not annotated with org.gtk.GDBus.C.UnixFD
      then the generated code would never contain GUnixFDList parameters, even
      if the method has 'h' (file descriptor) parameters. However, in this
      case, the generated code is essentially useless: the method cannot be
      called or handled except in degenerate cases where the file descriptors
      are missing or ignored.
      
      Check the argument types for 'h', and if present, generate code as if
      org.gtk.GDBus.C.UnixFD annotation were specified.
      
      This change will break any existing code which refers to the (useless)
      wrappers for such methods. The workaround for such code is to add the
      org.gtk.GDBus.C.UnixFD annotation, which will cause the same generated
      code to be emitted before and after this change.
      
      If this is found to cause widespread problems, we can explore a
      different approach (perhaps emitting a warning from the code generator,
      or annotating the symbols as deprecated).
      
      #1726
      4aba0356
    • Philip Withnall's avatar
      39052a1c
    • Will Thompson's avatar
      gdbus-codegen: process C.UnixFD annotation in one place · 9b827e56
      Will Thompson authored
      This will make it simpler to enable this behaviour based on the method
      signature.
      
      #1726
      9b827e56
  14. 29 Aug, 2019 1 commit
    • Ting-Wei Lan's avatar
      meson: Move libdl_dep to the top level · fe3c1660
      Ting-Wei Lan authored
      Instead of letting each directory to find its way to link with libdl,
      it is easier to put the check in the top level, so its result can be
      used by all directories.
      
      It is a follow-up of !810.
      fe3c1660
  15. 21 Aug, 2019 4 commits
  16. 29 Jul, 2019 1 commit
  17. 25 Jul, 2019 1 commit
  18. 24 Jul, 2019 1 commit
    • Emmanuele Bassi's avatar
      build: Remove unsupported `install` directives · 00d7568e
      Emmanuele Bassi authored
      We're using the `install` argument for configure_file() all over the
      place.
      
      The support for an `install` argument for configure_file() was added in
      Meson 0.50, but we haven't bumped the minimum version of Meson we
      require, yet; which means we're getting compatibility warnings when
      using recent versions of Meson, and undefined behaviour when using older
      versions.
      
      The configure_file() object defaults to `install: false`, unless an
      install directory is used. This means that all instances of an `install`
      argument with an explicit `true` or `false` value can be removed,
      whereas all instances of `install` with a value determined from a
      configuration option must be turned into an explicit conditional.
      00d7568e
  19. 16 Jul, 2019 1 commit
  20. 15 Jul, 2019 1 commit
  21. 13 Jul, 2019 1 commit