Commit cbeecdc4 authored by Matthias Clasen's avatar Matthias Clasen

convert: Improve test coverage

Add a test that excercises the 'no conversion' code path.
This uncovered that we don't treat errno properly in this path,
and as a consequence, the returned error code is unreliable.
parent 7d489ace
......@@ -685,11 +685,28 @@ test_filename_display (void)
g_free (display);
static void
test_no_conv (void)
gchar *in = "";
gchar *out G_GNUC_UNUSED;
gsize bytes_read = 0;
gsize bytes_written = 0;
GError *error = NULL;
out = g_convert (in, -1, "XXX", "UVZ",
&bytes_read, &bytes_written, &error);
/* error code is unreliable, since we mishandle errno there */
g_assert (error && error->domain == G_CONVERT_ERROR);
main (int argc, char *argv[])
g_test_init (&argc, &argv, NULL);
g_test_add_func ("/conversion/no-conv", test_no_conv);
g_test_add_func ("/conversion/iconv-state", test_iconv_state);
g_test_add_func ("/conversion/illegal-sequence", test_one_half);
g_test_add_func ("/conversion/byte-order", test_byte_order);
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment