Commit b2371871 authored by Allison Karlitskaya's avatar Allison Karlitskaya

GObject: require READ or WRITE on property install

g_object_class_install_property() currently lets you install properties
that are neither readable nor writable.  Add a check to prevent that.

https://bugzilla.gnome.org/show_bug.cgi?id=666616
parent 4e793c2e
......@@ -530,6 +530,7 @@ g_object_class_install_property (GObjectClass *class,
class->flags |= CLASS_HAS_PROPS_FLAG;
g_return_if_fail (pspec->flags & (G_PARAM_READABLE | G_PARAM_WRITABLE));
if (pspec->flags & G_PARAM_WRITABLE)
g_return_if_fail (class->set_property != NULL);
if (pspec->flags & G_PARAM_READABLE)
......
......@@ -687,9 +687,6 @@ static void test_implementation_class_init (TestImplementationClass *class)
if (perms[change_this_flag] == NULL)
g_error ("Interface property does not exist");
if (!(use_this_flag & (G_PARAM_READABLE | G_PARAM_WRITABLE)))
g_error ("g_object_class_install_property should probably fail here...");
g_snprintf (prop_name, sizeof prop_name, "%s-%s", names[change_this_type], perms[change_this_flag]);
pspec = g_param_spec_object (prop_name, prop_name, prop_name, types[use_this_type], use_this_flag);
g_object_class_install_property (class, 1, pspec);
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment