Commit 9ddb2f80 authored by Simon McVittie's avatar Simon McVittie

g_hmac_get_string: don't allocate and leak an unused buffer

Also document why we're not actually using the buffer for anything.
Signed-off-by: Simon McVittie's avatarSimon McVittie <simon.mcvittie@collabora.co.uk>
Bug: https://bugzilla.gnome.org/show_bug.cgi?id=666113Reviewed-by: default avatarEmmanuele Bassi <ebassi@linux.intel.com>
parent 64ca85ce
......@@ -280,9 +280,13 @@ g_hmac_get_string (GHmac *hmac)
g_return_val_if_fail (hmac != NULL, NULL);
digest_len = g_checksum_type_get_length (hmac->digest_type);
buffer = g_malloc (digest_len);
buffer = g_alloca (digest_len);
/* This is only called for its side-effect of updating hmac->digesto... */
g_hmac_get_digest (hmac, buffer, &digest_len);
/* ... because we get the string from the checksum rather than
* stringifying buffer ourselves
*/
return g_checksum_get_string (hmac->digesto);
}
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment