Commit 346aa683 authored by Allison Karlitskaya's avatar Allison Karlitskaya

Fix visibility for glib/ and gio/ submodules

We have various sub directories in glib/ and gio/ (eg: inotify, gnulib,
pcre, xdgmime, etc.) that build convenience libraries that are then
included into libglib and libgio.  The files in these directories need
to be built with the same visibility policy as the files in the first
level directories, so add CFLAGS for them all.

This wasn't a problem when the visibility flags were set directly in
CFLAGS but then we had to deal with some modules that we built that we
explicitly wanted to export symbols from.

For now, we can keep things the way they are because it's less hacky and
although it's a theoretical hazard to forget these CFLAGS, we rarely add
new subdirectories to the build.
parent 6f8f1f70
......@@ -20,6 +20,7 @@ libfen_la_SOURCES = \
$(NULL)
libfen_la_CFLAGS = \
$(GLIB_HIDDEN_VISIBILITY_CFLAGS) \
-DG_LOG_DOMAIN=\"GLib-GIO\" \
$(gio_INCLUDES) \
$(GLIB_DEBUG_FLAGS) \
......
......@@ -22,6 +22,7 @@ libinotify_la_SOURCES = \
$(NULL)
libinotify_la_CFLAGS = \
$(GLIB_HIDDEN_VISIBILITY_CFLAGS) \
-DG_LOG_DOMAIN=\"GLib-GIO\" \
$(gio_INCLUDES) \
$(GLIB_DEBUG_FLAGS) \
......
......@@ -26,6 +26,7 @@ libkqueue_la_SOURCES = \
$(NULL)
libkqueue_la_CFLAGS = \
$(GLIB_HIDDEN_VISIBILITY_CFLAGS) \
-DG_LOG_DOMAIN=\"GLib-GIO\" \
$(gio_INCLUDES) \
$(GLIB_DEBUG_FLAGS) \
......
......@@ -19,6 +19,7 @@ libgiowin32_la_SOURCES = \
$(NULL)
libgiowin32_la_CFLAGS = \
$(GLIB_HIDDEN_VISIBILITY_CFLAGS) \
-DG_LOG_DOMAIN=\"GLib-GIO\" \
$(gio_INCLUDES) \
$(GLIB_DEBUG_FLAGS) \
......
......@@ -4,6 +4,7 @@ AM_CPPFLAGS = -DXDG_PREFIX=_gio_xdg
noinst_LTLIBRARIES = libxdgmime.la
libxdgmime_la_CFLAGS = $(GLIB_HIDDEN_VISIBILITY_CFLAGS)
libxdgmime_la_SOURCES = \
xdgmime.c \
xdgmime.h \
......
......@@ -6,6 +6,7 @@ INCLUDES = $(glib_INCLUDES) -DG_LOG_DOMAIN=\"GLib\" \
noinst_LTLIBRARIES = libgnulib.la
libgnulib_la_CFLAGS = $(GLIB_HIDDEN_VISIBILITY_CFLAGS)
libgnulib_la_SOURCES = \
asnprintf.c \
printf-args.c \
......
......@@ -6,6 +6,7 @@ INCLUDES = \
noinst_LTLIBRARIES = libcharset.la
libcharset_la_CFLAGS = $(GLIB_HIDDEN_VISIBILITY_CFLAGS)
libcharset_la_SOURCES = \
libcharset.h \
localcharset.h \
......
......@@ -25,6 +25,7 @@ libpcre_la_CPPFLAGS = \
$(AM_CPPFLAGS)
libpcre_la_CFLAGS = \
$(GLIB_HIDDEN_VISIBILITY_CFLAGS) \
$(PCRE_WARN_CFLAGS) \
$(DEP_CFLAGS) \
$(AM_CFLAGS)
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment