• Allison Karlitskaya's avatar
    measure_disk_usage: skip progress on NULL callback · dbf95a5a
    Allison Karlitskaya authored
    In the real_..._async wrapper for GFile.measure_disk_usage, skip the
    wrapping of the progress callback in the case that the user gave a NULL
    callback to the async function.  This is a performance improvement
    because the sync version won't have to do continuous sampling of the
    clock to issue a call to the wrapper which will then do nothing.
    
    Unfortunately, I made this simplifying assumption when writing the
    wrapper, but forgot to actually implement it when making the sync call.
    As a result, the wrapper is still called, and invokes the NULL callback,
    causing a segfault.
    
    Make sure we pass NULL if the user's callback was NULL.
    
    https://bugzilla.gnome.org/show_bug.cgi?id=707787
    dbf95a5a
gfile.c 268 KB