• Christian Hergert's avatar
    subprocess: avoid infinite loop in verify_disposition() · 83d6c38e
    Christian Hergert authored
    When performing the verify and building the error string there were two
    possibilities of an infinite loop. The first is the missing twos-complement
    to unset the bit in the filtered flags. The second is the lack of handling
    G_SUBPROCESS_FLAGS_NONE which can return a valid GFlagsValue (and cannot
    unset the bit since the value is zero).
    
    This walks all known values in the GSubprocessFlags type class and check
    if they are set. This has the benefit that we don't call needless functions
    which walk the same table as well as avoiding mutating values to build
    the error string.
    
    https://bugzilla.gnome.org/show_bug.cgi?id=775913
    83d6c38e
gsubprocesslauncher.c 22.4 KB