Skip to content
GitLab
Projects Groups Topics Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Register
  • Sign in
  • G GLib
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributor statistics
    • Graph
    • Compare revisions
  • Issues 857
    • Issues 857
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 45
    • Merge requests 45
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Releases
  • Packages and registries
    • Packages and registries
    • Container Registry
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • GNOMEGNOME
  • GLib
  • Merge requests
  • !3292
The source project of this merge request has been removed.

Close-on-exec flag few missed places

Merged Maciej S. Szmigiero requested to merge (removed):cloexec-other into main Feb 22, 2023
  • Overview 1
  • Pipelines 0
  • Changes 4

It looks like when scanning for file-descriptor-opening functions for !3283 (merged) I missed a few places:

  • One case of fopen () call which was written as fopen() (without space before the opening parenthesis). Rescanned Glib code after this for another function calls written this way, found none relevant.

  • Went thorough glibc man pages and Linux man-pages looking for other functions that mention the close-on-exec flag. Within this set of file-descriptor-opening functions, I've spotted calls to setmntent () and mkstemp ()-like family of functions in Glib.

Sorry for missing these cases for the previous MR a few days ago.

Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: cloexec-other