Skip to content
GitLab
Projects Groups Topics Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Register
  • Sign in
  • G GLib
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributor statistics
    • Graph
    • Compare revisions
  • Issues 852
    • Issues 852
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 42
    • Merge requests 42
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Releases
  • Packages and registries
    • Packages and registries
    • Container Registry
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • GNOMEGNOME
  • GLib
  • Merge requests
  • !3105

gsocket: use socklen_t in more places to fix build under cygwin

  • Review changes

  • Download
  • Patches
  • Plain diff
Merged Christoph Reiter requested to merge creiter/glib:use-socklen-t into main Dec 02, 2022
  • Overview 2
  • Commits 2
  • Pipelines 1
  • Changes 1

cygwin defines socklen_t as int, unlike everywhere else where it is uint32_t (afaics), so signed vs unsigned.

The recently added -Werror=pointer-sign in 43538130 makes the build fail under cygwin now with something like:

error: pointer targets in passing argument 5 of ‘getsockopt’ differ in signedness [-Werror=pointer-sign]

This changes guint to socklen_t where needed for getsockname, getpeername and getsockopt.


The second commit fixes two small related warnings.

Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: use-socklen-t