Skip to content
GitLab
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Register
  • Sign in
  • G GLib
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 854
    • Issues 854
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 55
    • Merge requests 55
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Releases
  • Packages and registries
    • Packages and registries
    • Container Registry
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • GNOMEGNOME
  • GLib
  • Merge requests
  • !3009

gtimezone: Fix symlink checks on relative link targets

  • Review changes

  • Download
  • Email patches
  • Plain diff
Merged Philip Withnall requested to merge pwithnall/glib:timezone-relative-link-target into main Oct 24, 2022
  • Overview 11
  • Commits 2
  • Pipelines 1
  • Changes 2

The changes in 6265b2e6 to reject weird /etc/localtime configurations where /etc/localtime links to another symlink did not consider the case where the target of /etc/localtime is a relative path. They only considered the case where the target is absolute.

Relative paths are permissible in all symlinks. On my Fedora 36 system, /etc/localtime’s target is ../usr/share/zoneinfo/Europe/London.

Fix the check for toolbx by resolving relative paths before calling g_lstat() on them.

Signed-off-by: Philip Withnall pwithnall@endlessos.org

Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: timezone-relative-link-target