Skip to content
GitLab
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Register
  • Sign in
  • G GLib
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 855
    • Issues 855
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 55
    • Merge requests 55
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Releases
  • Packages and registries
    • Packages and registries
    • Container Registry
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • GNOMEGNOME
  • GLib
  • Merge requests
  • !2920

gregex: Allow G_REGEX_JAVASCRIPT_COMPAT in compile mask

  • Review changes

  • Download
  • Email patches
  • Plain diff
Merged Guido Günther requested to merge guidog/glib:re-js-compat into main Sep 23, 2022
  • Overview 8
  • Commits 2
  • Pipelines 4
  • Changes 2

The flag is still ignored but this way we properly deprecate at compile time without raising an unexpected criticals at runtime in g_regex_new:

   g_regex_new: assertion '(compile_options & ~G_REGEX_COMPILE_MASK) == 0' failed

and then failing to create the regex completely.

Fixes 8d5a44dc ("replace pcre1 with pcre2")

Edited Sep 23, 2022 by Guido Günther
Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: re-js-compat