Skip to content
GitLab
  • Menu
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
  • G GLib
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 879
    • Issues 879
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 46
    • Merge requests 46
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Releases
  • Packages & Registries
    • Packages & Registries
    • Container Registry
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • GNOME
  • GLib
  • Merge requests
  • !2794

gobject: Fix a recent regression

  • Review changes

  • Download
  • Email patches
  • Plain diff
Merged Matthias Clasen requested to merge another-victim-of-gobject into main Jul 02, 2022
  • Overview 20
  • Commits 2
  • Pipelines 7
  • Changes 3

When I optimized GObject to skip property notification in some cases, I looked for whether the class has a custom notify vfunc. I overlooked that that dispatch_properties_changed can also be customized, and if it is, we better not skip change notification.

This showed up as breakage in the adjustment tests in the GTK testsuite.

Edited Jul 08, 2022 by Emmanuele Bassi
Assignee
Assign to
Reviewer
Request review from
Time tracking
Source branch: another-victim-of-gobject