Skip to content
GitLab
  • Menu
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
  • G GLib
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 879
    • Issues 879
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 44
    • Merge requests 44
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Releases
  • Packages & Registries
    • Packages & Registries
    • Container Registry
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • GNOME
  • GLib
  • Merge requests
  • !265

Network monitor again

  • Review changes

  • Download
  • Email patches
  • Plain diff
Merged Matthias Clasen requested to merge network-monitor-again into master Aug 24, 2018
  • Overview 46
  • Commits 7
  • Pipelines 9
  • Changes 3

Life is unkind, and forces me to admit more oversights in the network monitor portal code.

Looking at https://github.com/flatpak/xdg-desktop-portal/issues/208 I realized that the current portal code always returns FALSE for can_reach(). I have another version of the portal interface here that adds a CanReach method: https://github.com/matthiasclasen/xdg-desktop-portal/tree/network-monitor-again

This branch makes use of that new method. It also replaces the controversial 3 roundtrips with a single GetStatus call.

Assignee
Assign to
Reviewer
Request review from
Time tracking
Source branch: network-monitor-again