gmem: Only evaluate pointer argument to g_clear_pointer() once (!262) · Merge requests · GNOME / GLib

Philip Withnall requested to merge pwithnall/glib:g-clear-pointer-no-side-effects into master Aug 22, 2018

The new typeof() macro version of g_clear_pointer() was evaluating its pointer argument more than once, meaning any side effects would be evaluated multiple times.

The existing (other) macro version of g_clear_pointer() was evaluating its argument exactly once. This mismatch could have confused people or lead to subtle bugs.

See #1494 (closed).

Signed-off-by: Philip Withnall withnall@endlessm.com

Ideally this should go into 2.58 before the new g_clear_pointer() version makes it into a stable release.

gmem: Only evaluate pointer argument to g_clear_pointer() once

Merge request reports