Skip to content
GitLab
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
  • G GLib
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 859
    • Issues 859
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 36
    • Merge requests 36
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Releases
  • Packages and registries
    • Packages and registries
    • Container Registry
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • GNOMEGNOME
  • GLib
  • Merge requests
  • !2361

Backport !2354 “gtestdbus: Print the dbus address on a specific FD intead of stdout” to glib-2-70

  • Review changes

  • Download
  • Email patches
  • Plain diff
Merged Philip Withnall requested to merge pwithnall/glib:backport-2354-test-dbus-glib-2-70 into glib-2-70 Nov 24, 2021
  • Overview 0
  • Commits 1
  • Pipelines 1
  • Changes 1

We used to use a pipe for the dbus daemon stdout to read the defined address, but that was already requiring a workaround to ensure that dbus daemon children were then able to write to stdout. However the current implementation is still causing troubles in some cases in which the daemon is very verbose, leading to hangs when writing to stdout.

As per this, just don't handle stdout ourself, but use instead a specific pipe to get the address address. That can now be safely closed once we've received the data we need.

This reverts commit d80adeaa.

Fixes: #2537 (closed)


Trivial backport of !2354 (merged) to glib-2-70.

Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: backport-2354-test-dbus-glib-2-70