Skip to content
GitLab
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Register
  • Sign in
  • G GLib
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 853
    • Issues 853
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 54
    • Merge requests 54
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Releases
  • Packages and registries
    • Packages and registries
    • Container Registry
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • GNOMEGNOME
  • GLib
  • Merge requests
  • !2260

GWin32AppInfo: Do not assert about successful open'ing of registry keys

  • Review changes

  • Download
  • Email patches
  • Plain diff
Merged Luca Bacci requested to merge lb90/glib:fix-win32-app-info-registry-key-assert into main Sep 21, 2021
  • Overview 4
  • Commits 1
  • Pipelines 1
  • Changes 1

We should not assert that the registry key open'ing was successful: the key may have been removed in the meantime between keys enumeration and when opening the key or, more likely, we may not have the required access rights to open the key, in which case RegOpenKeyExW fails and returns ERROR_ACCESS_DENIED.

Fixes https://gitlab.com/inkscape/inbox/-/issues/5669

Edited Sep 22, 2021 by Luca Bacci
Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: fix-win32-app-info-registry-key-assert