Skip to content
GitLab
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
  • G GLib
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 862
    • Issues 862
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 41
    • Merge requests 41
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Releases
  • Packages and registries
    • Packages and registries
    • Container Registry
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • GNOMEGNOME
  • GLib
  • Merge requests
  • !1973

meson: fix str[n]casecmp detection on clang-cl

  • Review changes

  • Download
  • Email patches
  • Plain diff
Merged Aleksandr Mezin requested to merge amezin/glib:fix-clang-cl-strcasecmp into master Feb 27, 2021
  • Overview 2
  • Commits 1
  • Pipelines 1
  • Changes 1

Meson incorrectly detects strcasecmp, strncasecmp on clang-cl if prefix: is not specified for cc.has_function().

See https://github.com/mesonbuild/meson/issues/5628

Fixes #2337 (closed)

Before this change:

  • msvc was using _stricmp()
  • gcc on mingw was using strcasecmp()
  • gcc on linux was using strcasecmp()
  • clang-cl was trying to use strcasecmp()

After this change:

  • msvc is using _stricmp()
  • gcc on mingw is using strcasecmp()
  • gcc on linux is using strcasecmp()
  • clang-cl is using _stricmp()

Tests are still failing to build with clang-cl, but that's a separate issue.

Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: fix-clang-cl-strcasecmp