Skip to content
GitLab
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
  • G GLib
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 862
    • Issues 862
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 41
    • Merge requests 41
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Releases
  • Packages and registries
    • Packages and registries
    • Container Registry
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • GNOMEGNOME
  • GLib
  • Merge requests
  • !1874

Fix statx feature test for Android

  • Review changes

  • Download
  • Email patches
  • Plain diff
Closed Vilius Sutkus 89 requested to merge ViliusSutkus89/glib:Android-statx-feature-test into master Jan 12, 2021
  • Overview 1
  • Commits 1
  • Pipelines 1
  • Changes 1

statx syscall was introduced in Android-30. Compiling for Android<30 should fail, yet it doesn't, which results in false positive for a feature that is actually not available. Would guess that this happens because of the same name for both the function and the struct, which is not #ifdef'ed for legacy Android.

Current check "host_system != 'android'" doesn't guard the feature test against android, because host_system is never just android, it's android-$abi, like android-x86_64.

Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: Android-statx-feature-test