GLib merge requestshttps://gitlab.gnome.org/GNOME/glib/-/merge_requests2019-02-13T16:53:46Zhttps://gitlab.gnome.org/GNOME/glib/-/merge_requests/668tests: Mark gdbus-peer test as flaky2019-02-13T16:53:46ZPhilip Withnalltests: Mark gdbus-peer test as flakyIt is occasionally deadlocking. See #1686.
Signed-off-by: Philip Withnall <withnall@endlessm.com>It is occasionally deadlocking. See #1686.
Signed-off-by: Philip Withnall <withnall@endlessm.com>2.59.3https://gitlab.gnome.org/GNOME/glib/-/merge_requests/672Fix some tests when running as root2019-02-14T13:18:04ZPhilip WithnallFix some tests when running as rootPartially fixes running the test suite with `sudo ninja test`, or on a build machine where the builds are run as root.Partially fixes running the test suite with `sudo ninja test`, or on a build machine where the builds are run as root.https://gitlab.gnome.org/GNOME/glib/-/merge_requests/687Resolve "socket-service test is flaky"2019-02-22T01:34:06ZPhilip WithnallResolve "socket-service test is flaky"Two orthogonal fixes to fix races in the `socket-service` test.
Closes #1679Two orthogonal fixes to fix races in the `socket-service` test.
Closes #16792.60https://gitlab.gnome.org/GNOME/glib/-/merge_requests/696Move closures refcount test to gobject/tests/2019-02-27T16:49:16ZPhilip WithnallMove closures refcount test to gobject/tests/And improve it in various ways. In particular, make the main thread iterations continue until both thread{1,2} are seen, so we don’t rely on the scheduler to schedule them both enough within the fixed number of iterations we’d specified....And improve it in various ways. In particular, make the main thread iterations continue until both thread{1,2} are seen, so we don’t rely on the scheduler to schedule them both enough within the fixed number of iterations we’d specified.
This should allow [a Debian downstream patch](https://salsa.debian.org/gnome-team/glib/blob/debian/master/debian/patches/debian/closures-test-Skip-on-arm-unless-flaky-tests-are-allowed.patch) to be removed, hopefully.
It helps #1434.https://gitlab.gnome.org/GNOME/glib/-/merge_requests/697Clean tests/ rootdir from redundant test cases in glib/tests/2019-05-03T18:49:43ZEmmanuel FleuryClean tests/ rootdir from redundant test cases in glib/tests/This MR is related to issue #1434, it removes tests cases that already are in `glib/tests/` (it should be with no impact on the rest of the code. It only removes useless code base).This MR is related to issue #1434, it removes tests cases that already are in `glib/tests/` (it should be with no impact on the rest of the code. It only removes useless code base).2.62.0https://gitlab.gnome.org/GNOME/glib/-/merge_requests/699tests: Fix closure-refcount to preserve old semantics2019-02-28T13:32:47ZKrzesimir Nowaktests: Fix closure-refcount to preserve old semanticsThe threads used to iterate at least 10000 times before setting the
"seen thread" flag to true. After porting they inadvertently did that
in the first iteration.The threads used to iterate at least 10000 times before setting the
"seen thread" flag to true. After porting they inadvertently did that
in the first iteration.https://gitlab.gnome.org/GNOME/glib/-/merge_requests/706Fix data races in task test and gmenumodel test2019-03-06T13:53:37ZGhost UserFix data races in task test and gmenumodel testhttps://gitlab.gnome.org/GNOME/glib/-/merge_requests/715Minor improvements to gdbus-proxy test2019-03-07T15:12:43ZPhilip WithnallMinor improvements to gdbus-proxy testI couldn’t reproduce the test failure from the CI at all (using `meson test gdbus-proxy --repeat 1000 --num-processes 10`) , but here are a couple of improvements to the test anyway.
Closes #1712I couldn’t reproduce the test failure from the CI at all (using `meson test gdbus-proxy --repeat 1000 --num-processes 10`) , but here are a couple of improvements to the test anyway.
Closes #17122.60.1https://gitlab.gnome.org/GNOME/glib/-/merge_requests/772tests: Check that option-argv0 test succeeds on Linux2019-04-11T16:46:32ZGhost Usertests: Check that option-argv0 test succeeds on LinuxTo avoid potential regression in feature check that configures
`HAVE_PROC_SELF_CMDLINE` treat test failures on Linux as fatal.
This restores behaviour from before 4c038a27ff14170141f62f3ab61a6fa7c4747f09.To avoid potential regression in feature check that configures
`HAVE_PROC_SELF_CMDLINE` treat test failures on Linux as fatal.
This restores behaviour from before 4c038a27ff14170141f62f3ab61a6fa7c4747f09.https://gitlab.gnome.org/GNOME/glib/-/merge_requests/776tests: Only run --external-data test on GNU ld/objcopy2019-04-15T09:42:17ZPhilip Withnalltests: Only run --external-data test on GNU ld/objcopyOther GCC-like implementations of ld/objcopy (like LLVM) don’t yet
support the right command line arguments, so can’t compile the test.
Signed-off-by: Philip Withnall <withnall@endlessm.com>
Closes #1709Other GCC-like implementations of ld/objcopy (like LLVM) don’t yet
support the right command line arguments, so can’t compile the test.
Signed-off-by: Philip Withnall <withnall@endlessm.com>
Closes #17092.60.1https://gitlab.gnome.org/GNOME/glib/-/merge_requests/777tests: Unmark several gdbus-* tests as flaky2019-04-15T09:11:31ZPhilip Withnalltests: Unmark several gdbus-* tests as flakyAfter repeated local testing, I can’t reproduce failures with them:
meson test --repeat 5000 gdbus-auth
meson test --repeat 5000 gdbus-bz627724
meson test --repeat 5000 gdbus-connection
The FreeBSD failures from pthread calls ...After repeated local testing, I can’t reproduce failures with them:
meson test --repeat 5000 gdbus-auth
meson test --repeat 5000 gdbus-bz627724
meson test --repeat 5000 gdbus-connection
The FreeBSD failures from pthread calls mentioned in #1614 should
probably manifest as use-after-free for GMutex or pthread_mutex_t on
Linux. Failing that, I haven’t seen any relevant FreeBSD failures on CI
for at least a month, so if it’s not fixed, the chances of debugging are
very low.
Signed-off-by: Philip Withnall <withnall@endlessm.com>
Closes #16142.60.1https://gitlab.gnome.org/GNOME/glib/-/merge_requests/778Backport !776 “tests: Only run --external-data test on GNU ld/objcopy” to gli...2019-04-15T09:42:25ZPhilip WithnallBackport !776 “tests: Only run --external-data test on GNU ld/objcopy” to glib-2-60See !776.
Closes: #1709, #1711See !776.
Closes: #1709, #17112.60.1https://gitlab.gnome.org/GNOME/glib/-/merge_requests/788tests: Fix some minor tests in the GResolver tests in manual mode2019-04-23T15:14:13ZPhilip Withnalltests: Fix some minor tests in the GResolver tests in manual modeSigned-off-by: Philip Withnall <withnall@endlessm.com>
Closes #1753Signed-off-by: Philip Withnall <withnall@endlessm.com>
Closes #1753https://gitlab.gnome.org/GNOME/glib/-/merge_requests/811tests: Increase buffer size for g_strlcat() tests2019-05-02T14:55:47ZPhilip Withnalltests: Increase buffer size for g_strlcat() testsThere was a buffer overflow on the last g_strlcat() call in the test.
Signed-off-by: Philip Withnall <withnall@endlessm.com>
Fixes: #1768There was a buffer overflow on the last g_strlcat() call in the test.
Signed-off-by: Philip Withnall <withnall@endlessm.com>
Fixes: #17682.61.2https://gitlab.gnome.org/GNOME/glib/-/merge_requests/839tests: Update month name check for Greek locale2019-05-20T12:15:47ZRafał Lużyńskitests: Update month name check for Greek localeUpdate the abbreviated month name in the test to match the actual
translation. Otherwise the test fails with false positive.
Vocabulary:
July (nominative) - Greek: Ιούλιος (abbreviated: Ιούλ)
Of July (genitive) - Greek: Ιουλίου (abbre...Update the abbreviated month name in the test to match the actual
translation. Otherwise the test fails with false positive.
Vocabulary:
July (nominative) - Greek: Ιούλιος (abbreviated: Ιούλ)
Of July (genitive) - Greek: Ιουλίου (abbreviated: Ιουλ)
This is similar to commit 4d215e006ee69bd7a993bf853722993433adbf9a
and commit 7fe793e125c316ac34edd8158df5a132cb044bc1.
Closes #17762.60.3https://gitlab.gnome.org/GNOME/glib/-/merge_requests/841Backport !839 “tests: Update month name check for Greek locale” to glib-2-602019-05-20T12:15:58ZPhilip WithnallBackport !839 “tests: Update month name check for Greek locale” to glib-2-60Update the abbreviated month name in the test to match the actual
translation. Otherwise the test fails with false positive.
Vocabulary:
July (nominative) - Greek: Ιούλιος (abbreviated: Ιούλ)
Of July (genitive) - Greek: Ιουλίου (abbre...Update the abbreviated month name in the test to match the actual
translation. Otherwise the test fails with false positive.
Vocabulary:
July (nominative) - Greek: Ιούλιος (abbreviated: Ιούλ)
Of July (genitive) - Greek: Ιουλίου (abbreviated: Ιουλ)
This is similar to commit 4d215e006ee69bd7a993bf853722993433adbf9a
and commit 7fe793e125c316ac34edd8158df5a132cb044bc1.
Closes #1776
Backport of !839.2.60.3https://gitlab.gnome.org/GNOME/glib/-/merge_requests/859gobject: Add a g_assert_finalize_object() macro2019-07-25T15:42:51ZPhilip Withnallgobject: Add a g_assert_finalize_object() macroThis is a refreshed and slightly tweaked version of @smcv’s macro from #488 (attached to its precursor Bugzilla bug). I split the commit up, added symbol versioning, and made the symbol a `static inline` to get proper type checking.
C...This is a refreshed and slightly tweaked version of @smcv’s macro from #488 (attached to its precursor Bugzilla bug). I split the commit up, added symbol versioning, and made the symbol a `static inline` to get proper type checking.
Closes #4882.61.2https://gitlab.gnome.org/GNOME/glib/-/merge_requests/883tests: Fix small race in GSubprocess tests2019-06-03T10:39:38ZPhilip Withnalltests: Fix small race in GSubprocess testsThis was introduced in commit 7846d6154a: g_subprocess_get_identifier()
will return NULL after the subprocess has exited, and the subprocess in
the `noop` test will exit as soon as it has started spawning. So if the
scheduler scheduled t...This was introduced in commit 7846d6154a: g_subprocess_get_identifier()
will return NULL after the subprocess has exited, and the subprocess in
the `noop` test will exit as soon as it has started spawning. So if the
scheduler scheduled the testprog subprocess quickly, descheduled the
parent test process until the testprog exited, then the return value
from g_subprocess_get_identifier() would be NULL.
Move the g_subprocess_get_identifier() test to one which calls testprog
in `sleep-forever` mode, since that is guaranteed not to exit until
killed (which we do later in the test).
Signed-off-by: Philip Withnall <withnall@endlessm.com>https://gitlab.gnome.org/GNOME/glib/-/merge_requests/891glib/tests/win32.c: Fix test variable types2019-06-04T19:27:01ZChun-wei Fanglib/tests/win32.c: Fix test variable typesHi,
From the commit message:
<i>The variable types for the PID (bp) and event (be) are accidentally reversed in the test program. Correct their types so that tests do not fail on Visual Studio x64 builds.</i>
<i>Fixes issue #17...Hi,
From the commit message:
<i>The variable types for the PID (bp) and event (be) are accidentally reversed in the test program. Correct their types so that tests do not fail on Visual Studio x64 builds.</i>
<i>Fixes issue #1797</i>
With blessings, thank you!LRNLRNhttps://gitlab.gnome.org/GNOME/glib/-/merge_requests/908Improve testfilemonitor test repeatability and debuggability2019-06-19T08:58:02ZPhilip WithnallImprove testfilemonitor test repeatability and debuggabilityThis changes `testfilemonitor` to use a per-test temp directory so you can use it with `--repeat` in Meson, and it improves debug output on failure.
It doesn’t fix the test though, because I can’t get it to fail in the first place.
Hel...This changes `testfilemonitor` to use a per-test temp directory so you can use it with `--repeat` in Meson, and it improves debug output on failure.
It doesn’t fix the test though, because I can’t get it to fail in the first place.
Helps #16342.60.4