g_local_file_trash() needs to be rewritten
@walters
Submitted by Colin Walters Link to original bug (#733574)
Description
A static analyzer complains at me:
- glib-2.40.0/gio/glocalfile.c:2078:tainted_string – Passing tainted string "trashfile" to "rename(char const *, char const *)", which cannot accept tainted data.
Now um...it's probably right but this function is such a twisted mess that step 0) is going to need to be rewriting it in "goto out" style with a single cleanup block rather than attempting a band aid.