glib:glib+slow / thread-pool-slow is randomly hanging
I saw this test causing timeouts in CI for some time, but I wasn't sure if it was a new regression or not...
While I was preparing the dist-file for 2.73.2 (as per #2684 (closed)), this repeatedly failed locally too and after some repeated bisecting I found the guilty commit:
> git bisect run meson test -C ../_BUILD/glib --suite=glib --no-suite=flaky --no-suite=gio --no-suite=gobject --no-suite=no-valgrind -t 0.5
git bisect start
# bad: [89e1d0fe04fd5d40559dc9b96749e1e3c670403c] 2.73.2
git bisect bad 89e1d0fe04fd5d40559dc9b96749e1e3c670403c
# good: [ebfbef1acdfb07d2df610d7213494de45a8433a2] 2.73.1
git bisect good ebfbef1acdfb07d2df610d7213494de45a8433a2
# skip: [164d3759fb9f5ad0be6a023b02d1e381ff7c28bf] Merge branch 'mcatanzaro/#2597' into 'main'
git bisect skip 164d3759fb9f5ad0be6a023b02d1e381ff7c28bf
# good: [e2d2db64339e94390e9ac1d4ddf2a3d43a2d5932] glib/tests/autoptr: Release the acquired locks on GRecMutex
git bisect good e2d2db64339e94390e9ac1d4ddf2a3d43a2d5932
# bad: [afc08836522c84c6d04a81b971d58434711f0666] test: Potentially fix a race in thread-pool-slow test
git bisect bad afc08836522c84c6d04a81b971d58434711f0666
# skip: [1738fad172d2b0ce577080192f3243231f830506] proxyaddressenumerator: set error parameter more thoughtfully
git bisect skip 1738fad172d2b0ce577080192f3243231f830506
# good: [eec8171dabf1b98181e1caafc4ee48036980b2fc] Merge branch 'wip/smcv/more-figure-spaces' into 'main'
git bisect good eec8171dabf1b98181e1caafc4ee48036980b2fc
# good: [6e44151bf74d6afa2211d76c07164ee810368b29] tests: Skip assert-msg-test.py if gdb is non-functional
git bisect good 6e44151bf74d6afa2211d76c07164ee810368b29
# good: [fa05ebe27c4209336a56bcd9ed27572bd7f21b43] docs: Mention alternatives for defining enumeration types
git bisect good fa05ebe27c4209336a56bcd9ed27572bd7f21b43
# good: [5cf742d42eaedbbb7c2b45eaa74773f7eb34fd2b] Merge branch 'ebassi/c99-macro-varargs' into 'main'
git bisect good 5cf742d42eaedbbb7c2b45eaa74773f7eb34fd2b
# good: [f7113ae60748fbb63c44d3d592dcf78285b58005] Merge branch 'uuid-fuzzing' into 'main'
git bisect good f7113ae60748fbb63c44d3d592dcf78285b58005
# skip: [7674fd1504d2156ceb9d3ca18f1432725ca0bb8c] docs: Add a testing policy
git bisect skip 7674fd1504d2156ceb9d3ca18f1432725ca0bb8c
# good: [89b1fe42d761d68735e8755dec8cf62c8dfc5eef] Merge branch 'testing-docs' into 'main'
git bisect good 89b1fe42d761d68735e8755dec8cf62c8dfc5eef
# first bad commit: [afc08836522c84c6d04a81b971d58434711f0666] test: Potentially fix a race in thread-pool-slow test
So apparently changes as per !2667 (merged) (commit afc08836), a fix for this seems easy enough to wait for the release as it would make distributors annoyed by a failing test.