1. 21 Jun, 2018 18 commits
  2. 20 Jun, 2018 5 commits
  3. 19 Jun, 2018 8 commits
  4. 18 Jun, 2018 2 commits
  5. 17 Jun, 2018 3 commits
    • Ting-Wei Lan's avatar
      kqueue: Use the worker context to schedule rescanning of missing files · e714e1e9
      Ting-Wei Lan authored
      This makes it consistent with the file monitor itself, which already
      attaches kqueue event sources to the worker context.
      e714e1e9
    • Ting-Wei Lan's avatar
      tests: Make testfilemonitor test work with kqueue · 454a9f8d
      Ting-Wei Lan authored
      check_expected_events is heavily modified in this commit to tolerate
      event loss and allow renaming to be reported as creation and deletion.
      
      This fixes test failure on FreeBSD.
      454a9f8d
    • Ting-Wei Lan's avatar
      kqueue: Make it possible to pass file monitor tests · 09c019a4
      Ting-Wei Lan authored
      Previously, kqueue file monitor only add event sources for directories
      regardless of the type of the file being monitored. Doing so may be
      possible on inotify, but it is not sufficient on kqueue. Watching a
      directory on kqueue doesn't report changes made to files under it, and
      we must watch files themselves to get notified. This problem is fixed
      by adding a second watch for non-directory file monitors, and the result
      is that we are now able to receive 'CHANGED' and 'ATTRIBUTE_CHANGED'
      events for non-directory files.
      
      Since having two watches on one file monitor requires many code changes
      to work properly, this commit also changes the following things:
      
       - NOTE_ALL macro is now replaced by note_all inline function. Since the
         kqueue backend is shared by all BSD operating systems, there are a
         few difference between these systems. It is easier to do '#ifdef'
         check in a function than in a macro.
      
       - Both g_kqueue_file_monitor_callback and g_kqueue_file_monitor_cancel
         now holds a lock before accessing kqueue_sub structs. This fixes a
         crash when these two functions are called from different threads,
         causing g_kqueue_file_monitor_callback to access freed memory.
      
       - 'mask' variable in g_kqueue_file_monitor_callback is now removed.
         The usage of 'mask' was wrong because of the 'mask > 0' check.
         'CHANGED' event has value 0 so the 'mask > 0' check made it
         impossible to emit 'CHANGED' events.
      
       - kqueue-missing scans can now be triggered from the kqueue event
         callback instead of always waiting for 4 seconds.
      
       - Don't remove a file from kqueue on unlink unless its hard link count
         has dropped to zero.
      
       - Don't use 'else if' in the check of 'fflags'. It is possible for a
         kevent to have multiple flags set.
      
       - Don't use g_file_monitor_emit_event directly. Always use
         g_file_monitor_source_handle_event to report events.
         Events submitted to g_file_monitor_emit_event are delivered
         immediately, but events sent to g_file_monitor_source_handle_event
         are scheduled by GLocalFileMonitor. If we mix the two, the order of
         events will be wrong and tests will fail.
      
       - Report 'CHANGES_DONE_HINT' immediately after 'CREATED' if the file
         created is not a regular file. This is copied from ih_event_callback.
      09c019a4
  6. 15 Jun, 2018 4 commits