GRegex is based off of PCRE1, and cannot be moved to PCRE2 without
breaking its API contract. PCRE1 is in maintenance mode, and will not
see any new feature.

GRegex made sense back in the day when we embedded a copy of PCRE, but:

 - the maintenance burden required to update the copy of PCRE to keep up
   with upstream, coupled with the lack of synchronisation between GLib
   and PCRE releases, has become too high
 - downstream distributors try very hard to not rely on vendored
   dependencies, which meant that GLib depended on a system copy of PCRE
   anyway, except on certain platforms, which made for interesting bugs
 - regular expressions are a niche use case, and PCRE is already
   portable to all the platforms GLib cares about

Thus, we recommend users to migrate their code from GRegex to PCRE2.

Fixes: #1085

Signed-off-by: Philip Withnall <pwithnall@endlessos.org>

tests: Rewrite thread-pool test for freeing queued items

Closes #2456

See merge request !2229

The previous test was racy: it assumed that not all queued thread pool
jobs would start to be executed before `g_thread_pool_free()` was
called, whereas actually on some systems (particularly BSD ones), they
would all start (or even finish) being executed, and hence the free
function might never be called.

Rewrite the test to:
 • Synchronise the test function and worker thread functions more
   closely.
 • Not bother about ordering the shared and exclusive variants of the
   test differently. That seems to be a hangover from another test
   above.
 • Limit the number of worker threads to 1, rather than 2, since this
   makes the test easier to control.

This has been tested with `--repeat 10000` on Linux, and it succeeds all
of those runs whereas previously it failed quite reliably.
Signed-off-by: Philip Withnall <pwithnall@endlessos.org>

Fixes: #2456

Now that `g_thread_pool_new_full()` can be used to set a user-provided
free function for queue elements, ensure that the internal dummy item
used to wake up the worker threads is removed from the queue before it’s
called.
Signed-off-by: Philip Withnall <pwithnall@endlessos.org>

Helps: #2456

giotypes: Document refcounting of source object for GAsyncReadyCallback

Closes #2343

See merge request !1988

Revert "gdbus: Use DBUS_SESSION_BUS_ADDRESS if AT_SECURE but not setuid"

Closes #2316

See merge request GNOME/glib!2212

gtestutils: Add more convenience functions

See merge request !2215

Signed-off-by: Simon McVittie <smcv@collabora.com>

This allows a pattern like

    g_test_message ("cannot reticulate splines: %s", error->message);
    g_test_fail ();

to be replaced by the simpler

    g_test_fail_printf ("cannot reticulate splines: %s", error->message);

with the secondary benefit of making the message available to TAP
consumers as part of the "not ok" message.
Signed-off-by: Simon McVittie <smcv@collabora.com>

Signed-off-by: Simon McVittie <smcv@collabora.com>

Forming the g_test_skip() message from printf-style arguments seems
common enough to deserve a convenience function.

g_test_incomplete() is mechanically almost equivalent to g_test_skip()
(the semantics are different but the implementation is very similar),
so give it a similar mechanism for symmetry.
Signed-off-by: Simon McVittie <smcv@collabora.com>

tests: Add missing wakeup calls to gdbus-names test

See merge request !2157

Annotate the GString constructors

See merge request !2226

Docs: Mention that G_VA_COPY() must be followed by `va_end()`

See merge request !2224

Otherwise the introspection scanner won't recognise them as
constructors, because the GString get_type function has a different
symbol prefix.

See: gobject-introspection#399

build: Fix implicit declaration of function errors

See merge request !2225

Include the correct system headers for each test that meson performs.
This allows system capabilities to be detected correctly even if
implicit declaration of functions is considered an error.

gio: Add portal version of GPowerProfileMonitor

See merge request !2222

assertEventually is a helper used in a number of projects that use
dbusmock.

See https://github.com/martinpitt/python-dbusmock/issues/82

Tests both the portal and direct D-Bus variants.

gwin32packageparser: Fix read past end of buffer

Closes #2454

See merge request !2213

docs: Mention the stable/unstable support version in README.md

See merge request !2165

tests: Fix error handling when testing gtestutils

See merge request !2216

Improve documentation of various TLS stuff

See merge request !2211

We had two compensating bugs here. We didn't correctly clear the
error indicator after testing a test-case that calls g_test_fail(),
which meant we were leaving the error set to exit status 1 when
falling through to the next test; and then we didn't check the exit
status of the next test, but instead assumed that g_spawn_sync()
would fail (it does not).
Signed-off-by: Simon McVittie <smcv@collabora.com>

Let's explain the advantages of relying on GTlsConnection to perform
certificate verification.

Also, document that the issuer property is a little tricky, because the
issuer certificate might not be the certificate that actually gets used
in final certification path building. This is very unexpected to anybody
who is not an expert.

Because TLS certificate verification is extremely complex, the lookup
issuer function may be tempting to misuse even by experienced
developers. There is a notion that the issuer certificate will always be
used in the final certification path, but it's just not always true.
Trying to make security decisions based on the results of this function is
a trap, so let's document that.

It turns out that old versions of glib-networking actually reordered the
certificate chain to match the final verification path. This no longer
happens since a long time ago, because it was a buggy mess. Instead, we
rely on the TLS library to build the final verification path. Their path
building is not very good, but at least it's consistent. The point of
these doc updates is to clarify that only the TLS library can make
security decisions.

Document that HTTP requests may be performed to look up missing
certificates.

Finally, let's document that certificate verification using GTlsDatabase
cannot be as smart as certificate verification performed directly by
GTlsConnection.

g_win32_package_parser_enum_packages() reads beyond the end of a buffer
when doing a memcpy.  With app verifier enabled on Windows, it causes
the application to crash on startup.

This change limits the memcpy to the size of the source string.

Fixes: #2454