docs: Drop section about default branch renaming from README.md

See merge request !3345

tools: Drop check-abis.sh script

See merge request !3344

It’s been there for 2 years (since commit d8116521

), people have
probably got the message by now.

Signed-off-by: Philip Withnall <pwithnall@endlessos.org>

Signed-off-by: Philip Withnall <pwithnall@endlessos.org>

It hasn’t been used for years, and isn’t really needed since we changed
to explicitly exporting symbols (using `GLIB_AVAILABLE_IN_*`) rather than
implicitly exporting them unless they were hidden.

Signed-off-by: Philip Withnall <pwithnall@endlessos.org>

gfileinfo: Temporarily downgrade missing attribute criticals to debugs

See merge request !3338

This partially reverts ed8e86a7.

The change to add the criticals (commit ed8e86a7) is correct, but
landed too late in the cycle. Let’s downgrade the criticals to debugs
for now, to stop applications seeing a lot of new criticals in their
output. Those criticals are particularly disruptive for command line
applications and unit tests.

Early in the next cycle, the debugs will be re-upgraded to criticals.
This will give applications a whole additional cycle to fix their
ambiguous use of API.

It turned out that a lot of applications have latent bugs around
calling `g_file_info_get_*()` without checking whether an attribute
is set first, and were hence relying on the ‘unknown’ return value
also being an appropriate default for them.

This was compounded by the fact that several non-local GVFS backends
were not setting `GFileInfo` attributes all the time, which caused the
‘missing attribute’ code path to be hit more frequent...

gfileenumerator: Clarify termination condition for next_files_async()

Closes #352

See merge request !3339

tests: Check a few results in strfuncs tests

See merge request !3330

gstrfuncs: Clarify haystack_len behaviour of g_strstr_len()

Closes #159

See merge request !3331

gio: Add some missing file info attribute checks in gio-list and gio-tree

Closes #2948

See merge request !3336

This is written in pseudocode C which omits all the callback boilerplate
for the async calls. This should hopefully make the overall structure of
the loop more obvious.

Signed-off-by: Philip Withnall <pwithnall@endlessos.org>

Helps: #352

Owen Taylor authored Mar 21, 2023 and Philip Withnall committed Mar 21, 2023

As suggested on #352

 by Owen Taylor (commit put together by Philip
Withnall, but in Owen’s name as it’s his wording).

Signed-off-by: Philip Withnall <pwithnall@endlessos.org>

Fixes: #352

Before commit ed8e86a7, this function would have silently returned a
zero-valued `GTimeVal` if the correct attributes weren’t present.

That partially regressed in commit ed8e86a7, which made it return with
a critical warning, but without zeroing the `GTimeVal`. The critical
warning can be ignored by users (it doesn’t abort the process unless
`G_DEBUG=fatal-criticals` is set), but the change in behaviour of
zeroing the `GTimeVal` could cause bugs.

See: #2907



Signed-off-by: Philip Withnall <pwithnall@endlessos.org>

Missed from the fixes for #2907

.

Signed-off-by: Philip Withnall <pwithnall@endlessos.org>

Further fallout from #2907

.

Signed-off-by: Philip Withnall <pwithnall@endlessos.org>

Fixes: #2948

gvariant: Document failure behaviour of g_variant_dict_lookup() better

Closes #919

See merge request !3334

Signed-off-by: Philip Withnall <pwithnall@endlessos.org>

Fixes: #919

Signed-off-by: Philip Withnall <pwithnall@endlessos.org>

Fixes: #159

This fixes some written-but-never-read warnings from `scan-build`.

Signed-off-by: Philip Withnall <pwithnall@endlessos.org>

gtestutils: Clarify docs about calling g_test_init() before anything

Closes #2943

See merge request !3327

Signed-off-by: Philip Withnall <pwithnall@endlessos.org>

Fixes: #2943

tests: Reduce number of iterations in queue test

See merge request !3324

gstrfuncs: Improve inline version of g_strdup() to avoid breaking C++ code

Closes #2936

See merge request !3322

inotify: Avoid empty root directory string

See merge request !3241

Remove an unnecessary intermediate variable.

This introduces no functional changes.

Signed-off-by: Philip Withnall <pwithnall@endlessos.org>

This introduces no functional changes.

Signed-off-by: Philip Withnall <pwithnall@endlessos.org>

Unless `-m thorough` is passed to the tests, reduce the number of
iterations in the random test.

This one test case takes the bulk of the time to run the `queue` test
suite, and is sometimes causing timeouts when running on CI
(particularly under valgrind). Reduce it to a fifth.

Signed-off-by: Philip Withnall <pwithnall@endlessos.org>

This is put together through git archaeology:
```
git log glib/tests/queue.c
git log -- tests/queue-test.c
```

The following commits were too trivial to have meaningful copyright:
 - 8f02fac4
 - d81ac533
 - 29f2ced8
 - 1a2c5e15
 - 8a90f5e9
 - 45dae4b5
 - 2aa71ab6
 - 3a74ad12



Signed-off-by: Philip Withnall <pwithnall@endlessos.org>

Helps: #1415

It won’t get compiled out with `G_DISABLE_ASSERT`.

Signed-off-by: Philip Withnall <pwithnall@endlessos.org>

While we can’t check for any events on it, this at least tests that
creating a file monitor works. It should cover the fix from the previous
commit.

Signed-off-by: Philip Withnall <pwithnall@endlessos.org>

Helps: !3241

gdesktopappinfo: Add a missing NULL check

See merge request !3325

This should catch regressions in the critical warning fixed in the
previous commit.

The launch has to have several conditions:
 - Session bus is running (to avoid the launch happening via the spawn
   codepath)
 - Use a non-existent D-Bus name (to trigger a launch error)
 - Use a launch context (to hit the critical warning code path)
 - Not have a startup ID specified in the platform data — this implies
   having an empty launch context
 - Use an async launch, as that provides an error handling path

Signed-off-by: Philip Withnall <pwithnall@endlessos.org>

Wrap the logic into a G_ALWAYS_INLINE function, instead of using a
complex statement-expression which is not allowed in braced initializer
lists and expanded into some bad thing when it's used as
`::g_strdup(...)`.

We cannot use `__builtin_constant_p (str)` because GCC documentation
clearly states that it always produces 0 when str is a const char *
argument of an inline function.  But `__builtin_constant_p (!str)`,
`__builtin_constant_p (!!str)`, and
`__builtin_constant_p (strlen (str))` functions properly with `-O1` or
above enabled.

Fixes #2936.

It’s possible for the startup ID to be `NULL` if one wasn’t provided in
the platform data passed to `launch_uris_with_dbus()`.

Passing `NULL` to `g_app_launch_context_launch_failed()` causes a
critical warning.

Signed-off-by: Philip Withnall <pwithnall@endlessos.org>

tests: Fix timeout sources in gdbus-auth and gapplication tests

See merge request !3323

The timeout runs for the entire duration of the test, which is a
function that Meson’s test harness already provides for us.

Meson’s timeout can be easily adjusted by a factor to allow for running
tests more slowly under valgrind. The timeout in the code cannot, which
leads to spurious failures like
https://gitlab.gnome.org/GNOME/glib/-/jobs/2645271

.

Signed-off-by: Philip Withnall <pwithnall@endlessos.org>

If the timeout callback was executed, it would remove the timeout
source, leaving the `g_source_remove()` call in the main function with a
dangling source ID.

Fixes commit 73205b8b.

Spotted in https://gitlab.gnome.org/GNOME/glib/-/jobs/2645271

.

Signed-off-by: Philip Withnall <pwithnall@endlessos.org>

tests: Change the time function used in the bookmark tests

See merge request !3315