GitLab

Signed-off-by: Philip Withnall <withnall@endlessm.com>

Various GUri code, documentation and API fixes

Closes #2149

See merge request !1610

Nothing particularly interesting or major.
Signed-off-by: Philip Withnall <withnall@endlessm.com>

Make `G_URI_FLAGS_PARSE_RELAXED` available instead, for the
implementations which need to handle user-provided or incorrect URIs.
The default should nudge people towards being compliant with RFC 3986.

This required also adding a new `G_URI_PARAMS_PARSE_RELAXED` flag, as
previously parsing param strings *always* used relaxed mode and there
was no way to control it. Now it defaults to using strict mode, and the
new flag allows for relaxed mode to be enabled if needed.
Signed-off-by: Philip Withnall <withnall@endlessm.com>

Fixes: #2149

According to my reading of
https://tools.ietf.org/html/rfc3986#section-4, the only requirement for
a URI to be ‘absolute’ (actually, not a relative reference) is for the
scheme to be specified. A hostname doesn’t have to be specified: see any
of the options in the `hier-part` production in
https://tools.ietf.org/html/rfc3986#appendix-A

 which don’t include
`authority`.
Signed-off-by: Philip Withnall <withnall@endlessm.com>

This reduces the possibility for overflow, and makes the code a little
more conventional to read.
Signed-off-by: Philip Withnall <withnall@endlessm.com>

`guint8` is the conventional way in modern GLib APIs to represent ‘a byte
which could contain arbitrary binary’. `guchar` is not advised for that
(even though it’s equivalent) because it could be misread as `gchar`.
Signed-off-by: Philip Withnall <withnall@endlessm.com>

This reduces the chance of the caller accidentally double-freeing or
use-after-free-ing something.
Signed-off-by: Philip Withnall <withnall@endlessm.com>

This introduces no functional changes, but makes the code a little
easier to read.
Signed-off-by: Philip Withnall <withnall@endlessm.com>

This should make the RFC easier to refer to in future.
Signed-off-by: Philip Withnall <withnall@endlessm.com>

Sometimes there are sensitive details in URI query components, so we
should provide the option for hiding them too.
Signed-off-by: Philip Withnall <withnall@endlessm.com>

Use nice curly Unicode quotes.
Signed-off-by: Philip Withnall <withnall@endlessm.com>

This introduces no functional changes, just makes the code a bit easier
to read.
Signed-off-by: Philip Withnall <withnall@endlessm.com>

Signed-off-by: Philip Withnall <withnall@endlessm.com>

This brings its naming in line with the ‘generic’ error codes in other
error domains.

This is not an API break since `GUriError` hasn’t been in a release yet.
Signed-off-by: Philip Withnall <withnall@endlessm.com>

Signed-off-by: Philip Withnall <withnall@endlessm.com>

guri: Document and check restrictions on path prefixes

See merge request !1612

guri: Always prepend `//` to the host when building a URI

See merge request !1611

RFC 3986, section 3 says:
> The scheme and path components are required, though the path may be
> empty (no characters).  When authority is present, the path must
> either be empty or begin with a slash ("/") character.  When
> authority is not present, the path cannot begin with two slash
> characters ("//").  These restrictions result in five different ABNF
> rules for a path (Section 3.3), only one of which will match any
> given URI reference.

(See https://tools.ietf.org/html/rfc3986#section-3.

)

Given that those conditions are almost always going to be true, and that
typically the number and form of arguments passed to g_uri_join() will
be known at compile time, it would be unnecessarily awkward to add a
`GError` argument to g_uri_join() to detect these situations.

Instead, add precondition checks and document the restrictions.
Developers are responsible for ensuring their paths are in the right
format themselves.
Signed-off-by: Philip Withnall <withnall@endlessm.com>

This is needed to distinguish the host (‘authority’ in the terms of RFC
3986) from a path if a scheme is not present.

It can be seen from the grammar in RFC 3986
(https://tools.ietf.org/html/rfc3986#appendix-A) that `authority` only
ever appears after `"//"`.

Spotted by Simon McVittie in
!1606 (comment 884893)

.
Signed-off-by: Philip Withnall <withnall@endlessm.com>

Fix multiple typos in guri.c

See merge request !1609

meson: Don't use gnulib for printf on iOS

Closes #1868

See merge request !1607

iOS and tvOS use the same printf family as macOS, and these all have
been available on macOS for a long time.

Closes #1868

uri: allow to join a partial URI, without scheme

Closes #2166

See merge request !1606

Fixes: #2166

Signed-off-by: Marc-André Lureau <marcandre.lureau@redhat.com>

Add GUriParamsIter

See merge request !1572

Replace _g_uri_parse_authority() with GUri

Closes #2156

See merge request !1567

Make g_hostname_is_ip_address() accept ipv6 zoneid

See merge request !1604

GFile: Document that G_FILE_CREATE_REPLACE_DESTINATION can only be used with...

See merge request !1594

The test was failing since commit 20ae4b46

 ("uri: do not add ipv6
brackets on non-ip host").
Signed-off-by: Marc-André Lureau <marcandre.lureau@redhat.com>

Signed-off-by: Marc-André Lureau <marcandre.lureau@redhat.com>

Add support to ignore trash for certain mounts

See merge request !1549

Ondrej Holy authored Jun 23, 2020 and Philip Withnall committed Aug 05, 2020

Add support for x-gvfs-notrash mount option, which allows to disable
trash functionality for certain mounts. This might be especially useful
e.g. to prevent trash folder creation on enterprise shares, which are
also accessed from Windows...

https://bugzilla.redhat.com/show_bug.cgi?id=1096200

Ondrej Holy authored Jun 23, 2020 and Philip Withnall committed Aug 05, 2020

There is already g_unix_mount_at function which allows to find certain
unix mount for given mount path. It would be useful to have similar
function for mount points, which will allow to replace custom codes in
gvfs. Let's add g_unix_mount_point_at.

See also:
!1328 (comment 863735)

uri: do not encode ':' and ';' from userinfo

See merge request !1600