1. 15 May, 2010 5 commits
  2. 14 May, 2010 26 commits
    • Christian Persch's avatar
      Plug mem leaks in gdbus tests & examples · 661e5ea6
      Christian Persch authored
      Use "&s" instead of "s", and free the variant iters after use.
      
      Bug #618663.
      661e5ea6
    • Christian Persch's avatar
      Plug a mem leak in gdbusauth · 60c53fef
      Christian Persch authored
      From valgrind running gdbus-peer test:
      
      ==20513== 32 bytes in 1 blocks are definitely lost in loss record 1 of 15
      ==20513==    at 0x4024E4C: realloc (vg_replace_malloc.c:429)
      ==20513==    by 0x4079BB1: g_realloc (gmem.c:174)
      ==20513==    by 0x4099472: g_string_maybe_expand (gstring.c:396)
      ==20513==    by 0x409A42A: g_string_insert_c (gstring.c:1050)
      ==20513==    by 0x42169AC: g_string_append_c_inline (gstring.h:153)
      ==20513==    by 0x421682C: _my_g_input_stream_read_line_safe (gdbusauth.c:336)
      ==20513==    by 0x421843E: _g_dbus_auth_run_server (gdbusauth.c:1265)
      ==20513==    by 0x4222B94: initable_init (gdbusconnection.c:1783)
      ==20513==    by 0x41CF8D5: g_initable_init (ginitable.c:106)
      ==20513==    by 0x41CFA8D: g_initable_new_valist (ginitable.c:219)
      ==20513==    by 0x41CF920: g_initable_new (ginitable.c:139)
      ==20513==    by 0x4223479: g_dbus_connection_new_sync (gdbusconnection.c:2046)
      
      Bug #618650.
      60c53fef
    • Christian Persch's avatar
      Plug mem leak in g_dbus_address_get_stream_sync · 5bc9d432
      Christian Persch authored
      ==6279== 21,615 (4,708 direct, 16,907 indirect) bytes in 169 blocks are
      definitely lost in loss record 12 of 13
      ==6279==    at 0x4024D2E: malloc (vg_replace_malloc.c:207)
      ==6279==    by 0x4079A90: g_malloc (gmem.c:135)
      ==6279==    by 0x4079DC8: g_malloc_n (gmem.c:252)
      ==6279==    by 0x4097E66: g_strsplit (gstrfuncs.c:2434)
      ==6279==    by 0x42169A2: g_dbus_address_get_stream_sync
      (gdbusaddress.c:875)
      
      Bug #618622.
      5bc9d432
    • Christian Persch's avatar
      Plug a mem leak in get_uninitialized_connection · dc39825a
      Christian Persch authored
      Free the bus address after creating the singleton.
      
      ==26308== 39,736 (10,517 direct, 29,219 indirect) bytes in 388 blocks
      are definitely lost in loss record 14 of 15
      ==26308==    at 0x4024D2E: malloc (vg_replace_malloc.c:207)
      ==26308==    by 0x4079A90: g_malloc (gmem.c:135)
      ==26308==    by 0x4079DC8: g_malloc_n (gmem.c:252)
      ==26308==    by 0x4095607: g_strdup (gstrfuncs.c:102)
      ==26308==    by 0x4216B9A: g_dbus_address_get_for_bus_sync
      (gdbusaddress.c:961)
      ==26308==    by 0x422A7AE: get_uninitialized_connection
      (gdbusconnection.c:5241)
      
      Bug #618622.
      dc39825a
    • Christian Persch's avatar
      Plug mem leaks in parse_value_from_blob · 5b2c7f10
      Christian Persch authored
      The result of read_string() was leaked.
      
      Bug #618615.
      5b2c7f10
    • Christian Persch's avatar
      Plug a mem leak · 0a7c0ac7
      Christian Persch authored
      This code leaked the return value of g_variant_get_child_value();
      use g_variant_get() instead and free the iter when done.
      0a7c0ac7
    • David Zeuthen's avatar
      GDBus: Remove cached value if a property is invalidated · ddc94bd0
      David Zeuthen authored
      Also add a test case to catch this.
      Signed-off-by: default avatarDavid Zeuthen <davidz@redhat.com>
      ddc94bd0
    • David Zeuthen's avatar
      GDBus: Fix serialization of empty arrays · bb6530eb
      David Zeuthen authored
      It turns out that we didn't observe padding (neither when reading nor
      writing) for empty arrays which (apparently) is needed according to
      the D-Bus spec and reference implementation. A simple test case to
      provoke this behavior is as follows (notice the lack of 4 bytes worth
      of padding at position 0x0064):
      
       Error calling dbus_message_demarshal() on this blob: org.freedesktop.DBus.Error.InvalidArgs: Message is corrupted (Alignment padding not null)
       0000: 6c 01 00 01  2e 00 00 00  41 00 00 00  37 00 00 00    l.......A...7...
       0010: 08 01 67 00  08 73 61 7b  73 76 7d 61  73 00 00 00    ..g..sa{sv}as...
       0020: 01 01 6f 00  08 00 00 00  2f 66 6f 6f  2f 62 61 72    ..o...../foo/bar
       0030: 00 00 00 00  00 00 00 00  03 01 73 00  06 00 00 00    ..........s.....
       0040: 4d 65 6d 62  65 72 00 00  11 00 00 00  30 31 32 33    Member......0123
       0050: 34 35 36 37  38 39 30 31  32 33 34 35  36 00 00 00    4567890123456...
       0060: 00 00 00 00  0e 00 00 00  09 00 00 00  53 6f 6d 65    ............Some
       0070: 74 68 69 6e  67 00                                    thing.
      
       The blob was generated from the following GVariant value:
       ('01234567890123456', @a{sv} {}, ['Something'])
      
       If the blob was encoded using DBusMessageIter, the payload would have been:
      
       0000: 6c 01 00 01  32 00 00 00  41 00 00 00  36 00 00 00    l...2...A...6...
       0010: 01 01 6f 00  08 00 00 00  2f 66 6f 6f  2f 62 61 72    ..o...../foo/bar
       0020: 00 00 00 00  00 00 00 00  03 01 73 00  06 00 00 00    ..........s.....
       0030: 4d 65 6d 62  65 72 00 00  08 01 67 00  08 73 61 7b    Member....g..sa{
       0040: 73 76 7d 61  73 00 00 00  11 00 00 00  30 31 32 33    sv}as.......0123
       0050: 34 35 36 37  38 39 30 31  32 33 34 35  36 00 00 00    4567890123456...
       0060: 00 00 00 00  00 00 00 00  0e 00 00 00  09 00 00 00    ................
       0070: 53 6f 6d 65  74 68 69 6e  67 00                       Something.
       ** ERROR:gdbus-serialization.c:547:check_serialization: code should not be reached
       Aborted
      
      and this is now in the libdbus-1-using serialization test case.
      Signed-off-by: default avatarDavid Zeuthen <davidz@redhat.com>
      bb6530eb
    • Jorge González's avatar
      Updated Spanish translation · 285a1246
      Jorge González authored
      285a1246
    • Matthias Clasen's avatar
      bump version · 02af71c7
      Matthias Clasen authored
      02af71c7
    • Matthias Clasen's avatar
      2.25.4 · cff9d83f
      Matthias Clasen authored
      cff9d83f
    • Allison Karlitskaya's avatar
      c57c61c9
    • Matthias Clasen's avatar
      another !srcdir build fix · ee9b1624
      Matthias Clasen authored
      ee9b1624
    • Matthias Clasen's avatar
      More !srcdir build fixes · 159f533a
      Matthias Clasen authored
      159f533a
    • Allison Karlitskaya's avatar
      include gunixcredentialsmessage from unixsocket · d8d1a02c
      Allison Karlitskaya authored
      fixes a build issue
      d8d1a02c
    • Matthias Clasen's avatar
      Cleanups · 1d22b648
      Matthias Clasen authored
      Sort #includes a bit better, and don't include platform-specific
      headers in gio.h.
      1d22b648
    • Matthias Clasen's avatar
      Fix !srcdir build · 05407989
      Matthias Clasen authored
      Thankfully we already had a SRCDIR define.
      05407989
    • Matthias Clasen's avatar
      Fix a typo · c6f01b32
      Matthias Clasen authored
      c6f01b32
    • Matthias Clasen's avatar
      Updates · 45cad58b
      Matthias Clasen authored
      45cad58b
    • Matthias Clasen's avatar
      Documentation cleanups · 4e7764fb
      Matthias Clasen authored
      4e7764fb
    • Matthias Clasen's avatar
      Merge branch 'gdbus-merge' · 6223341c
      Matthias Clasen authored
      Conflicts:
      	docs/reference/gio/gio-docs.xml
      	docs/reference/gio/gio-sections.txt
      	gio/tests/Makefile.am
      6223341c
    • Matthias Clasen's avatar
      Remove a reference to Pango · a7c4c7de
      Matthias Clasen authored
      a7c4c7de
    • Matthias Clasen's avatar
      The default timeout is 25s · 6e8637e4
      Matthias Clasen authored
      6e8637e4
    • Matthias Clasen's avatar
      Document more floating variant details. · bdc29f82
      Matthias Clasen authored
      bdc29f82
    • Matthias Clasen's avatar
      e72f7f52
    • Matthias Clasen's avatar
      Clean up platform-specific includes · 8f89b639
      Matthias Clasen authored
      The problem was pointed out in bug 618029. To solve it, we moved
      the GUnixFDList typedef to giotypes.h.
      8f89b639
  3. 13 May, 2010 9 commits