1. 16 Jan, 2013 2 commits
    • Dan Winship's avatar
      gio/tests: add some more async stream tests · 578b657f
      Dan Winship authored
      Add read_async() and skip_async() tests to buffered-input-stream.
      
      Fix and re-enable filter-streams's existing close_async() tests, and
      add read_async(), skip_async(), and write_async() tests as well. Also,
      redo the tests to use dummy GFilterInputStream and GFilterOutputStream
      subclasses rather than GBufferedInput/OutputStream, so that we're
      testing the base filter stream implementations of everything (since
      the buffered stream overrides are already getting tested in the
      buffered-input-stream and buffered-output-stream tests anyway).
      
      Add a skip_async() test to unix-streams. (This one would crash without
      the bugfix in the previous commit.)
      578b657f
    • Alban Browaeys's avatar
      gio: callback_data is the task not the task data. · acfa6e23
      Alban Browaeys authored
      skip_callback_wrapper expect the user_data (callback_data)
      to be the task holding the task_data, not the task_data
      itself.
      Otherwise the task_data is cast as GTask and then task_data
      is extracted from this bogus task.
      
      https://bugzilla.gnome.org/show_bug.cgi?id=691812
      acfa6e23
  2. 15 Jan, 2013 21 commits
  3. 14 Jan, 2013 15 commits
    • Matthias Clasen's avatar
      Fix the assert-msg test · d1c25d31
      Matthias Clasen authored
      gdb is playing games with us, by breaking -x /dev/stdin
      d1c25d31
    • Matthias Clasen's avatar
      Remove an unused function · ba4a3849
      Matthias Clasen authored
      ba4a3849
    • Matthias Clasen's avatar
      Make the build more quiet · 57041baf
      Matthias Clasen authored
      57041baf
    • Allison Karlitskaya's avatar
      win32: hide g_win32_app_info_get_type() · 456d6bb3
      Allison Karlitskaya authored
      This was in a private header file and was never part of the public ABI.
      Hide it again.
      
      Caught by Dieter Verfaillie.
      456d6bb3
    • Allison Karlitskaya's avatar
      glocal*monitor: export ABI only on UNIX · b7e749fc
      Allison Karlitskaya authored
      Add an #ifdef G_OS_UNIX around the GLIB_AVAILABLE_IN_ALL annotation on
      the _get_type() functions for GLocal{File,Directory}Monitor.
      
      These symbols are in private header files and are only exported so that
      the in-tree file monitoring modules can subclass.  This is only needed
      on UNIX and was therefore never part of the public ABI on Windows.
      
      Caught by Dieter Verfaillie.
      b7e749fc
    • Allison Karlitskaya's avatar
      win32: hide _glib_get_dll_directory again · 963243e6
      Allison Karlitskaya authored
      This is not part of our public ABI and it's not used from the other
      libraries in GLib, so we should not be exporting it.
      
      Caught by Dieter Verfaillie.
      963243e6
    • Martin Pitt's avatar
      GParamSpec: Make constructors introspectable · aac82672
      Martin Pitt authored
      Commit 282366c3 unnecessarily (skip)ed all the GParamSpec constructors like
      g_param_spec_bool(). Make those introspectable by dropping the (skip) and
      adding proper transfer annotations.
      
      Keep g_param_spec_value_array() skipped as GValueArray is deprecated.
      aac82672
    • Allison Karlitskaya's avatar
      tests: introduce a small hack for visibility · 2c13657b
      Allison Karlitskaya authored
      One of our testcases builds a small giomodule for testing the loading of
      modules containing resources.  Unfortunately, this module gets built
      using the same CFLAGS as the rest of GLib, including the visibility
      flags (defaulting to hidden).
      
      Use "config.h" to get a declaration of _GLIB_EXTERN that will export
      symbols properly and use it to annotate the necessary APIs.
      2c13657b
    • Allison Karlitskaya's avatar
      gthread-impl.c: add missing #include "config.h" · f8756694
      Allison Karlitskaya authored
      One of the features of our new symbol exporting regime is that it forces
      config.h to be included at the top of every .c file.
      
      This was missed in gthread-impl.c.
      
      The only reason this wasn't noticed is because nothing in this file is
      being used anymore.  We need those symbols to continue to be exported
      for reasons of ABI backwards compatibility, however.
      f8756694
    • Allison Karlitskaya's avatar
      kqueue: Reduce G_GNUC_INTERNAL + G_LOCK abuse · 59e46c49
      Allison Karlitskaya authored
      The kqueue file monitoring backend was misusing G_GNUC_INTERNAL for want
      of 'static' in a couple of places and also using it to declare a lock
      that was never used at all.
      
      Fix those up.
      59e46c49
    • Allison Karlitskaya's avatar
      gio: remove export tags from two private headers · 64e1a9ca
      Allison Karlitskaya authored
      I got a little bit too excited and added GLIB_AVAILABLE_IN_ALL tags to
      some internal API.
      64e1a9ca
    • Allison Karlitskaya's avatar
      win32: build: stop using .def files · 068a119f
      Allison Karlitskaya authored
      With visibility now under the control of __declspec(dllexport) we no
      longer need to build .def files or use them for building our various
      .dll files.
      
      .def files used to be installed (even though it is only really useful
      when creating the .dll or .lib file).  Don't do that anymore either.
      
      The Makefiles still contain rules to create a .lib file for use with
      Visual Studio and these rules require .def files.  There are special
      requirements to using these rules (like having installed and setup
      Microsoft tools for use during the build) and therefore the problem of
      creating a .def file for use with them is left open to anyone willing to
      make the effort.  Many options are available depending on which
      toolchain is in use (dlltool, pexport, gendef, dumpbin.exe, just to name
      a few).
      
      If we can find a free tool for creating .lib files in the future, we
      should probably revisit this issue and add proper support back to our
      build system.
      068a119f
    • Allison Karlitskaya's avatar
      configure.ac: change our visibility policy · 2e7669f5
      Allison Karlitskaya authored
      Check for -fvisibility=hidden as a supported CFLAG.
      
      If it is supported, use it and emit an AC_DEFINE to change the meaning
      of _GLIB_EXTERN to include the GNU attribute for marking symbols as
      public: __attribute((visibility("default"))).
      
      This will override the public definition of _GLIB_EXTERN for any file
      which does #include "config.h" (forcing all our .c files to do so, as a
      side effect).
      
      If we're on mingw, assume that -fvisibility will work and also throw in
      a __declspec(dllexport) for good measure.  This will allow us to move
      away from using a .def file to create the the various DLLs.
      
      It's possible that there may be compilers that accept
      -fvisibility=hidden but don't accept the GNU attribute for making
      symbols public again -- we will hopefully receive bugs if any of those
      exist.
      
      https://bugzilla.gnome.org/show_bug.cgi?id=688681
      2e7669f5
    • Allison Karlitskaya's avatar
      win32: visibility fixups · f13d3c07
      Allison Karlitskaya authored
      Add/remove visibility macros according to if symbols were previously
      part of our public win32 API.
      f13d3c07
    • Allison Karlitskaya's avatar
      gio: hide another leaked symbol · 38359d17
      Allison Karlitskaya authored
      guint g_menu_model_items_changed_signal leaked out.  Tuck it back in.
      38359d17
  4. 13 Jan, 2013 2 commits