1. 19 Mar, 2021 1 commit
    • Philip Withnall's avatar
      glib: Use g_memdup2() instead of g_memdup() in obvious places · 0ace82d7
      Philip Withnall authored
      
      
      Convert all the call sites which use `g_memdup()`’s length argument
      trivially (for example, by passing a `sizeof()` or an existing `gsize`
      variable), so that they use `g_memdup2()` instead.
      
      In almost all of these cases the use of `g_memdup()` would not have
      caused problems, but it will soon be deprecated, so best port away from
      it
      
      In particular, this fixes an overflow within `g_bytes_new()`, identified
      as GHSL-2021-045 (aka CVE-2021-27219) by GHSL team member Kevin Backhouse.
      
      Adapted for GLib 2.58 by Simon McVittie.
      Signed-off-by: Philip Withnall's avatarPhilip Withnall <pwithnall@endlessos.org>
      Fixes: CVE-2021-27219
      Fixes: GHSL-2021-045
      Helps: #2319
      (cherry picked from commit 0736b7c1
      
      )
      [Backport to 2.58: Omit changes to ghash.c, will be a separate commit]
      [Backport to 2.58: Omit changes to giochannel.c, not needed in this branch]
      [Backport to 2.58: Omit changes to uri test, not needed in this branch]
      Signed-off-by: Simon McVittie's avatarSimon McVittie <smcv@collabora.com>
      0ace82d7
  2. 31 Oct, 2018 1 commit
  3. 30 Jul, 2018 1 commit
  4. 17 Jul, 2018 1 commit
  5. 15 Jun, 2018 1 commit
    • Philip Withnall's avatar
      gvariant: Change type of ‘y’ variants from guchar to guint8 · 09419fde
      Philip Withnall authored
      This fits better with the convention in the rest of GLib where arbitrary
      8-bit values are represented as guint8, avoiding the potential confusing
      of a name which references ‘char’s.
      
      This is not an API break, as both guint8 and guchar are unconditionally
      typedeffed to unsigned char.
      
      #896
      09419fde
  6. 12 Jan, 2018 1 commit
  7. 03 Dec, 2017 1 commit
  8. 06 Oct, 2017 1 commit
  9. 11 Jul, 2017 1 commit
  10. 29 May, 2017 1 commit
  11. 24 May, 2017 1 commit
    • Sébastien Wilmet's avatar
      glib/: LGPLv2+ -> LGPLv2.1+ · f9faac76
      Sébastien Wilmet authored
      All glib/*.{c,h} files have been processed, as well as gtester-report.
      
      12 of those files are not licensed under LGPL:
      
      	gbsearcharray.h
      	gconstructor.h
      	glibintl.h
      	gmirroringtable.h
      	gscripttable.h
      	gtranslit-data.h
      	gunibreak.h
      	gunichartables.h
      	gunicomp.h
      	gunidecomp.h
      	valgrind.h
      	win_iconv.c
      
      Some of them are generated files, some are licensed under a BSD-style
      license and win_iconv.c is in the public domain.
      
      Sub-directories inside glib/:
      
      	deprecated/: processed in a previous commit
      	glib-mirroring-tab/: already LGPLv2.1+
      	gnulib/: not modified, the code is copied from gnulib
      	libcharset/: a copy
      	pcre/: a copy
      	tests/: processed in a previous commit
      
      https://bugzilla.gnome.org/show_bug.cgi?id=776504
      f9faac76
  12. 27 Apr, 2017 1 commit
    • Krzesimir Nowak's avatar
      gvariant: Fix some typos in documentation · 75cd848e
      Krzesimir Nowak authored
      Reformatted the docs for G_VARIANT_TYPE_UINT64 to avoid having a
      number in the beginning of the line, because apparently gtk-doc treats
      that as a first element of the numbered list. The number being that
      big probably makes gtk-doc to treat it as 1.
      
      Fixed the g_variant_new_fixed_array documentation - it was partially
      copy-pasted from the g_variant_get_fixed_array documentation.
      
      The rest should be quite obvious.
      
      https://bugzilla.gnome.org/show_bug.cgi?id=781830
      75cd848e
  13. 04 Apr, 2017 1 commit
  14. 24 Jan, 2017 1 commit
  15. 27 Dec, 2016 1 commit
  16. 22 Nov, 2016 1 commit
  17. 20 Nov, 2016 1 commit
  18. 03 Aug, 2016 2 commits
  19. 21 Jul, 2016 1 commit
  20. 17 Jul, 2016 3 commits
  21. 11 May, 2016 1 commit
  22. 13 Apr, 2016 1 commit
  23. 12 Apr, 2016 1 commit
  24. 29 Sep, 2015 1 commit
  25. 19 Aug, 2015 1 commit
  26. 03 Mar, 2015 1 commit
  27. 19 Sep, 2014 1 commit
    • Simon McVittie's avatar
      GVariant: say that serialized form needs an out-of-band length · 7db1baf5
      Simon McVittie authored
      This confused me for a while, because it isn't the same as D-Bus.
      Like GVariant, the D-Bus serialization needs an out-of-band
      endianness and type indicator, but unlike GVariant, serialized
      D-Bus objects encapsulate their own length (often by starting with
      a byte-count). This does come at some redundancy cost, so I can see
      why the more efficient GVariant format does this the way it does;
      but it's a difference between D-Bus and GVariant that seems worth
      calling out.
      
      It's also relevant for the designers of file or message-framing
      formats: with D-Bus serialization it would be feasible to say "the file
      starts with a little-endian D-Bus variant, followed by...",
      but in GVariant you wouldn't be able to deserialize the variant
      unless you either assume that it extends to end-of-file, or have
      an explicit length.
      
      Bug: https://bugzilla.gnome.org/show_bug.cgi?id=736975
      Reviewed-by: Ryan Lortie
      7db1baf5
  28. 01 Jun, 2014 1 commit
  29. 05 Mar, 2014 1 commit
  30. 15 Feb, 2014 1 commit
    • Matthias Clasen's avatar
      docs: let go of &ast; · bc6ee788
      Matthias Clasen authored
      Since we are no longer using sgml mode, using /&ast; &ast;/ to
      escape block comments inside examples does not work anymore.
      Switch to using line comments with //
      bc6ee788
  31. 09 Feb, 2014 2 commits
    • Matthias Clasen's avatar
      Fix a misformatting in GVariant docs · c158a9cd
      Matthias Clasen authored
      The + at the beginning of the line was misinterpreted
      as markdown for a list.
      c158a9cd
    • Matthias Clasen's avatar
      Docs: Drop entities, switch away from sgml mode · 35066ed6
      Matthias Clasen authored
      Since all element markup is now gone from the doc comments,
      we can turn off the gtk-doc sgml mode, which means that from
      now on, docbook markup is no longer allowed in doc comments.
      
      To make this possible, we have to replace all remaining
      entities in doc comments by their replacement text, &amp; -> &
      and so on.
      35066ed6
  32. 08 Feb, 2014 4 commits
  33. 05 Feb, 2014 1 commit