GitLab repository storage has been migrated to hashed layout. Please contact Infrastructure team if you notice any issues with repositories or hooks.

Commit def1947e authored by Sebastian Wilhelmi's avatar Sebastian Wilhelmi Committed by Sebastian Wilhelmi

Do not use the thread libs, when searching for some functions, as this

1999-01-25  Sebastian Wilhelmi  <wilhelmi@ira.uka.de>

	* configure.in: Do not use the thread libs, when searching for
	some functions, as this might require glib to always be linked
	with the thread libs on some platforms.

	* gutils.c (g_get_any_init): Don't set errno to zero and use it
	only as the error code, if the function returned a value less
	0. It might happen, that the call succeeds, even though the errno
	is set during the call (i.e. it first looks for a passwd file,
	which is not found). Submitted by Michael Natterer
	<mitschel@cs.tu-berlin.de>. BTW: Sorry for all the mess with that
	`getpwuid_r' change, but it had to be done once.
parent c5fd4a3d
1999-01-25 Sebastian Wilhelmi <wilhelmi@ira.uka.de>
* configure.in: Do not use the thread libs, when searching for
some functions, as this might require glib to always be linked
with the thread libs on some platforms.
* gutils.c (g_get_any_init): Don't set errno to zero and use it
only as the error code, if the function returned a value less
0. It might happen, that the call succeeds, even though the errno
is set during the call (i.e. it first looks for a passwd file,
which is not found). Submitted by Michael Natterer
<mitschel@cs.tu-berlin.de>. BTW: Sorry for all the mess with that
`getpwuid_r' change, but it had to be done once.
Sun Jan 24 10:33:30 1999 Tim Janik <timj@gtk.org>
* gutils.c (g_get_any_init): reverted raja's changes, since they leaked
......
1999-01-25 Sebastian Wilhelmi <wilhelmi@ira.uka.de>
* configure.in: Do not use the thread libs, when searching for
some functions, as this might require glib to always be linked
with the thread libs on some platforms.
* gutils.c (g_get_any_init): Don't set errno to zero and use it
only as the error code, if the function returned a value less
0. It might happen, that the call succeeds, even though the errno
is set during the call (i.e. it first looks for a passwd file,
which is not found). Submitted by Michael Natterer
<mitschel@cs.tu-berlin.de>. BTW: Sorry for all the mess with that
`getpwuid_r' change, but it had to be done once.
Sun Jan 24 10:33:30 1999 Tim Janik <timj@gtk.org>
* gutils.c (g_get_any_init): reverted raja's changes, since they leaked
......
1999-01-25 Sebastian Wilhelmi <wilhelmi@ira.uka.de>
* configure.in: Do not use the thread libs, when searching for
some functions, as this might require glib to always be linked
with the thread libs on some platforms.
* gutils.c (g_get_any_init): Don't set errno to zero and use it
only as the error code, if the function returned a value less
0. It might happen, that the call succeeds, even though the errno
is set during the call (i.e. it first looks for a passwd file,
which is not found). Submitted by Michael Natterer
<mitschel@cs.tu-berlin.de>. BTW: Sorry for all the mess with that
`getpwuid_r' change, but it had to be done once.
Sun Jan 24 10:33:30 1999 Tim Janik <timj@gtk.org>
* gutils.c (g_get_any_init): reverted raja's changes, since they leaked
......
1999-01-25 Sebastian Wilhelmi <wilhelmi@ira.uka.de>
* configure.in: Do not use the thread libs, when searching for
some functions, as this might require glib to always be linked
with the thread libs on some platforms.
* gutils.c (g_get_any_init): Don't set errno to zero and use it
only as the error code, if the function returned a value less
0. It might happen, that the call succeeds, even though the errno
is set during the call (i.e. it first looks for a passwd file,
which is not found). Submitted by Michael Natterer
<mitschel@cs.tu-berlin.de>. BTW: Sorry for all the mess with that
`getpwuid_r' change, but it had to be done once.
Sun Jan 24 10:33:30 1999 Tim Janik <timj@gtk.org>
* gutils.c (g_get_any_init): reverted raja's changes, since they leaked
......
1999-01-25 Sebastian Wilhelmi <wilhelmi@ira.uka.de>
* configure.in: Do not use the thread libs, when searching for
some functions, as this might require glib to always be linked
with the thread libs on some platforms.
* gutils.c (g_get_any_init): Don't set errno to zero and use it
only as the error code, if the function returned a value less
0. It might happen, that the call succeeds, even though the errno
is set during the call (i.e. it first looks for a passwd file,
which is not found). Submitted by Michael Natterer
<mitschel@cs.tu-berlin.de>. BTW: Sorry for all the mess with that
`getpwuid_r' change, but it had to be done once.
Sun Jan 24 10:33:30 1999 Tim Janik <timj@gtk.org>
* gutils.c (g_get_any_init): reverted raja's changes, since they leaked
......
1999-01-25 Sebastian Wilhelmi <wilhelmi@ira.uka.de>
* configure.in: Do not use the thread libs, when searching for
some functions, as this might require glib to always be linked
with the thread libs on some platforms.
* gutils.c (g_get_any_init): Don't set errno to zero and use it
only as the error code, if the function returned a value less
0. It might happen, that the call succeeds, even though the errno
is set during the call (i.e. it first looks for a passwd file,
which is not found). Submitted by Michael Natterer
<mitschel@cs.tu-berlin.de>. BTW: Sorry for all the mess with that
`getpwuid_r' change, but it had to be done once.
Sun Jan 24 10:33:30 1999 Tim Janik <timj@gtk.org>
* gutils.c (g_get_any_init): reverted raja's changes, since they leaked
......
1999-01-25 Sebastian Wilhelmi <wilhelmi@ira.uka.de>
* configure.in: Do not use the thread libs, when searching for
some functions, as this might require glib to always be linked
with the thread libs on some platforms.
* gutils.c (g_get_any_init): Don't set errno to zero and use it
only as the error code, if the function returned a value less
0. It might happen, that the call succeeds, even though the errno
is set during the call (i.e. it first looks for a passwd file,
which is not found). Submitted by Michael Natterer
<mitschel@cs.tu-berlin.de>. BTW: Sorry for all the mess with that
`getpwuid_r' change, but it had to be done once.
Sun Jan 24 10:33:30 1999 Tim Janik <timj@gtk.org>
* gutils.c (g_get_any_init): reverted raja's changes, since they leaked
......
1999-01-25 Sebastian Wilhelmi <wilhelmi@ira.uka.de>
* configure.in: Do not use the thread libs, when searching for
some functions, as this might require glib to always be linked
with the thread libs on some platforms.
* gutils.c (g_get_any_init): Don't set errno to zero and use it
only as the error code, if the function returned a value less
0. It might happen, that the call succeeds, even though the errno
is set during the call (i.e. it first looks for a passwd file,
which is not found). Submitted by Michael Natterer
<mitschel@cs.tu-berlin.de>. BTW: Sorry for all the mess with that
`getpwuid_r' change, but it had to be done once.
Sun Jan 24 10:33:30 1999 Tim Janik <timj@gtk.org>
* gutils.c (g_get_any_init): reverted raja's changes, since they leaked
......
......@@ -690,7 +690,9 @@ dnl ***********************************
if test x"$have_threads" != xnone; then
glib_save_LIBS="$LIBS"
LIBS="$LIBS $G_THREAD_LIBS"
# we are not doing the following for now, as this might require glib
# to always be linked with the thread libs on some platforms.
# LIBS="$LIBS $G_THREAD_LIBS"
AC_CHECK_FUNCS(localtime_r rand_r)
if test "$ac_cv_header_pwd_h" = "yes"; then
AC_CHECK_FUNCS(getpwuid_r)
......
......@@ -451,10 +451,9 @@ g_get_any_init (void)
g_free (buffer);
buffer = g_malloc (bufsize);
errno = 0;
# ifdef HAVE_GETPWUID_R_POSIX
error = getpwuid_r (getuid (), &pwd, buffer, bufsize, &pw);
error = error < 1 ? errno : error;
error = error < 0 ? errno : error;
# else /* !HAVE_GETPWUID_R_POSIX */
pw = getpwuid_r (getuid (), &pwd, buffer, bufsize);
error = pw ? 0 : errno;
......
......@@ -451,10 +451,9 @@ g_get_any_init (void)
g_free (buffer);
buffer = g_malloc (bufsize);
errno = 0;
# ifdef HAVE_GETPWUID_R_POSIX
error = getpwuid_r (getuid (), &pwd, buffer, bufsize, &pw);
error = error < 1 ? errno : error;
error = error < 0 ? errno : error;
# else /* !HAVE_GETPWUID_R_POSIX */
pw = getpwuid_r (getuid (), &pwd, buffer, bufsize);
error = pw ? 0 : errno;
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment