Commit 63c5b62f authored by Philip Withnall's avatar Philip Withnall
Browse files

goption: Add a precondition to avoid GOptionEntry list overflow

If the calling code adds more option entries than `G_MAXSIZE` then
there’ll be an integer overflow. This seems vanishingly unlikely (given
that all callers use static option entry lists), but add a precondition

Signed-off-by: Philip Withnall's avatarPhilip Withnall <>

Fixes: #2197
parent bdcf193c
......@@ -2422,6 +2422,8 @@ g_option_group_add_entries (GOptionGroup *group,
for (n_entries = 0; entries[n_entries].long_name != NULL; n_entries++) ;
g_return_if_fail (n_entries <= G_MAXSIZE - group->n_entries);
group->entries = g_renew (GOptionEntry, group->entries, group->n_entries + n_entries);
/* group->entries could be NULL in the trivial case where we add no
Supports Markdown
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment