Skip to content
GitLab
  • Menu
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
  • G glib-networking
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 42
    • Issues 42
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 4
    • Merge requests 4
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages & Registries
    • Packages & Registries
    • Container Registry
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • GNOME
  • glib-networking
  • Merge requests
  • !193

openssl: remove manual check for certificate expiration

  • Review changes

  • Download
  • Email patches
  • Plain diff
Merged Michael Catanzaro requested to merge mcatanzaro/openssl-expiration into master Nov 24, 2021
  • Overview 4
  • Commits 1
  • Pipelines 3
  • Changes 3

We should rely on OpenSSL to do this for us instead. Doing it here is wrong because we wind up checking certificates that may not actually be used in the final certificate chain constructed by OpenSSL. We don't have any way to know which chain OpenSSL will build from the certificates that we pass to it, so there is no way to safely perform certificate validity checks at the glib-networking level.

Fixes #179 (closed)

Corresponding change for GTlsDatabaseGnutls: a2cc9b8e

Corresponding change for GTlsCertificateGnutls: e1a8d066

Documented by: glib@780af9cf

Assignee
Assign to
Reviewer
Request review from
Time tracking
Source branch: mcatanzaro/openssl-expiration