• Georges Basile Stavracas Neto's avatar
    profiler: Concat entry.label() and entry.dynamicString() · bf9e5da2
    Georges Basile Stavracas Neto authored
    In MozJS 60, only using entry.label() is not enough to give
    meaningful Sysprof entries, since it might be an empty string
    in various cases. This gives many empty entries in Sysprof,
    making the profiler not as useful.
    
    As per upstream MozJS, in version 60, the final string is a
    combination of entry.label() and entry.dynamicString(). In [1],
    however, the dynamic string is conditionally added depending
    on a privacy toggle - which is not really the case with GJS
    since enabling the profiler isn't possible without a large
    control over the software stack, and opting in.
    
    Thus, use entry.dynamicLabel() as an additional source of
    information when saving the profiling labels, with enough
    care to not allocate new strings while there.
    
    [1] https://hg.mozilla.org/releases/mozilla-esr60/rev/768e500ad190
    bf9e5da2
Name
Last commit
Last update
doc Loading commit data...
examples Loading commit data...
gi Loading commit data...
gjs Loading commit data...
installed-tests Loading commit data...
libgjs-private Loading commit data...
m4 Loading commit data...
modules Loading commit data...
test Loading commit data...
tools Loading commit data...
util Loading commit data...
win32 Loading commit data...
.clang-format Loading commit data...
.eslintignore Loading commit data...
.eslintrc.json Loading commit data...
.gitlab-ci.yml Loading commit data...
AUTHORS Loading commit data...
COPYING Loading commit data...
COPYING.LGPL Loading commit data...
CPPLINT.cfg Loading commit data...
ChangeLog Loading commit data...
Makefile-examples.am Loading commit data...
Makefile-insttest.am Loading commit data...
Makefile-modules.am Loading commit data...
Makefile-test.am Loading commit data...
Makefile.am Loading commit data...
NEWS Loading commit data...
README Loading commit data...
README.md Loading commit data...
autogen.sh Loading commit data...
configure.ac Loading commit data...
git.mk Loading commit data...
gjs-1.0.pc.in Loading commit data...
gjs-modules-srcs.mk Loading commit data...
gjs-srcs.mk Loading commit data...
gjs.doap Loading commit data...
verbump.py Loading commit data...