Skip to content

  • Projects
  • Groups
  • Snippets
  • Help
  • This project
    • Loading...
  • Sign in / Register
gjs
gjs
  • Overview
    • Overview
    • Details
    • Activity
    • Cycle Analytics
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
    • Charts
  • Issues 20
    • Issues 20
    • List
    • Board
    • Labels
    • Milestones
  • Merge Requests 2
    • Merge Requests 2
  • CI / CD
    • CI / CD
    • Pipelines
    • Jobs
    • Schedules
    • Charts
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Members
    • Members
  • Collapse sidebar
  • Activity
  • Graph
  • Charts
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
  • GNOME
  • gjsgjs
  • Merge Requests
  • !28

Merged
Opened Dec 06, 2017 by Marco Trevisan@3v1n0 
  • Report abuse
Report abuse

Show errors when accessing to deleted object

Using g_critical instead of throwing errors. Backporting PR !27 (merged) to gnome 3.26 branch.

Closes: #21 (closed)

Edited Dec 11, 2017 by Marco Trevisan
×

Check out, review, and merge locally

Step 1. Fetch and check out the branch for this merge request

git fetch https://gitlab.gnome.org/3v1n0/gjs.git gobject-ward-gnome-3-26
git checkout -b 3v1n0/gjs-gobject-ward-gnome-3-26 FETCH_HEAD

Step 2. Review the changes locally

Step 3. Merge the branch and fix any conflicts that come up

git checkout gnome-3-26
git merge --no-ff 3v1n0/gjs-gobject-ward-gnome-3-26

Step 4. Push the result of the merge to GitLab

git push origin gnome-3-26

Note that pushing to GitLab requires write access to this repository.

Tip: You can also checkout merge requests locally by following these guidelines.

  • Discussion 2
  • Commits 3
  • Changes 2
{{ resolvedDiscussionCount }}/{{ discussionCount }} {{ resolvedCountText }} resolved
  • Philip Chimento @ptomato commented Dec 07, 2017
    Master

    Same comments apply as in !27 (merged), but otherwise looks great.

    Same comments apply as in !27, but otherwise looks great.
  • Marco Trevisan @3v1n0

    added 4 commits

    • b65c7851 - 1 commit from branch GNOME:gnome-3-26
    • b8b80de2 - object: Only show critical errors on access to finalized objects
    • dfeeb0c1 - object: Show error when using proto functions (connect*, emit) on destroyed object
    • f6b3d279 - object: make clear in toString() proto method when the object is finalized

    Compare with previous version

    Dec 11, 2017

    added 4 commits

    • b65c7851 - 1 commit from branch GNOME:gnome-3-26
    • b8b80de2 - object: Only show critical errors on access to finalized objects
    • dfeeb0c1 - object: Show error when using proto functions (connect*, emit) on destroyed object
    • f6b3d279 - object: make clear in toString() proto method when the object is finalized

    Compare with previous version

    added 4 commits * b65c7851 - 1 commit from branch `GNOME:gnome-3-26` * b8b80de2 - object: Only show critical errors on access to finalized objects * dfeeb0c1 - object: Show error when using proto functions (connect*, emit) on destroyed object * f6b3d279 - object: make clear in toString() proto method when the object is finalized [Compare with previous version](https://gitlab.gnome.org/GNOME/gjs/merge_requests/28/diffs?diff_id=873&start_sha=c9ac9ed18e793b37eb95d9eb0b38c160463920bc)
    Toggle commit list
  • Marco Trevisan @3v1n0

    added 3 commits

    • c9f8d96a - object: Only show critical errors on access to finalized objects
    • 975a49db - object: Show error when using proto functions (connect*, emit) on destroyed object
    • 566ab0d9 - object: make clear in toString() proto method when the object is finalized

    Compare with previous version

    Dec 11, 2017

    added 3 commits

    • c9f8d96a - object: Only show critical errors on access to finalized objects
    • 975a49db - object: Show error when using proto functions (connect*, emit) on destroyed object
    • 566ab0d9 - object: make clear in toString() proto method when the object is finalized

    Compare with previous version

    added 3 commits * c9f8d96a - object: Only show critical errors on access to finalized objects * 975a49db - object: Show error when using proto functions (connect*, emit) on destroyed object * 566ab0d9 - object: make clear in toString() proto method when the object is finalized [Compare with previous version](https://gitlab.gnome.org/GNOME/gjs/merge_requests/28/diffs?diff_id=874&start_sha=f6b3d279ac906e5e92ee4a20cb3ab36e51667670)
    Toggle commit list
  • Marco Trevisan @3v1n0

    changed title from Throw errors when using proto functions on deleted object to Show errors when accessing to deleted object

    Dec 11, 2017

    changed title from Throw errors when using proto functions on deleted object to Show errors when accessing to deleted object

    changed title from **{-Throw errors when using proto functions on-} deleted object** to **{+Show errors when accessing to+} deleted object**
    Toggle commit list
  • Marco Trevisan @3v1n0

    changed the description

    Dec 11, 2017

    changed the description

    changed the description
    Toggle commit list
  • Philip Chimento @ptomato commented Dec 28, 2017
    Master

    @3v1n0 I'm going to commit "object: Only show critical errors on access to finalized objects" both to gnome-3-26 and master, in order to fix the existing problems. Would you mind rebasing this and !27 (merged)? I'll re-review it later.

    @3v1n0 I'm going to commit "object: Only show critical errors on access to finalized objects" both to gnome-3-26 and master, in order to fix the existing problems. Would you mind rebasing this and !27? I'll re-review it later.
  • Marco Trevisan @3v1n0

    added 7 commits

    • 566ab0d9...c3cdb7cb - 4 commits from branch GNOME:gnome-3-26
    • 776e479d - object: Show error when using proto functions (connect*, emit) on destroyed object
    • 54e1703e - object: make clear in toString() proto method when the object is finalized
    • 0b3d6bb4 - object: only reset keep-alive and disassociate if needed

    Compare with previous version

    Dec 28, 2017

    added 7 commits

    • 566ab0d9...c3cdb7cb - 4 commits from branch GNOME:gnome-3-26
    • 776e479d - object: Show error when using proto functions (connect*, emit) on destroyed object
    • 54e1703e - object: make clear in toString() proto method when the object is finalized
    • 0b3d6bb4 - object: only reset keep-alive and disassociate if needed

    Compare with previous version

    added 7 commits * 566ab0d9...c3cdb7cb - 4 commits from branch `GNOME:gnome-3-26` * 776e479d - object: Show error when using proto functions (connect*, emit) on destroyed object * 54e1703e - object: make clear in toString() proto method when the object is finalized * 0b3d6bb4 - object: only reset keep-alive and disassociate if needed [Compare with previous version](https://gitlab.gnome.org/GNOME/gjs/merge_requests/28/diffs?diff_id=1034&start_sha=566ab0d940532ec51b97567b1bc34a007d7968f2)
    Toggle commit list
  • Philip Chimento @ptomato

    mentioned in commit b3e00026

    Jan 06, 2018

    mentioned in commit b3e00026

    mentioned in commit b3e00026ec3109840beeef80e902a08beda134c0
    Toggle commit list
  • Philip Chimento @ptomato

    merged

    Jan 06, 2018

    merged

    merged
    Toggle commit list
  • Write
  • Preview
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or sign in to comment
Philip Chimento
Assignee
Philip Chimento @ptomato
Assign to
None
Milestone
None
Assign milestone
Time tracking
0
Labels
None
Assign labels
  • View labels
Reference: GNOME/gjs!28
×

Revert this merge request

Switch branch
Cancel
A new branch will be created in your fork and a new merge request will be started.
×

Cherry-pick this merge request

Switch branch
Cancel
A new branch will be created in your fork and a new merge request will be started.