Show errors when accessing to deleted object
Using g_critical instead of throwing errors.
Backporting PR !27 (merged) to gnome 3.26 branch.
Closes: #21 (closed)
{{ resolvedDiscussionCount }}/{{ discussionCount }} {{ resolvedCountText }} resolved
-
Master
Same comments apply as in !27 (merged), but otherwise looks great.
-
added 4 commits
-
b65c7851 - 1 commit from branch
GNOME:gnome-3-26 - b8b80de2 - object: Only show critical errors on access to finalized objects
- dfeeb0c1 - object: Show error when using proto functions (connect*, emit) on destroyed object
- f6b3d279 - object: make clear in toString() proto method when the object is finalized
Toggle commit list -
b65c7851 - 1 commit from branch
-
changed title from Throw errors when using proto functions on deleted object to Show errors when accessing to deleted object
Toggle commit list -
changed the description
Toggle commit list -
Master
@3v1n0 I'm going to commit "object: Only show critical errors on access to finalized objects" both to gnome-3-26 and master, in order to fix the existing problems. Would you mind rebasing this and !27 (merged)? I'll re-review it later.
-
added 7 commits
-
566ab0d9...c3cdb7cb - 4 commits from branch
GNOME:gnome-3-26 - 776e479d - object: Show error when using proto functions (connect*, emit) on destroyed object
- 54e1703e - object: make clear in toString() proto method when the object is finalized
- 0b3d6bb4 - object: only reset keep-alive and disassociate if needed
Toggle commit list -
566ab0d9...c3cdb7cb - 4 commits from branch
-
merged
Toggle commit list
Please
register
or
sign in
to comment