Show errors when using proto functions on deleted object
In PR !22 (merged) I forgot to protect from accessing to invalid objects from proto functions.
Also mentioning if an object is finalized in the toString() function.
-
-
-
-
-
Master
Nice, thanks!
-
added 4 commits
Toggle commit list -
resolved all discussions
Toggle commit list -
Master
👍 Would you mind squashing the trailing spaces commit into the commit that originally introduced the whitespace change?Other than that I agree with it, but it would be best to get #21 (closed) fixed before merging this.
-
Developer
Would you mind squashing the trailing spaces commit into the commit that originally introduced the whitespace change?
Sorry, i'm not sure I got it... The whitespace change was introduced in commit 58cb9cd2, with what commit should I squash it?
Other than that I agree with it, but it would be best to get #21 (closed) fixed before merging this.
Ack, let me prepare a PR.
-
Master
Would you mind squashing the trailing spaces commit into the commit that originally introduced the whitespace change?
Sorry, i'm not sure I got it... The whitespace change was introduced in commit 58cb9cd2, with what commit should I squash it?
Looks like it's been resolved in a rebase anyway.
-
resolved all discussions
Toggle commit list -
added 18 commits
-
9236f56e...617257d3 - 4 commits from branch
GNOME:master - 718ca0bc - CI: add code coverage test
- 5b340f2f - CI: add code coverage test
- 5cdc826a - One more test
- 9914af79 - Amend gtk-application.js
- 40e023ca - mv gtk-window.js to amend gtk.js, including suggestions
- 7efb9ff8 - arg: String as GdkAtom, and GdkAtom as string
- 19505e5d - CI: do not exit abruptly if files are different
- 8c8f8a4a - CI: add the coverage badge
- b7817e54 - CI: tweak the docker image
- 0768e54f - object: Only show critical errors on access to finalized objects
-
faefa0b9 - Test case improved in
installed-tests/js/testCairo.js[fixes #27 (closed)] - e537eb06 - object: Throw error when using proto functions (connect*, emit) on destroyed object
- e3db3a1b - object: make clear in toString() proto method when the object is finalized
- 3d6084a4 - proxyutils: remove trailing spaces
Toggle commit list -
9236f56e...617257d3 - 4 commits from branch
-
resolved all discussions
Toggle commit list -
added 19 commits
-
3d6084a4...e2986711 - 16 commits from branch
GNOME:master - 3b95ff5a - object: Throw error when using proto functions (connect*, emit) on destroyed object
- 984fcae4 - object: make clear in toString() proto method when the object is finalized
- f85278bb - proxyutils: remove trailing spaces
Toggle commit list -
3d6084a4...e2986711 - 16 commits from branch
-
Developer
Ok, rebased... I'm confident that in this case keeping the throw is fine, as such operations are easier to track, don't you agree?
-
resolved all discussions
Toggle commit list -
added 6 commits
-
f85278bb...9339f85d - 3 commits from branch
GNOME:master - 8a7566a8 - object: Show error when using proto functions (connect*, emit) on destroyed object
- 311f03ac - object: make clear in toString() proto method when the object is finalized
- ac08b9f9 - proxyutils: remove trailing spaces
Toggle commit list -
f85278bb...9339f85d - 3 commits from branch
-
changed title from Throw errors when using proto functions on deleted object to Show errors when using proto functions on deleted object
Toggle commit list -
changed the description
Toggle commit list -
resolved all discussions
Toggle commit list -
added 16 commits
- 1555e2fa - CI: add code coverage test
- 3a716844 - CI: add code coverage test
- 99d49ce3 - One more test
- 25a1b215 - Amend gtk-application.js
- 1fc1e41d - mv gtk-window.js to amend gtk.js, including suggestions
- b60bb79c - arg: String as GdkAtom, and GdkAtom as string
- 7bf1dd7d - CI: do not exit abruptly if files are different
- 592940cb - CI: add the coverage badge
- 7dbe567e - CI: tweak the docker image
- 0eeb15a3 - object: Only show critical errors on access to finalized objects
-
f42b16ad - Test case improved in
installed-tests/js/testCairo.js[fixes #27 (closed)] - 7c5c7768 - coverage: Remove unused JSCompartmentOptions
- d5cc88d4 - js: Remove unnecessary property getters and setters
- 40e38302 - object: Show error when using proto functions (connect*, emit) on destroyed object
- 00df5b74 - object: make clear in toString() proto method when the object is finalized
- 0d7816a2 - proxyutils: remove trailing spaces
Toggle commit list -
resolved all discussions
Toggle commit list -
added 22 commits
-
0d7816a2...9339f85d - 19 commits from branch
GNOME:master - 8a7566a8 - object: Show error when using proto functions (connect*, emit) on destroyed object
- 29cd1f2e - object: make clear in toString() proto method when the object is finalized
- e49dbaba - proxyutils: remove trailing spaces
Toggle commit list -
0d7816a2...9339f85d - 19 commits from branch
-
merged
Toggle commit list -
Master
Thanks!