Skip to content

Fix Visual Studio builds of master branch

Chun-wei Fan requested to merge msvc.partial.fix into master

Hi,

This attempts to fix Visual Studio builds of the master branch partially (i.e. before we come to a fix for issue #368 (closed)), by:

  • Applying MR !482 (merged) to the modules/cairo-*.cpp sources, as things started to apply there as well.
  • Mention in README.MSVC.md that Visual Studio 2019 is now required for Visual Studio builds.

Before #368 (closed) is fixed, it is possible to build GJS master on Visual Studio 2019 under permissive mode (/permissive instead of the default /permissive- compiler flag), but I think it is best if we can get that addressed, so I would rather not set that compiler flag upstream if possible.

Fixes issue #368 (closed).

With blessings, thank you!

Edited by Chun-wei Fan

Merge request reports