Skip to content

GitLab

  • Projects
  • Groups
  • Snippets
  • Help
    • Loading...
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in
gjs
gjs
  • Project overview
    • Project overview
    • Details
    • Activity
    • Releases
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 101
    • Issues 101
    • List
    • Boards
    • Labels
    • Service Desk
    • Milestones
  • Merge Requests 17
    • Merge Requests 17
  • CI / CD
    • CI / CD
    • Pipelines
    • Jobs
    • Schedules
  • Operations
    • Operations
    • Incidents
    • Environments
  • Packages & Registries
    • Packages & Registries
    • Container Registry
  • Analytics
    • Analytics
    • CI / CD
    • Repository
    • Value Stream
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Members
    • Members
  • Collapse sidebar
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
  • GNOME
  • gjsgjs
  • Merge Requests
  • !154

Merged
Opened Jun 02, 2018 by Philip Chimento@ptomato🚮Maintainer

Resolve "Possible refcounting bug around GtkListbox signal handlers"

  • Overview 1
  • Commits 1
  • Pipelines 1
  • Changes 1

We want to remove this warning in cases where the subsequent code isn't actually trying to access the underlying GObject and therefore isn't going to crash. On resolve() we don't want the warning, as that only applies to prototype objects. On trace() we don't want it either, as that may legitimately be called during the GC mark phase on a JS wrapper with a disposed GObject.

In the typecheck function, we only use the GObject for a debug assertion. All the other checks use the GType. We relax the assertion and only do the debug sanity check if the GObject is still alive. Instead of logging the warning here, we log the warning in gjs_g_object_from_object() which happens later when the GObject is actually used.

We keep the warnings in property getters and setters, since those would access the underlying GObject, and they are now only called for names that really do resolve to GObject properties and fields.

Closes: #24 (closed)

Assignee
Assign to
Reviewer
Request review from
GNOME 3.28 bugfixes
Milestone
GNOME 3.28 bugfixes (Past due)
Assign milestone
Time tracking
Reference: GNOME/gjs!154
Source branch: 24-tighten-finalized-warnings

Revert this merge request

This will create a new commit in order to revert the existing changes.

Switch branch
Cancel
A new branch will be created in your fork and a new merge request will be started.

Cherry-pick this merge request

Switch branch
Cancel
A new branch will be created in your fork and a new merge request will be started.