Skip to content
GitLab
  • Menu
Projects Groups Snippets
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
  • gjs gjs
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 104
    • Issues 104
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 26
    • Merge requests 26
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages & Registries
    • Packages & Registries
    • Container Registry
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • GNOME
  • gjsgjs
  • Issues
  • #176
Closed
Open
Created Jul 02, 2018 by Philip Chimento@ptomato🚮Maintainer

See if it's possible to replace context destroy notifications

GjsMaybeOwned (in jsapi-util-root.h) takes a lot of space to store a callback pointer and data pointer which are used when the GjsContext is destroyed. These pointers are either all null (for the GjsMaybeOwned instances used in object.cpp) or some null, some the same (for the instances used in closure.cpp.) It should be possible to eliminate these fields while still calling the same callback on closures stored in a GjsMaybeOwned where necessary.

In order to do this, it might just be necessary to stop using GjsMaybeOwned for both objects and closures, and instead use a more specialized struct for each one.

Assignee
Assign to
Time tracking