- 05 Jul, 2020 5 commits
-
-
Marco Trevisan authored
Ensure that native boolean type is saved as we expect to be in gboolean world.
-
Marco Trevisan authored
-
Marco Trevisan authored
-
Marco Trevisan authored
Instead of manually picking the GIArgument union value, make possible to select the right one using a template type, so that we can avoid repeating the same code multiple times in the various template functions. As per this, utilize to avoid repetition in arg template functions
-
Philip Chimento authored
See merge request !444
-
- 04 Jul, 2020 1 commit
-
-
Evan Welsh authored
-
- 27 Jun, 2020 1 commit
-
-
Philip Chimento authored
See merge request !454
-
- 26 Jun, 2020 1 commit
-
-
verdre authored
Getting the function name for logging a warning/error message using format_function_name() is expensive and shows up with quite a few percent in the profiler. Luckily, we can completely get rid of that overhead by only getting the function name in case we actually have to warn. To do that, check the number of arguments ourselves instead of using args.requireAtLeast() and then move the call to format_function_name() into the if-conditions of those checks.
-
- 23 Jun, 2020 2 commits
-
-
Philip Chimento authored
Update ESLint CI image. See merge request !451
-
Evan Welsh authored
- In ESLint v6, dangling commas on functions are now linted.
-
- 22 Jun, 2020 1 commit
-
-
Philip Chimento authored
See merge request !452
-
- 21 Jun, 2020 1 commit
-
-
Andy Holmes authored
Add a simple implementation of GListModel, primarily as a demonstration of implementing interfaces in genera, but particularly this interface as it will be used quite a bit in Gtk4.
-
- 16 Jun, 2020 1 commit
-
-
Evan Welsh authored
-
- 04 Jun, 2020 1 commit
-
-
Philip Chimento authored
See merge request !445
-
- 03 Jun, 2020 10 commits
-
-
Philip Chimento authored
Add include-what-you-use CI job See merge request !449
-
Philip Chimento authored
These are caught by the newest version of IWYU.
-
Philip Chimento authored
This adds an 'iwyu' job that runs only on the changed files, hopefully quickly, when pushing a branch or creating a merge request. There is also an 'iwyu-full' job that runs on all files, and takes 5 to 10 minutes, so is only run when manually triggered.
-
Philip Chimento authored
When this was mainly being run manually, the exit code didn't matter much since the main thing was to look at the output. Running in CI, it does matter, so make sure it is correct everywhere.
-
Philip Chimento authored
Very obscure, but it seems that git-diff-index can think that every file in the index has been modified due to their mtime, even if their contents are the same. This seems to happen on CI, so refresh the index (using git's "convenient" --really-refresh switch).
-
Philip Chimento authored
iwyu_tool.py has /usr/bin/env python, which is not what we want on python3-only systems.
-
Philip Chimento authored
There's no need to build the whole project, as we are only analyzing the source code. We just need to run 'meson setup' on the builddir so that we have the compilation database. Also print the list of affected files after running Meson so they don't scroll out of sight.
-
Philip Chimento authored
CI: Add include-what-you-use to the debug CI image See merge request !448
-
Philip Chimento authored
This splits out a separate Dockerfile for the debug-enabled CI image, and builds include-what-you-use on it as well. We'll use this for some more automated code review.
-
Evan Welsh authored
-
- 01 Jun, 2020 5 commits
-
-
Philip Chimento authored
Fix CI failure caused by GTK4 update See merge request !447
-
Philip Chimento authored
We are committing an update that requires a newer version of GTK4, so pin the known-good image to the most recent one.
-
Philip Chimento authored
The monthly CI image build included a newer version of GTK4 which had some API changes. The one we need to contend with is the removal of gtk_container_add() in favour of widget-specific functions such as gtk_window_set_child(). The destroy vfunc was also removed so it seems that one avenue to get a JS callback called during garbage collection no longer exists in GTK4, so we can remove that test.
-
Philip Chimento authored
arg.cpp: Add required messages for static_assert (fix building on pre-C++17) See merge request !441
-
Chun-wei Fan authored
Using static_assert without a diagnostic message is a feature that is introduced with C++17, so add the messages as needed as we are on C++14. This also reverts commit 698d603c, as we no longer need to force C++17 mode on Visual Studio as a result
-
- 31 May, 2020 11 commits
-
-
Philip Chimento authored
-
Philip Chimento authored
-
Philip Chimento authored
Globals See merge request !440
-
Evan Welsh authored
This is how SpiderMonkey does it. We can probably assume in GJS as well, that the context will have entered a realm whenever this is called.
-
Evan Welsh authored
-
Philip Chimento authored
This makes the code cleaner and takes care of memory management. We propagate this API change back to all callers as far as possible, as well. (gjs_context_define_string_array() is a public C API, so its signature can't be changed; and GjsContextPrivate::m_search_path must be a POD type because the GObject property setter sets that memory location before the GjsContextPrivate constructor runs. Co-authored-by:
Evan Welsh <noreply@evanwelsh.com>
-
Evan Welsh authored
-
Philip Chimento authored
Simplify private pointers See merge request !434
-
Philip Chimento authored
Improvements to IWYU script See merge request !435
-
Philip Chimento authored
Separate closures and vfuncs See merge request !438
-
Philip Chimento authored
arg.cpp: Fix building on Visual Studio See merge request !439
-