Commit 1cdb06c7 authored by Philip Chimento's avatar Philip Chimento 🚮

Merge branch 'gbsneto/weak-ref-warning' into 'master'

object: Only weak unref if GObject is still alive

See merge request !127
parents bf0afbd6 8d50e2b4
Pipeline #9282 passed with stages
in 39 minutes and 58 seconds
......@@ -1360,7 +1360,8 @@ disassociate_js_gobject(GObject *gobj)
ObjectInstance *priv = get_object_qdata(gobj);
bool had_toggle_down, had_toggle_up;
g_object_weak_unref(priv->gobj, wrapped_gobj_dispose_notify, priv);
if (!priv->g_object_finalized)
g_object_weak_unref(gobj, wrapped_gobj_dispose_notify, priv);
/* FIXME: this check fails when JS code runs after the main loop ends,
* because the idle functions are not dispatched without a main loop.
Markdown is supported
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment