INSTALL file generated from installed dependency versions and not in dist
In the root
meson.build, all dependencies minimum versions are hardcoded instead of using top-declared variables (i.e. easy to maintain). As a consequence, later when we generate the
INSTALL file, it is done this way:
[…] install_conf.set('PANGOCAIRO_REQUIRED_VERSION', pangocairo .version()) install_conf.set('POPPLER_DATA_REQUIRED_VERSION', poppler .version()) […]
This is wrong as it replaces (from what I could see) with actually discovered versions on the build system, not with our minimum requirement. This has to be fixed. We should have a top section with just a list of variables, something like:
pangocairo_required_version=1.2.3 poppler_required_version=1.2.3 [… and other dep listing …] [… then below …] pangocairo = dependency('pangocairo', version: '>=pangocairo_required_version') [… then again below …] install_conf.set('PANGOCAIRO_REQUIRED_VERSION', pangocairo_required_version)
Basically use variables. This should be done for the whole dependency list, otherwise this is not maintainable. @Salamandar? Anyone?