1. 24 Jun, 2018 13 commits
  2. 23 Jun, 2018 13 commits
    • Jehan's avatar
      icons: work around dimension bug of librsvg for a bunch of color icons. · be3abe6c
      Jehan authored
      It feels I am just fighting against the system. So annoying!
      
      (cherry picked from commit b87d34ba)
      be3abe6c
    • Jehan's avatar
      icons: complete color-scalable SVG. · 87d2dbbe
      Jehan authored
      Preparing extracting icons from a single file.
      
      (cherry picked from commit 199df5a1)
      87d2dbbe
    • Jehan's avatar
      tools: post-process SVG objects with "color-important" label. · 520c3489
      Jehan authored
      This will allow a designer to simply "tag" an object so that its color
      does not get overrided by GTK+ without needing to edit the file as text.
      
      (cherry picked from commit 8a36b786)
      520c3489
    • Jehan's avatar
      Issue #1708: g_free() called instead of gdk_device_free_history(). · 98848a46
      Jehan authored
      As spotted by Massimo!
      
      (cherry picked from commit 5e25cdc7)
      98848a46
    • Jehan's avatar
      icons: update various icons to account for librsvg bugs. · 402c0d98
      Jehan authored
      It should now be possible to fully export our symbolic icons from a
      single central file.
      My long-standing bug of librsvg#250 is still opened and unfixed, but it
      turns out most issues I encountered are anyway also problems when
      recoloring symbolic icons in GTK+ (like using strokes instead of
      fills!). So let's just bypass all problems at once by accounting for
      these issues in the design.
      
      (cherry picked from commit 4c68d5df)
      402c0d98
    • Jehan's avatar
      icons: fix many icons for proper recoloring. · 9bc78a3b
      Jehan authored
      I tried to fix all the icons I could see which had issues regarding all
      recoloring matters (using fill not stroke, change circle/ellipses to
      paths, etc.) when looking at a blank canvas.
      I'm sure I still miss a lot but that will do for now.
      
      (cherry picked from commit 8811b0d9)
      9bc78a3b
    • Jehan's avatar
      icons: force colors on some icons. · e960c488
      Jehan authored
      Sometimes even within symbolic icons, parts of the design must keep
      fixed colors, when they are semantic. For instance this is the case for
      the color-picker-(black|gray|white) icons or the gimp-default-colors.
      
      The trick used by GTK+ to recolor is by supplying an additional CSS
      style to icons which overrides inline CSS thanks to "! important"
      keyword. Our own trick to circumvent this trick is to set "!important"
      in inline CSS when one wishes not to have it overrided by the general
      colors.
      Right now I am doing the edit by hand with vim because Inkscape doesn't
      seem to validate this keyword if I add it manually in its XML editor. So
      what I did is add the "color-important" label on such object, and I will
      later modify my SVG export tool to add !important on such object "fill"
      values at export time.
      
      (cherry picked from commit 5d5bbeb8)
      e960c488
    • Jehan's avatar
      icons: fix various symbolic icons not properly recolored. · fa6f2f65
      Jehan authored
      The current recolorization code only recolors paths and rectangles. In
      particular it leaves circles and ellipses as-is.
      I opened the merge request gtk!214 for this issue. But in the meantime,
      it is quite easy to change circles and ellipses into path with "object
      to path" in Inkscape.
      
      A second problem is that it only recolors fills, not strokes, as
      previously stated. So I need to remove strokes from icons, or transform
      them to paths.
      
      (cherry picked from commit fd460182)
      fa6f2f65
    • Jehan's avatar
      icons: larger spacing between broken chains. · eb821610
      Jehan authored
      It seems not wide enough to differentiate easily the broken and
      non-broken chains. So let's make this gap bigger.
      
      (cherry picked from commit a5afb045)
      eb821610
    • Jehan's avatar
      icons: fixing more icons. · 99e6b365
      Jehan authored
      This time, 2 icons still had problems because of visible rectangles.
      Fixing "gimp-prefs-folders" and "gimp-prefs-folders-mypaint-brushes".
      
      (cherry picked from commit 2bb8afd1)
      99e6b365
    • Jehan's avatar
      icons: fix various icons broken when recoloring with CSS. · 11dd2365
      Jehan authored
      For anyone wishing to help me fix icons, here is the trick: apparently
      GTK+ would fill the paths with CSS colors, not stroke them. So when we
      have icon drawing based on path-stroking, they don't end up as expected.
      In Inkscape, just run "Stroke to Path" to transform a stroke design in a
      fill design.
      I am fixing "gimp-tool-cage", "document-revert", "gimp-image-reload",
      "gimp-reset" and "view-refresh". More to follow as we discover them, I
      guess.
      
      (cherry picked from commit 4b6869dd)
      11dd2365
    • Jehan's avatar
      icons: make gimp-tool-ellipse-select symmetric. · 709e5e4c
      Jehan authored
      I may not be an icon designer, but this icon be so clearly asymmetric
      always deeply annoyed me.
      
      (cherry picked from commit 45f46db8)
      709e5e4c
    • Michael Natterer's avatar
      Issue #1706 - Typo in gimpgradientselect.h include guard · 8aa0d5a4
      Michael Natterer authored
      Fix typo, spotted by Massimo.
      
      (cherry picked from commit 627d58dc)
      8aa0d5a4
  3. 22 Jun, 2018 7 commits
  4. 21 Jun, 2018 7 commits