1. 03 Dec, 2018 2 commits
  2. 02 Dec, 2018 1 commit
  3. 28 Nov, 2018 1 commit
  4. 27 Nov, 2018 1 commit
    • Jehan's avatar
      plug-ins: make various usage of g_file_replace() safer. · 66ec4672
      Jehan authored
      As I did on app/, finalizing an output stream also implicitly flushes
      and closes it. Hence if an export ended with an error, we'd end up with
      incomplete data file (possibly overwriting a previously exported image).
      Only 2 plug-ins I haven't fixed yet are file-tiff-io and file-gif-save.
      The later one don't even clean up its memory (which somehow is good here
      as at least the output stream is never finalized hence sane files are
      not overwritten in case of errors). As for the former (TIFF plug-in), it
      doesn't even seem to have any error control AFAICS, apart from printing
      error messages on standard error output.
      66ec4672
  5. 24 Nov, 2018 1 commit
  6. 14 Nov, 2018 2 commits
    • Jehan's avatar
      Issue #2501: Confusing wording in "Export Image as PDF" dialog. · afe1de95
      Jehan authored
      Nothing said what was going to be the order of the page, except by
      testing. Now there will be an explicit text, which will be automatically
      updated when checking the "reverse order" box.
      afe1de95
    • Alexandre Prokoudine's avatar
      Help menu: various updates · 85e6700a
      Alexandre Prokoudine authored
      Commented out the inactive plug-ins registry: no point linking to a dead page.
      
      Added links to the roadmap page, main wiki page, and the bug tracker. Placed
      the link to the bug tracker one level up from '<Image>/Help/GIMP Online'
      to make it more visible.
      85e6700a
  7. 08 Nov, 2018 1 commit
    • Jehan's avatar
      Issue #2431: After coloring a selection and exporting to PDF, file... · ba98b98f
      Jehan authored
      ... only shows the color (and nothing else) when "Convert bitmaps to
      vector graphics where possible" was set.
      
      This is because gimp_drawable_histogram() only checks selected pixels.
      So let's make sure we work on a duplicate of the image so that we can
      safely remove the selection before processing the export.
      
      (cherry picked from commit 679e3412)
      ba98b98f
  8. 01 Nov, 2018 1 commit
    • Jehan's avatar
      Issue #2160: Exporting to PCX results in a warped file. · 5d319b77
      Jehan authored
      Add line data padding when necessary.
      Additionally I realize we should convert to little-endian after checking
      the bytesperline oddness (this bug was most likely unnoticed until now
      as most desktop proc are little endian now anyway).
      5d319b77
  9. 30 Oct, 2018 1 commit
  10. 22 Oct, 2018 5 commits
  11. 20 Oct, 2018 3 commits
  12. 19 Oct, 2018 3 commits
  13. 09 Oct, 2018 1 commit
  14. 01 Oct, 2018 1 commit
  15. 29 Sep, 2018 7 commits
  16. 26 Sep, 2018 1 commit
    • Ell's avatar
      plug-ins: in script-fu, don't query PDB procedures' info on startup · 9a2999a5
      Ell authored
      script-fu used to query the information of every PDB procedure on
      startup, in order to get the number of parameters for each
      procedure.  This was done so that nullary procedures were defined
      in such a way as to accept (and ignore) any number of arguments
      (and at least one of the scripts we ship relies on this behavior).
      However, this requires expensive back-and-forth communication with
      the main GIMP process, which notable slowed down script-fu's
      startup, and had a non-negligible impact on GIMP's startup time.
      
      Instead, avoid querying procedure information, and implement the
      special behavior for nullary procedures at call time.  We do this
      by defining, in addition to the "strict" gimp-proc-db-call
      procedure, a "permissive" -gimp-proc-db-call internal procedure,
      and using the latter to call the predefined PDB procedures.
      9a2999a5
  17. 19 Sep, 2018 1 commit
  18. 16 Sep, 2018 3 commits
    • luz.paz's avatar
      Misc. typo fixes · 38658773
      luz.paz authored
      Found via `codespell`
      38658773
    • Jehan's avatar
      plug-ins: add the "msf1" brand for HEIF files. · 64b00b5c
      Jehan authored
      After Dirk Farin had another look in the specs, it turns out that "mif1"
      is actually allowed as major brand for HEIF. Also adding "msf1" which is
      the equivalent for image sequences.
      64b00b5c
    • Jehan's avatar
      Issue #2209: more accurate magic for HEIF files. · 4ad3993e
      Jehan authored
      Just looking for "ftyp" would also match other ISOBMFF files (.mov or
      .mp4 files for instance). These are the possible 4-byte "brand" code
      which can follow "ftyp", as listed by Dirk Farin from libheif.
      
      I add the "mif1" brand, as I encountered some files using this magic
      (even though this should normally not be valid apparently, yet the file
      loaded fine in GIMP).
      
      This is not perfect as the standard allows potentially very big box
      headers, in which case 8 bytes (the "largesize" slot) may be inserted
      between "ftyp" and the brand, as I understand it. But this is actually
      unlikely enough to probably never happen (the compatible brands list
      would have to be huuuge, as it looks like this is the only extendable
      part in a ftyp box). So let's assume this just never happens.
      
      See also: https://github.com/strukturag/libheif/issues/83
      4ad3993e
  19. 14 Sep, 2018 1 commit
    • Jehan's avatar
      Issue #2209: HEIF: Invalid input: No 'ftyp' box. · d738d2f6
      Jehan authored
      Adding a magic number for HEIC/HEIF, which would allow to discard
      obvious non-HEIC images even with the wrong extension.
      
      Note: it looks like this magic number would also match more generically
      other ISO base media file format (ISOBMFF) formats, like .mov or .mp4
      files. I am enquiring for better magic but for now, this is better than
      nothing.
      d738d2f6
  20. 11 Sep, 2018 3 commits