1. 05 Aug, 2018 3 commits
  2. 04 Aug, 2018 5 commits
    • Jehan's avatar
      Issue #1974: Memory leak in gimpimage.c. · 2912fe7c
      Jehan authored
      Ok my previous fix was wrong (at least for the part in the macro). This
      is a macro, not a function. So each time we write _reason, the call to
      g_strdup_printf() is reevaluated, hence data is allocated.
      The right fix is to prepend `tmp` to the list, not `_reason`.
      Thanks to Massimo for the debugging, as always!
      2912fe7c
    • Jehan's avatar
      Issue #1974: Memory leak in gimpimage.c. · 0ab682b0
      Jehan authored
      ADD_REASON macro was leaking the allocated string when version_reason
      return value was NULL (i.e. when we didn't care about the version
      reasons).
      
      Also we were not properly freeing all the reason strings at the end,
      only the list. Use g_list_free_full() instead of g_list_free().
      0ab682b0
    • Ell's avatar
      Issue #1846 - "gitlab::" typo in the Windows installer · aafa9259
      Ell authored
      Introduced by commit 8eb77376.
      Change to "gitlab:".
      aafa9259
    • Ell's avatar
      app: short-circuit GimpProjection bounds-changed handler if disjoint · c6b8a421
      Ell authored
      In gimp_projection_projectable_bounds_changed(), bail early by
      calling gimp_projection_projectable_structure_changed() instead, if
      the new bounds don't intersect the old bounds.
      c6b8a421
    • Ell's avatar
      app: fix gimp_projection_projectable_bounds_changed() · bb5e3fd9
      Ell authored
      In gimp_projection_projectable_bounds_changed(), which is called by
      GimpProjection in response to a GimpProjectable::bounds-changed
      signal, invalidate all regions of the new projection that weren't
      copied from the old projection, so that they get rendered upon
      flushing, instead of remaining empty.
      
      Additionally, fix preview invalidation -- in particular, don't
      directly invalidate the projectable's preview, even if preview
      invalidation is already queued and chunk rendering was finished by
      the boundary change, and instead always queue a preview
      invalidation.
      bb5e3fd9
  3. 03 Aug, 2018 15 commits
    • Ell's avatar
      app: avoid re-rendering group layers upon resizing · bd726c96
      Ell authored
      Make sure we don't unnecessarily update the group layer's drawable
      while flusing the group's projection during resizing, since we want
      to either update the entire drawable, or avoid any updates, when
      replacing the drawable's buffer.  Note that explicitly supressing
      updates in this case should theoretically not be necessary, but the
      fact that the call to gimp_projectable_bounds_changed() can result
      in reconstructing the projection (see the FIXME comment in that
      function) makes it necessary in some cases nonetheless.
      bd726c96
    • Ell's avatar
      app: avoid re-rendering group layers upon translation · 3ff820a0
      Ell authored
      When translating group layers, there's no need to re-render the
      group's projection -- we can simply update the group's offset (and
      offset node) directly, and redirect any layer-stack "update"
      signals to the group's drawable.  This significantly improves
      performance when moving groups.
      3ff820a0
    • Ell's avatar
      app: use gimp_projectable_bounds_changed() when resizing group layers · 1bb3e962
      Ell authored
      In GimpGroupLayer, use gimp_projectable_bounds_changed() when
      updating the group layer's size, instead of reconstructing the
      projection, unless reallocation of the projection has been
      requested.  This is more efficient, since it simply copies the
      content of the projection's old buffer to the new buffer, rather
      than re-rendering the graph.
      1bb3e962
    • Ell's avatar
      app: stop idle projection rendering when flushing group layers · a4957c7c
      Ell authored
      In gimp_group_layer_flush(), stop any idle rendering, initiated
      when a new buffer is allocated, before flushing the group's
      pickable.  Otherwise, the idle rendering is finished synchronously,
      which unnecessarily introduces a noticeable lag.
      a4957c7c
    • Ell's avatar
      app: add "update" parameter to gimp_drawable_set_buffer_full() · 26a8d141
      Ell authored
      ... which specifies whether or not to update the drawable in
      response to the buffer change.
      
      Pass TRUE for "update" at all existing call sites, to keep the
      current behavior.
      26a8d141
    • Ell's avatar
      app: respond to GimpProjectable::bounds-changed in GimpProjection · fbeae361
      Ell authored
      In GimpProjection, respond to the projectable's "bounds-changed"
      signal, by reallocating the buffer, and copying the corresponding
      region of the old buffer (using
      gimp_tile_handler_validate_buffer_copy(), added a few commits back,
      so that the relevant portion of the validate handler's dirty region
      is also copied).  Additionally, shift and clip all outstanding
      update regions as necessary (actually, we avoid copying the buffer
      when a shift is necessary, and simply reconstruct the projection;
      see FIXME comment in the code.)
      fbeae361
    • Ell's avatar
      app: add GimpProjectable::bounds-changed signal · 460c3d13
      Ell authored
      ... and a corresponding gimp_projectable_bounds_changed() function.
      
      This signal can be emitted by implementers of GimpProjectable,
      instead of the GimpProjectable::structure-changed signal, when the
      projectable's bounds change, but its content does not -- i.e., the
      old content simply gets cropped to the new bounds.
      460c3d13
    • Ell's avatar
      app: add gimp_tile_handler_validate_buffer_copy() · eeed4778
      Ell authored
      Add gimp_tile_handler_validate_buffer_copy(), which can be used
      instead of gegl_buffer_copy(), to copy a (subregion of a) source
      buffer to a destination buffer with a GimpTileHandlerValidate,
      uninvalidating, and avoiding unnecessarily rendering, the
      affected region.  Additionally, if the source buffer also uses a
      GimpTileHandlerValidate, the relevant parts of the source buffer's
      dirty region are copied to the destination's dirty region as well.
      eeed4778
    • Ell's avatar
      app: add gimp_tile_handler_validate_unassign() · 12530e21
      Ell authored
      ... which should be used to properly remove a
      GimpTileHandlerValidate from a buffer, instead of using
      gegl_buffer_remove_handler() directly.
      
      Use gimp_tile_handler_validate_unassign(), instead of
      gegl_buffer_remove_handler(), in gimp_projection_free_buffer().
      12530e21
    • Ell's avatar
      app: in GimpTileHandlerValidate, clear data when allocating tile · e1e4ba9c
      Ell authored
      In GimpTileHandlerValidate, when allocating a new tile upon a
      TILE_GET command, but not rendering the whole tile, clear the tile
      data before rendering, so that the unrendered regions of the tile
      contain zeros, rather than junk.
      e1e4ba9c
    • Martin Srebotnjak's avatar
      Updated Slovenian translation · 1a0185f7
      Martin Srebotnjak authored
      1a0185f7
    • Martin Srebotnjak's avatar
      Updated Slovenian translation · 19076b13
      Martin Srebotnjak authored
      19076b13
    • Martin Srebotnjak's avatar
      Updated Slovenian translation · a03dc0e7
      Martin Srebotnjak authored
      a03dc0e7
    • Vinzenz Vietzke's avatar
      Update German translation · 79bdbfaa
      Vinzenz Vietzke authored
      (cherry picked from commit 0a2c03b6)
      79bdbfaa
    • Martin Srebotnjak's avatar
      Updated Slovenian translation · 1394af39
      Martin Srebotnjak authored
      1394af39
  4. 02 Aug, 2018 6 commits
  5. 01 Aug, 2018 6 commits
    • Jehan's avatar
      INSTALL: update gettext requirement. · 9c84d237
      Jehan authored
      Also fix number of hyphens around the title.
      9c84d237
    • Jehan's avatar
      configure: making xgettext recommended version a requirement. · 8e6afe10
      Jehan authored
      Back when I implemented this as a recommendation, gettext 0.19 was not
      even out yet. Nowadays it is in Debian Testing (Debian Stable even!), so
      it makes no sense to continue just "recommend" it, especially as it was
      breaking script-fu localization.
      
      See old commit feb1bf27.
      8e6afe10
    • Jehan's avatar
      app: add "cairo-ARGB32" to "R'G'B'A u8" in gimp_babl_init_fishes(). · a03e52ea
      Jehan authored
      This fish is used for text layers, so if we let it to be
      lazy-initialized, the first time one writes text in a text layer, it
      generates a few seconds delay, which is really not great.
      a03e52ea
    • Jehan's avatar
      po: fix validation of Desktop file because of Marathi keywords. · 79a5c304
      Jehan authored
      Fixes:
      > WARNING: Failed to validate desktop file […] for locale string list
      > key "Keywords[mr]" in group "Desktop Entry" does not have a semicolon
      > (';') as trailing character
      
      I just added a semicolon.
      79a5c304
    • Ell's avatar
      Issue #1884 - Incorrect font when export to png · a826a193
      Ell authored
      In gimp_layer_convert(), avoid converting the drawable type when
      the source and destination color profiles are equal, if otherwise
      unnecessary.  Otherwise, text layers get unnecessarily re-rendered
      during conversion, and, by extension, during image duplication
      (which happens when exporting to any format that requires merging
      down the image).  This may cause the text layer to appear
      differently in the duplicated image, or even use a different font
      if the original font doesn't exist.
      a826a193
    • Ell's avatar
      app: copy the is-color-managed status when duplicating an image · f38443f3
      Ell authored
      When duplicating an image, copy the source image's is-color-managed
      status to the duplicated image, instead of having the duplicated
      image always be color managed.  In particular, do this before
      duplicating the layers, so that we don't convert the duplicated
      layers from sRGB to the image's profile when duplicating an image
      with a non-sRGB profile but with color management turned off.
      f38443f3
  6. 31 Jul, 2018 5 commits