1. 10 Dec, 2017 1 commit
    • Jehan's avatar
      plug-ins: differentiate a delay before the area/window selection... · b57c89dd
      Jehan authored
      ... and a delay before the screenshot.
      Until now, there was only delay before selection, which I changed in
      commits d9cd4b61 and 614bcf6d. Actually a delay before selection may
      also be useful, for instance when you use a tablet without keyboard (no
      alt-tab possible) and the window/area you wish to capture is behind GIMP
      window. Then you'd want to interact with the desktop with the pointer
      before the cursor changes for selection interaction.
      I add some logics so that the selection delay doesn't show when it is
      unecessary (for instance for full-screen screenshot, or when the window
      screenshot is based on the active window, not click selection, like with
      GNOME shell API).
  2. 09 Dec, 2017 8 commits
    • Jehan's avatar
      plug-ins: leave a message for translators. · 733b2344
      Jehan authored
      "Digital Elevation Model" (DEM) is a technical term which therefore
      cannot be translated just by its meaning.
    • Jehan's avatar
      plug-ins: let's special-case just a bit the HGT data. · b78b14b1
      Jehan authored
      - Display title "Digital Elevation Model data" instead of just "Image".
      - Don't show the type combo anymore, since HGT is always 16-bit signed
        integer in big endian.
      - Don't show the width and height either, but instead show a dropdown
        list to choose between either SRTM-1 or SRTM-3 data. There seems to be
        only these 2 types of data, and this will determine the width and
        height. This choice (SRTM-1 vs 3) will mostly likely be better known
        by people than knowing what image dimension they have to set,
        especially since official links for such files seem to all include the
    • Jehan's avatar
      plug-ins: minor cleaning and fixes. · 88ccdb4e
      Jehan authored
      - Add some parentheses to sizeof (*pointer). Maybe it's just me, but it
        is just a bit clearer to me.
      - Free in_raw when out_raw allocation failed.
      - Use strrchr() instead of strchr() to get the extension (I had a case
        when testing where the file was inside a folder named similarly with a
        ".hgt" and it would break the comparison test).
      - Do a case-insensitive comparison. Even though the original files from
        NASA use lowercase, just to be sure.
    • Massimo Valentini's avatar
      Bug 771661: Extend the raw data import plugin to open .hgt files · c572bdf6
      Massimo Valentini authored
      add support to load single channel 16 bit, signed/unsigned,
      little/big endian 2d raster data as a 16 bit RGB gamma GIMP image
    • Jehan's avatar
      plug-ins: s/Windows.h/windows.h/. · 36daa6db
      Jehan authored
      I just cross-compiled for Windows after a long time. The header file is
      all lowercase on a cross-compilation MinGW-w64 environment. I'm not sure
      what is the case on Windows, but since this platform is case-insensitive
      for file names, I believe this won't break anything on native builds.
    • Jehan's avatar
      plug-ins: fix a bunch of coding style. · bf13c13e
      Jehan authored
      The screenshot-win32.c file was absolutely not following our coding
      style. A lot of things are still wrong (like camelCase functions), but
      at least I fixed a bunch of indentations, space between function and
      arguments, alignments, curly brackets at start of lines, etc.
    • Jehan's avatar
      Bug 791352 - Screenshot delay is broken for region shots in GNOME. · 614bcf6d
      Jehan authored
      Delay should indeed happen before root and window screenshots, but must
      happen in-between region selection and region screenshot.
      One can notice that the logics is different for Windows screenshot in
      X11. The reason is that X11 window screenshot has an additional window
      selection step (and therefore delay must happen in between selection and
      actual screenshot). Window screenshot in Wayland doesn't have this step
      and simply screenshots whatever is the currently active Window.
    • Jehan's avatar
      Bug 791352 - Screenshot delay is broken for region-grab screenshot. · d9cd4b61
      Jehan authored
      Fix first the delay in X11.
      Actually both for region and window screenshots, it makes no sense to
      delay *before* region or window selection. Usually when one uses a
      delay, the point is to prepare in-between selection and shot. For
      instance, I often used a delay to snap the contents of a menu because
      PrintScreen key would not work when a menu is opened. So I would set a
      delay, select my window/region, then quickly open the menu before the
      delay is counting down. This would not be possible with the way delay
      occurred (before selection), which just has no use that I can see of.
  3. 08 Dec, 2017 2 commits
  4. 06 Dec, 2017 1 commit
    • Ell's avatar
      plug-ins: in file-psd, insert layers to image after writing buffers · 67e68575
      Ell authored
      When loading PSDs, insert layers to the image as the last step of
      layer creation, after writing the pixel data to their buffers, so
      that the data of child layers is available when their parent
      group's projection is subseqeuently invalidated; otherwise, we'd
      need an additional gimp_drawable_update() call after writing the
      data to the buffers.
  5. 03 Dec, 2017 1 commit
  6. 26 Nov, 2017 1 commit
    • Jehan's avatar
      plug-ins: make Darktable version checking more generic. · 1e78d3d2
      Jehan authored
      I realize that on Fedora 27, the output of `darktable --version` is:
      "this is darktable darktable-2.2.5-4.fc27"
      This is different from the expected output in our plug-in ("this is
      darktable 2.2.5"). I assume this version string can be customized and
      distribution packagers will use the capability. So a regular expression,
      in a slightly more flexible fashion would be better. I still assume that
      the version string with start with "this is darktable", but then I
      accept any non-number string until I reach a common major.minor.patch
      version-looking string.
  7. 20 Nov, 2017 1 commit
  8. 11 Nov, 2017 2 commits
    • Ell's avatar
      Bug 789981 - Wrong layer structure in PSDs with deeply nested layer groups · 54ec9373
      Ell authored
      Photoshop CS5 adds support for layer groups whose nesting depth is
      above 5.  The end markers of these groups use an undocumented
      "lsdk" key for their section dividers, rather than the usual
      "lsct".  This caused the PSD plugin to treat them as regular
      layers, resulting in wrong layer-tree structure.
      Add support for "lsdk" section dividers upon loading, and also
      generate "lsdk" section dividers upon saving sufficiently-deep
    • Ell's avatar
      plug-ins: in file-psd, repalce tabs with spaces · 6708af39
      Ell authored
  9. 29 Oct, 2017 1 commit
    • Ell's avatar
      Bug 786844 - Wavelet decompose plugin changes image slightly · 70881728
      Ell authored
      (AKA Issue with grain merge layer mode)
      Fall back to using the legacy grain-extract/merge modes when the
      input image precision is integer, and only use the non-legacy modes
      when the precision is floating point.  The midpoint intensity value
      of the non-legacy modes is 0.5, which isn't representable exactly
      using integer precision, causing small deviations between the input
      image and the reconstructed image.
  10. 25 Oct, 2017 1 commit
  11. 24 Oct, 2017 1 commit
  12. 22 Oct, 2017 2 commits
  13. 09 Oct, 2017 3 commits
  14. 28 Sep, 2017 2 commits
  15. 26 Sep, 2017 3 commits
    • Jehan's avatar
      plug-ins: use a domain on g_set_error(). · 88e6dc46
      Jehan authored
      Without a domain error, glib outputs on console:
      > g_error_new_valist: runtime check failed: (domain != 0)
      Let's just create a domain error for the file-pdf-load plugin.
    • Jehan's avatar
    • Thomas Manni's avatar
      plug-ins: wavelet-decompose improvements · 41a2a363
      Thomas Manni authored
      Add an option to keep the decomposition in a layer group.
      Add an option to add layer mask to each scales layers.
      Do not use 'new from visible' because it produces unexpected result when
      - image is already composed by several layers
      - target layer has not the same size as the image canvas
      Replaced by succession of layer copy and merge down.
  16. 25 Sep, 2017 1 commit
    • Jehan's avatar
      plug-ins: add parameters to file-pdf-load2 to load multiple pages. · d5fd6702
      Jehan authored
      This is a new API function, so now is the right time to add missing
      parameters! This will allow to load a selection of pages, and even to
      reorder the document while doing so. Or simply load all pages in the
      right order with n_pages <= 0.
  17. 24 Sep, 2017 2 commits
  18. 10 Sep, 2017 3 commits
    • Jehan's avatar
      plug-ins: check GError domain and code, not the message. · 0f2002c9
      Jehan authored
      When there is a well-documented GError domain/code, use these,
      especially since messages can be localized (not sure if that is the case
      for this one, but theoretically it could) and change over time.
      Also remove the "nice-to-have" comment on file-pdf-load since we won't
      be changing it now, but leave it on file-pdf-load2 parameters which can
      still change before 2.10.
    • Jehan's avatar
      plug-ins: fixes and review to the previous commit. · af8519b2
      Jehan authored
      - Clean out some C++ style comments (our coding style only accepts
        C-style comments. Anyway these comments were just old useless code).
      - A block indentation fix.
      - As a guideline, it is better to keep a GError as the last parameter.
      - In non-interactive mode, the new procedure must use the value in
        parameter, otherwise passing the password just doesn't work.
    • Lionel's avatar
      Bug 787090 - Encrypted PDF support · 8ef7303f
      Lionel authored
      Fix for non-interative mode so that it doesn't raise any gtk dialogs.
      Added a file-pdf-load2 procedure with an extra argument for the password.
  19. 09 Sep, 2017 1 commit
  20. 04 Sep, 2017 3 commits