1. 14 Jan, 2018 5 commits
    • Michael Natterer's avatar
      Bug 792470 - Some filters e.g. "Levels" are not added to "Repeat last" history · b23f231a
      Michael Natterer authored
      The four remaining "classic" color tools (Brightness-Contrast, Curves,
      Levels and Threshold) are in fact just special UIs for otherwise
      completely normal filter ops.
      
      Add normal filter actions for them and invoke them like all
      other filters, which makes them show up in the filter history
      automatically.
      
      The only small hack needed is to special case them in
      gimp_gegl_procedure_execute_async() so the right tools are created
      instead of the default GimpOperationTool. Also, blacklist the
      automatically generated tools actions from action search and the
      shortcut editor.
      b23f231a
    • Jehan's avatar
      Rename gimp.appdata.xml.in to org.gimp.GIMP.appdata.xml.in.in. · 458e3130
      Jehan authored
      I completely forgot to rename the appstream file according to the new
      ID. While doing so, I also make it a .in.in file, with initial
      processing by the autotools. Indeed I need @GIMP_COMMAND@ to be replaced
      by AC_CONFIG_FILES().
      Finally I fix a badly closed XML tag (which reminds me I should always
      test a commit, even when it's a simple non-C 1-liner change!).
      458e3130
    • Jehan's avatar
      NEWS: RGBE export added and AppStream update. · b1d413db
      Jehan authored
      b1d413db
    • Jehan's avatar
      desktop: update the appdata to take care of the id change. · 54dda25c
      Jehan authored
      From AppStream docs:
      «
      In previous AppStream releases, the <id/> was used to associate metainfo
      files with their .desktop files to merge in data from .desktop files
      into the AppStream generator's final output. In modern metainfo files,
      the component-ID for desktop-application components can be an arbitrary
      string (matching the naming rules applying to all AppStream metadata),
      while the <launchable/> tag is used to associate .desktop files with
      their metainfo files.
      »
      54dda25c
    • Nate Graham's avatar
      Bug 791861 - Update appdata.xml AppStream ID to match rDNS-style... · d39f7d6f
      Nate Graham authored
      ... used for Flatpak.
      
      Additional comments by Jehan after review:
      «
      This is not only to sync with flatpak. This format is the recommended
      format in AppStream spec, even though many historical application still
      use the old format.
      If ever we decide to propose a dbus service, this may even become
      required.
      However just changing this is not enough for a proper ID change. I will
      make additional change in further commits.
      »
      d39f7d6f
  2. 13 Jan, 2018 4 commits
  3. 12 Jan, 2018 9 commits
  4. 11 Jan, 2018 15 commits
  5. 10 Jan, 2018 7 commits
    • Jehan's avatar
      libgimp: update gimp_image_metadata_save_prepare() description. · 5e3d4cf1
      Jehan authored
      The returned flags should not be called "suggested" flags anymore.
      Having metadata available in the work image does not mean we want them
      exported absolutely, which can be a security risk, especially for the
      metadata which are there from the imported image.
      5e3d4cf1
    • Jehan's avatar
      Bug 790552 - do not save metadata by default. · 096debb0
      Jehan authored
      This is a privacy concern. Whereas importing metadata is usually a good
      idea, exporting it should be a conscious action. A lot of private data
      can be leaked through metadata and many people don't realize it (which
      also usually means they don't need it). On the other hand, the people
      who realize it are the ones who would explicitly edit the metadata and
      check what they want to be exported or not.
      
      This is only a first step. Some people may want to always export the
      metadata and for these people, there should be abilities to change the
      default.
      096debb0
    • Massimo Valentini's avatar
      Bug 784647: Crash when choosing debug option Show Image Graph · b118e824
      Massimo Valentini authored
      The attached patch avoids CRITICALs when executing Debug actions
      with no images open.
      1) do not run projection benchmark unless there is an image
      2) memsize of pluginmanager member was incorrectly computed using
         gimp_object functions for 2 GObjects
      b118e824
    • Jehan's avatar
      Revert "app: use FAST filter when painting xfer surface" · 21cb905d
      Jehan authored
      This reverts commit 36258a67.
      This commit was making the rotated canvas rendering quite horrible to
      the point that I think it would make the canvas rotation feature barely
      usable. See bug 759287, comments 13 to 18.
      I think we will need to find other ways to accelerate rendering.
      Compromise on quality is possible, but I think that in this case, this
      was more than just a compromise. It was more like completely abandonning
      quality. We could even see the lines "spiking" while you were rotating!
      Like your drawing was alive!
      21cb905d
    • Jehan's avatar
      plug-ins: fix some coding-style issues in metadata-editor. · bc503201
      Jehan authored
      Mostly missing spaces here and there fixed with search and replace
      followed by manual verification and retouching.
      bc503201
    • Jehan's avatar
      plug-ins: metadata-editor crashes when strtok() initialized with NULL. · 62ee5d3c
      Jehan authored
      When running strtok() the first time, it needs to be non-NULL so we must
      check for the string. This is even more important because NULL actually
      has a special meaning in strtok() to indicate further search on the same
      string, in a stateful way. So searching with NULL at first call was
      crashing the metadata editor plug-in in my case.
      I could also imagine it could have reused strings from previous
      searches, mixing metadata contents in some edge cases. Anyway that would
      be bad as well!
      
      While I was there, I also checked for non-null search string before
      strstr() calls, when there was not already such a check before. This
      function also requires non-NULL haystack argument.
      It feels like this code doesn't do much validity checks, and it's likely
      there are more similar issues. I haven't reviewed the whole code, only
      this part which was crashing here.
      62ee5d3c
    • Michael Natterer's avatar