1. 03 Oct, 2019 12 commits
    • Jehan's avatar
      gitlab-ci: new build organization. · 90591dc7
      Jehan authored
      Rather than having the whole Win32 cross-build into the 'gimp' stage,
      break the dependencies and GIMP-only builds in 2 stages.
      
      Since apparently we need to keep the same structure for the native and
      cross build (otherwise we don't get parallel builds; in other words, I
      didn't find the possibility to set separate pipelines up), I move babl
      and GEGL into the same 'dependencies' stage.
      
      Finally I remove the -base rules extended into actual jobs, except for
      `.gimp-base` (this is the only which makes sense as it is actually
      common to the meson and autotools build).
      90591dc7
    • Jehan's avatar
      gitlab-ci: set GIT_DEPTH to 1. · aa611bea
      Jehan authored
      We don't need to pull 5 commits of history. Only the HEAD of the
      selected branch is needed.
      Also define it globally rather than re-defining it in every job to the
      same value.
      aa611bea
    • Jehan's avatar
      gitlab-ci: improve artifacts settings. · 5c7f1ce5
      Jehan authored
      First replace the "when: on_failure" rule by a "when: always". We indeed
      always want to get log artifact so that we can study a build if
      necessary (neither only on failure nor on success; really on all cases,
      since even an apparently successful build may have issues we might want
      to diagnose).
      
      Also expire all artifacts at 1 week (it seems the default on GNOME's
      Gitlab is 4 weeks; we don't need to keep these so long. Even a few days
      might be enough actually).
      
      As for the artifacts contents, keep the build dirs rather than the
      install dirs. Build dirs allow to check configuration logs and other
      kind of logs which are the most useful when diagnosing a failed build.
      Now install dirs are also interesting. Maybe we should provide them
      again at some point. We'll see. For now I comment them out.
      Still keep the install dir for dependencies though, since it seems this
      is how data are passed from one job to another.
      Note that ideally we would like to provide different artifacts depending
      on failure or success but apparently this is currently not possible.
      See: https://gitlab.com/gitlab-org/gitlab/issues/18744
      
      Also not sure why for GIMP, the CI was only keeping the build app/tests/
      directory. We should really keep the whole dir.
      5c7f1ce5
    • Jehan's avatar
      gitlab-ci: do not export SHELL env variable before crossroad. · d27b7a27
      Jehan authored
      This will simply default to bash.
      d27b7a27
    • Jehan's avatar
      gitlab-ci: fix crossroad and dnf caching. · 29639336
      Jehan authored
      This should hopefully speed up successive builds as most packages don't
      need to be re-downloaded.
      29639336
    • Martin Srebotnjak's avatar
      Updated Slovenian translation · 9aec0526
      Martin Srebotnjak authored
      9aec0526
    • Ell's avatar
      app: don't extend layers with no alpha channel when applying filters · 2665a6c7
      Ell authored
      In GimpFilterTool, don't provide a clipping option for layers with
      no alpha channel, and always clip the result to the layer bounds,
      since the extended regions of the result usually require alpha to
      be meaningful.
      
      Similarly to last commit, the ideal solution would be to
      automatically add an alpha channel as necessary.
      2665a6c7
    • Ell's avatar
      app: clip floating selection to layers with no alpha channel · 1c67395c
      Ell authored
      Alawys clip a floating selection to its base layer, if the layer
      has no alpha channel.  This avoids arbitrarily filling the extended
      regions of the layer with, or compositing the floating selection
      against, black color.
      
      This is a temporary solution.  Ideally, we'd automatically add an
      alpha channel to the layer as necessary.
      1c67395c
    • Ell's avatar
    • Ell's avatar
      app: avoid dropping cached data when committing filters · 11629fde
      Ell authored
      In gimp_gegl_apply_cached_operation(), add a boolean
      connect_src_buffer parameter, which determines whether to connect
      the source buffer to the operation-node's input, or to use its
      existing input.  In gimp_drawable_merge_filter(), pass FALSE for
      connect_src_buffer, so that the existing filter-node input is used.
      This produces an equivalent result, however, it avoids invalidating
      the filter node, and dropping cached data as a result.  In
      operations that cache larger areas than the ROI, this avoids
      reprocessing already-cached data when processing the rest of the
      operation.
      
      Additionally, in gimp_gegl_apply_cached_operation(), use an empty
      input for the operation if src_buffer is NULL and
      connect_src_buffer is TRUE; previously, we'd use the operation-
      node's existing input when src_buffer was NULL.  Furthermore, crop
      the operation-node's input to the destination rect when crop_input
      is TRUE, even if connect_src_buffer is FALSE.
      11629fde
    • Michael Natterer's avatar
      50b8adc7
    • Michael Natterer's avatar
  2. 02 Oct, 2019 10 commits
  3. 01 Oct, 2019 4 commits
  4. 30 Sep, 2019 8 commits
    • Jehan's avatar
      plug-ins: generated rc files depends on git-version.h. · e65639ec
      Jehan authored
      We must make sure that git-version.h has already been generated before
      we run windows.compile_resources() for the Windows host.
      e65639ec
    • Jehan's avatar
      gitlab-ci: run gdk-pixbuf-query-loaders. · 203509fe
      Jehan authored
      It was not necessary when I was only running the cross-build job. Not
      sure why it is needed now. What do the parallel jobs share exactly in
      this CI system? Anyway…
      203509fe
    • Jehan's avatar
      libgimp: fix meson build. · f87ae8cc
      Jehan authored
      f87ae8cc
    • Jehan's avatar
      build, gitlab-ci: add a script to cross-build GIMP with Gitlab CI. · e17efb7a
      Jehan authored
      It looks like Arch does not have mingw64 cross-compilers in core package
      repository. It does have some package in the user repository (AUR), but
      I assume that such a repository cannot be deemed as safe.
      
      Anyway I still tried, but apparently these AUR packages have to be built
      and when I tried, I got this error:
      >  ERROR: Running makepkg as root is not allowed as it can cause
      > permanent, catastrophic damage to your system.
      
      Anyway it's all a big mess. Then I tried to move the cross-CI to Debian
      testing, which is anyway our base compatibility system. Unfortunately I
      encountered like what looked like some glibc++ macro problem on some
      packages (most likely because the pre-built packages I use are Fedora
      ones which likely uses a cross-compiler differently built from the
      Debian one).
      
      So in the end, for simplicity, I use a Fedora image, then I am sure to
      get a good match between the system cross-compiler and the pre-built
      dependencies.
      e17efb7a
    • Michael Natterer's avatar
      plug-ins: same cleanup in the DDS load dialog · d3cfae27
      Michael Natterer authored
      and some more general cleanups.
      d3cfae27
    • Michael Natterer's avatar
      plug-ins: prepare file-dds for GimpProcedureConfig porting · b10bdf88
      Michael Natterer authored
      by replacing its own combo box code by GimpIntComboBox which is
      trivially portable to propwidgets. Also some formatting cleanup in the
      save code.
      b10bdf88
    • Rodrigo Lledó Milanca's avatar
      Update Spanish translation · de03dbed
      Rodrigo Lledó Milanca authored
      de03dbed
    • Ell's avatar
      Issue #3994 - Artifacts when committing half-cached filters · 88c6f829
      Ell authored
      In gimp_gegl_apply_cached_operation(), when applying a non-point
      filter with the same source and destination buffers, render the
      result to a temporary buffer to avoid chunking artifacts.  We'd
      previously duplicate the source buffer instead (with commit
      35729ee0 erroneously copying the
      cached results to the source/destination buffer before duplicating
      it, causing this bug), but we now use a temporary result buffer
      instead; this has roughly the same overhead, but would allow us to
      keep the original operation-node input when committing a drawable
      filter in a future commit, which would avoid dropping any cached
      data.
      88c6f829
  5. 29 Sep, 2019 1 commit
  6. 28 Sep, 2019 5 commits