1. 03 Aug, 2019 2 commits
    • Niels De Graef's avatar
      Add (nullable) if applicable · 5f92ced1
      Niels De Graef authored
      Basically this commit makes sure that all return values that are marked
      as "Returns:" also have a `(nullable)` annotation if it is mentioned on
      the same line that NULL can also be returned.
      This will prevent a few problems in GObject-introspection.
    • Niels De Graef's avatar
      Use "Returns:" to annotate return values · 1dda6015
      Niels De Graef authored
      To be able to annotate return values through GObject-introspection, you
      need to make sure it is tagged with `Returns:` and not something else.
  2. 28 May, 2019 1 commit
  3. 01 Jan, 2019 1 commit
  4. 02 Dec, 2018 1 commit
  5. 18 Sep, 2018 1 commit
    • Ell's avatar
      app, libgimp*, modules: don't use g_type_class_add_private() ... · 3b0040c0
      Ell authored
      g_type_class_add_private() and G_TYPE_INSTANCE_GET_PRIVATE() were
      deprecated in GLib 2.58.  Instead, use
      G_ADD_PRIVATE[_DYNAMIC](), and the implictly-defined
      foo_get_instance_private() functions, all of which are available in
      the GLib versions we depend on.
      This commit only covers types registered using one of the
      G_DEFINE_FOO() macros (i.e., most types), but not types with a
      custom registration function, of which we still have a few -- GLib
      currently only provides a (non-deprecated) public API for adding a
      private struct using the G_DEFINE_FOO() macros.
      Note that this commit was 99% auto-generated (because I'm not
      *that* crazy :), so if there are any style mismatches... we'll have
      to live with them for now.
  6. 10 Sep, 2018 1 commit
  7. 02 Aug, 2018 1 commit
  8. 31 Jul, 2018 1 commit
    • Michael Natterer's avatar
      Issue 1917 - GIMP-2.99 uses sRGB instead of the user-selected monitor profile · d7345a6a
      Michael Natterer authored
      Since the space invasion commit, colors entering and leaving a
      GimpColorTransform were often implicitly converted up to three times,
      the code was simply not properly ported to babl formats with spaces.
      Fix GimpColorTransform to only ever transform colors between the
      specified src and dest profiles, ignoring the space of any babl
      formats involved.
      Also, always return a non-NULL transform, even if the transform could
      be done by a simply gegl_buffer_copy(), this way we can make sure in
      one central place that transforms are done correctly, no matter if
      babl or lcms is used.
      Added quite some docs and comments to make clear what happens.
  9. 21 Jul, 2018 1 commit
    • Michael Natterer's avatar
      Initial space invasion commit in GIMP · e09e563a
      Michael Natterer authored
      All babl formats now have a space equivalent to a color profile,
      determining the format's primaries and TRCs. This commit makes GIMP
      aware of this.
      - enum GimpPrecision: rename GAMMA values to NON_LINEAR and keep GAMMA
        as deprecated aliases, add PERCEPTUAL values so we now have LINEAR,
        NON_LINEAR and PERCPTUAL for each encoding, matching the babl
        encoding variants RGB, R'G'B' and R~G~B~.
      - gimp_color_transform_can_gegl_copy() now returns TRUE if both
        profiles can return a babl space, increasing the amount of fast babl
        color conversions significantly.
      - TODO: no solution yet for getting libgimp drawable proxy buffers in
        the right format with space.
      - follow the GimpPrecision change.
      - TODO: everything else unchanged and partly broken or sub-optimal,
        like setting a new image's color profile too late.
      - add enum GimpTRCType { LINEAR, NON_LINEAR, PERCEPTUAL } as
        replacement for all "linear" booleans.
      - change gimp-babl functions to take babl spaces and GimpTRCType
        parameters and support all sorts of new perceptual ~ formats.
      - a lot of places changed in the early days of goat invasion didn't
        take advantage of gimp-babl utility functions and constructed
        formats manually. They all needed revisiting and many now use much
        simpler code calling gimp-babl API.
      - change gimp_babl_format_get_color_profile() to really extract a
        newly allocated color profile from the format, and add
        gimp_babl_get_builtin_color_profile() which does the same as
        gimp_babl_format_get_color_profile() did before. Visited all callers
        to decide whether they are looking for the format's actual profile,
        or for one of the builtin profiles, simplifying code that only needs
        builtin profiles.
      - drawables have a new get_space_api(), get_linear() is now get_trc().
      - images now have a "layer space" and an API to get it,
        gimp_image_get_layer_format() returns formats in that space.
      - an image's layer space is created from the image's color profile,
        change gimpimage-color-profile to deal with that correctly
      - change many babl_format() calls to babl_format_with_space() and take
        the space from passed formats or drawables
      - add function gimp_layer_fix_format_space() which replaces the
        layer's buffer with one that has the image's layer format, but
        doesn't change pixel values
      - use gimp_layer_fix_format_space() to make sure layers loaded from
        XCF and created by plug-ins have the right space when added to the
        image, because it's impossible to always assign the right space upon
        layer creation
      - "assign color profile" and "discard color profile" now require use
        of gimp_layer_fix_format_space() too because the profile is now
        embedded in all formats via the space.  Add
        gimp_image_assign_color_profile() which does all that and call it
        instead of a simple gimp_image_set_color_profile(), also from the
        PDB set-color-profile functions, which are essentially "assign" and
        "discard" calls.
      - generally, make sure a new image's color profile is set before
        adding layers to it, gimp_image_set_color_profile() is more than
        before considered know-what-you-are-doing API.
      - take special precaution in all places that call
        gimp_drawable_convert_type(), we now must pass a new_profile from
        all callers that convert layers within the same image (such as
        image_convert_type, image_convert_precision), because the layer's
        new space can't be determined from the image's layer format during
        the call.
      - change all "linear" properties to "trc", in all config objects like
        for levels and curves, in the histogram, in the widgets. This results
        in some GUI that now has three choices instead of two.
        TODO: we might want to reduce that back to two later.
      - keep "linear" boolean properties around as compat if needed for file
        pasring, but always convert the parsed parsed boolean to
      - TODO: the image's "enable color management" switch is currently
        broken, will fix that in another commit.
  10. 11 Jul, 2018 1 commit
  11. 18 Apr, 2018 1 commit
  12. 13 Sep, 2017 1 commit
  13. 03 Sep, 2017 1 commit
  14. 02 Sep, 2017 3 commits
  15. 03 Jun, 2017 1 commit
  16. 05 Jun, 2016 1 commit
  17. 30 May, 2016 2 commits
  18. 29 May, 2016 1 commit
  19. 27 May, 2016 1 commit
  20. 26 May, 2016 3 commits
    • Michael Natterer's avatar
      libgimpcolor: add gimp_color_transform_can_gegl_copy() · ca349f88
      Michael Natterer authored
      Which takes two profiles and returns TRUE if converting between
      them works correctly without a GimpColorTransform. Use it in
      gimp_color_transform_new() to return a NULL transform if none
      is needed. Took the code from gimp-gegl-loops.c.
    • Michael Natterer's avatar
    • Michael Natterer's avatar
      libgimpcolor: add new object GimpColorTransform · cc928879
      Michael Natterer authored
      which encapsulates a cmsHTRANSFORM and does all the pixel format
      conversion magic. It has API to create transforms and proofing
      transforms, and to convert pixels arrays and GeglBuffers.
      Before, each place which has a transform had to keep around the
      transform and its input and output Babl formats, and had to implement
      lots of stuff itself. Now all that lives in GimpColorTransform,
      removing lots of logic from many places, and pretty much removing lcms
      from the public API entirely.
      This removes including <lcms2.h>, LCMS_LIBS and LCMS_CFLAGS from
      almost all directories and potentially allows to replace lcms by
      something else.