1. 11 Jul, 2018 1 commit
  2. 22 Jan, 2018 1 commit
    • Jehan's avatar
      app: we should not have any g_assert*() code if possible. · f87bc3fe
      Jehan authored
      Replace all g_assert_not_reached() in app/core/ by g_return_if_reached()
      or g_return_val_if_reached(). GIMP may handle a lot of creative work,
      sometimes unsaved for hours. We should not just crash on purpose.
      g_assert*() could theoretically be turned off on a glib build, but this
      is nearly never done, and is not a solution either (actually it is
      probably even worse because the broken code would just continue on a
      forbidden path). It is much better to return with a warning on such
      forbidden code paths, allowing someone to report a bug without
      experiencing a crash and data loss.
      
      For now, I only took care of g_assert_not_reached() inside app/core.
      More g_assert*() code should be replaced.
      Note: assert are acceptable in plug-ins though, but not in the main
      executable, unless absolutely necessary (something happening so bad that
      crash is better than continuing).
      f87bc3fe
  3. 03 Jul, 2015 2 commits
  4. 13 Mar, 2014 1 commit
    • João Sebastião de Oliveira Bueno's avatar
      Adds "fill" arrange modes to the Align Tool · 72ac5370
      João Sebastião de Oliveira Bueno authored
      The Align Tool had to be used in a very hacky way if one
      intended to evenly distribute items across an image,
      or other reference object (it would actually require one to
      calculate the item spacing out of GIMP). This adds vertical
      and horizontal fill modes: the reference object is divided
      in N equal segments, where N is the number of items,
      and each item is placed in the center of one of
      these segments. The existing "offset" parameter
      is used as an extra margin for the distribution,
      and can be set to negative values, so that the items can
      even get moved outside the boundaries of the reference object.
      72ac5370
  5. 14 Oct, 2013 1 commit
    • Michael Natterer's avatar
      app,libgimp*: fix includes to follow our include policy · 697572cc
      Michael Natterer authored
      - don't include <gdk-pixbuf/gdk-pixbuf.h> in headers in app/
      - instead, include it in many .c files instead of <glib-object.h>,
        finally acknowledging the fact that app/ depends on gdk-pixbuf almost
        globally
      - fix up includes as if libgimpbase depended in GIO, which it soon will
      697572cc
  6. 01 Oct, 2010 1 commit
    • Michael Natterer's avatar
      app: draw guides using GimpCanvasItems · 26d0035b
      Michael Natterer authored
      - Add signals GimpImage::guide_added(), removed() and moved()
      - Remove singal GimpImage::update_guide()
      - Adapt core code to emit the new signals instead of update_guide()
      - Have the shell connect to the new signals and update guide canvas
        items as needed
      - Remove gimp_display_shell_draw_guides()
      26d0035b
  7. 09 Jun, 2010 1 commit
    • Barak Itkin's avatar
      app: add context to all undo descriptions · 5930b130
      Barak Itkin authored
      Description of undo actions should be marked as action descriptions,
      and not as commands. This is required for translation for some
      language (like Hebrew) that require a different grammatical tense for
      describing actions
      5930b130
  8. 17 Jan, 2009 1 commit
    • Michael Natterer's avatar
      Change licence to GPLv3 (and to LGPLv3 for libgimp). · d9b5207a
      Michael Natterer authored
      2009-01-17  Michael Natterer  <mitch@gimp.org>
      
      	* all files with a GPL header and all COPYING files:
      
      	Change licence to GPLv3 (and to LGPLv3 for libgimp).
      
      	Cleaned up some copyright headers and regenerated the parsers in
      	the ImageMap plugin.
      
      
      svn path=/trunk/; revision=27913
      d9b5207a
  9. 03 Nov, 2008 1 commit
    • Michael Natterer's avatar
      renamed gimp_item_width() to gimp_item_get_width() and gimp_item_height() · 740ab5e6
      Michael Natterer authored
      2008-11-03  Michael Natterer  <mitch@gimp.org>
      
      	* app/core/gimpitem.[ch]: renamed
      	gimp_item_width() to gimp_item_get_width() and
      	gimp_item_height() to gimp_item_get_height().
      
      	* app/actions/channels-commands.c
      	* app/actions/drawable-commands.c
      	* app/actions/layers-commands.c
      	* app/core/<many>.c
      	* app/dialogs/offset-dialog.c
      	* app/dialogs/resize-dialog.c
      	* app/dialogs/scale-dialog.c
      	* app/display/gimpdisplayshell-dnd.c
      	* app/display/gimpdisplayshell.c
      	* app/paint/gimpbrushcore.c
      	* app/paint/gimpdodgeburn.c
      	* app/paint/gimpink.c
      	* app/paint/gimppaintcore.c
      	* app/paint/gimpsmudge.c
      	* app/text/gimptextlayer-xcf.c
      	* app/text/gimptextlayer.c
      	* app/tools/gimpaligntool.c
      	* app/tools/gimpeditselectiontool.c
      	* app/tools/gimpforegroundselecttool.c
      	* app/tools/gimpimagemaptool.c
      	* app/tools/gimprectangletool.c
      	* app/tools/gimpregionselecttool.c
      	* app/tools/gimptexttool.c
      	* app/vectors/gimpvectors.c
      	* app/vectors/gimpvectorsmodundo.c
      	* app/widgets/gimptoolbox-dnd.c
      	* app/widgets/gimpviewrendererdrawable.c
      	* app/widgets/gimpviewrenderervectors.c
      	* app/xcf/xcf-load.c
      	* app/xcf/xcf-save.c
      	* tools/pdbgen/pdb/drawable.pdb: changed accordingly.
      
      	* app/pdb/drawable-cmds.c: regenerated.
      
      
      svn path=/trunk/; revision=27531
      740ab5e6
  10. 02 Nov, 2008 1 commit
    • Michael Natterer's avatar
      renamed gimp_item_offsets() to gimp_item_get_offset() and · 5b68a1d0
      Michael Natterer authored
      2008-11-03  Michael Natterer  <mitch@gimp.org>
      
      	* app/core/gimpitem.[ch]: renamed
      	gimp_item_offsets() to gimp_item_get_offset() and
      	gimp_item_set_offsets() to gimp_item_set_offset().
      
      	* app/actions/drawable-commands.c
      	* app/actions/layers-commands.c
      	* app/core/<many>.c
      	* app/display/gimpdisplayshell-dnd.c
      	* app/display/gimpdisplayshell-preview.c
      	* app/display/gimpdisplayshell-transform.c
      	* app/display/gimpdisplayshell.c
      	* app/paint/gimppaintcore-stroke.c
      	* app/paint/gimppaintcore.c
      	* app/paint/gimpsourcecore.c
      	* app/text/gimptextlayer-xcf.c
      	* app/tools/<many>.c
      	* app/widgets/gimptoolbox-dnd.c
      	* tools/pdbgen/pdb/drawable.pdb
      	* tools/pdbgen/pdb/drawable_transform.pdb
      	* tools/pdbgen/pdb/selection.pdb
      	* tools/pdbgen/pdb/transform_tools.pdb
      	* tools/pdbgen/pdb/vectors.pdb: changed accordingly.
      
      	* app/pdb/drawable-cmds.c
      	* app/pdb/drawable-transform-cmds.c
      	* app/pdb/selection-cmds.c
      	* app/pdb/vectors-cmds.c
      	* app/pdb/transform-tools-cmds.c: regenerated.
      
      
      svn path=/trunk/; revision=27529
      5b68a1d0
  11. 09 Oct, 2008 1 commit
    • Michael Natterer's avatar
      Add GEGL_CFLAGS and #includes as if gimpdrawable.h and gimpimage.h had a · 5503e6a0
      Michael Natterer authored
      2008-10-09  Michael Natterer  <mitch@gimp.org>
      
      	Add GEGL_CFLAGS and #includes as if gimpdrawable.h and gimpimage.h
      	had a GEGL dependency (they will have in the next commit, but I
      	wanted to keep the commit separate).
      
      	* app/dialogs/Makefile.am
      	* app/file/Makefile.am
      	* app/gui/Makefile.am
      	* app/menus/Makefile.am
      	* app/paint/Makefile.am
      	* app/plug-in/Makefile.am
      	* app/text/Makefile.am
      	* app/vectors/Makefile.am
      	* app/widgets/Makefile.am
      	* app/xcf/Makefile.am: add GEGL_CFLAGS.
      
      	* app/actions/*.c
      	* app/core/*.c
      	* app/dialogs/*.c
      	* app/display/*.c
      	* app/file/*.c
      	* app/gui/*.c
      	* app/menus/*.c
      	* app/paint/*.c
      	* app/pdb/gimppdb-utils.c
      	* app/pdb/gimpprocedure.c
      	* app/plug-in/*.c
      	* app/text/*.c
      	* app/tools/*.c
      	* app/vectors/*.c
      	* app/widgets/*.c
      	* app/xcf/*.c: add <gegl.h> or replace <glib-object.h> by <gegl.h>
      	to all files which include a drawable subclass or gimpimage.h
      
      	* tools/pdbgen/app.pl: include <gegl.h> instead of <glib-object.h>
      	in all generated files.
      
      	* app/pdb/*-cmds.c: regenerated.
      
      	* data/images/gimp-splash.png: the goat is still sleeping.
      	By Aurore Derriennic.
      
      
      svn path=/trunk/; revision=27202
      5503e6a0
  12. 15 Oct, 2007 1 commit
  13. 09 Dec, 2006 1 commit
  14. 09 Jun, 2006 1 commit
    • William Skaggs's avatar
      Bill Skaggs <weskaggs@primate.ucdavis.edu> · e732c769
      William Skaggs authored
      	* app/core/core-enums.[ch]: add GimpAlignReferenceType enum
      
      	* app/core/gimpimage-arrange.c: support using a channel as
      	reference for alignment.
      
      	* app/tools/gimpaligntool.[ch]: support aligning with a list item,
      	image, selection, active layer, active channel, or active path.
      	Now similar in form and function to Inkscape Align/Distribute
      	dialog.
      e732c769
  15. 08 Jun, 2006 1 commit
    • William Skaggs's avatar
      Bill Skaggs <weskaggs@primate.ucdavis.edu> · 9dbc0ee1
      William Skaggs authored
      	* app/core/core-enums.[ch]: add GIMP_ARRANGE_FOO values
      	to GimpAlignmentType, and change CENTER to HCENTER,
      	MIDDLE to VCENTER.
      
      	* app/core/gimpimage-arrange.c: extensively rewritten
      	to handle arrangement of objects, and to do the
      	required sorting of lists by offset.
      
      	* app/tools/gimpaligntool.[ch]: added ability to arrange
      	groups of layers etc with constant spacing.  Also try
      	to change things so that the tool aligns with the
      	object that users expect intuitively.
      9dbc0ee1
  16. 07 Jun, 2006 1 commit
    • William Skaggs's avatar
      Bill Skaggs <weskaggs@primate.ucdavis.edu> · 40db64f4
      William Skaggs authored
      	* app/core/gimpimage-arrange.[ch]: added, utility function for
      	aligning and arranging things in an image.
      
      	* app/core/gimpitem-align.[ch}: removed, no longer needed.
      
      	* app/core/gimpimage-item-list.[ch] (gimp_image_item_list_align):
      	removed this function, no longer used.
      
      	* app/core/Makefile.am: changes described above.
      
      	* app/core/gimpguide.c: remove bit of cruft left accidentally.
      
      	* app/tools/gimpalignoptions.[ch]: remove "alignment type"
      	option, not needed at this point.
      
      	* app/tools/gimpaligntool.[ch]: numerous changes, most
      	importantly ability to align guides, and use them for
      	alignment.  More work coming on this tool.
      40db64f4