1. 11 Jul, 2018 1 commit
  2. 20 Jun, 2018 1 commit
    • Ell's avatar
      Issue #1682 - Segfault when starting GIMP, due to empty data files · 993bbd35
      Ell authored
      Use gimp_input_data_stream_read_line_always(), instead of
      g_input_data_stream_read_line(), in a bunch of places that don't
      expect EOF.  If we don't do that, the code assumes the GError
      parameter is set by the function and returns an error indication,
      causing the caller to segfault when it tries to access
      error->message.  Instead, we now process an empty line when EOF is
      reached, which is caught by the normal parsing logic.
      
      Additionally:
      
        - Use gimp_ascii_strto[id]() when loading gradients, generated
          brushes, and palettes, to improve error checking for invalid
          numeric input.
      
        - Improve gradient-segment endpoint consistency check.
      
        - Allow loading palette files with 0 colors.  They can be created
          during the session, so we might as well successfully load them.
      993bbd35
  3. 11 Oct, 2014 1 commit
  4. 15 Aug, 2014 1 commit
  5. 04 Jul, 2014 2 commits
  6. 03 Jul, 2014 1 commit
  7. 02 Jul, 2014 1 commit
  8. 01 Jul, 2014 2 commits
  9. 14 Oct, 2013 1 commit
    • Michael Natterer's avatar
      app,libgimp*: fix includes to follow our include policy · 697572cc
      Michael Natterer authored
      - don't include <gdk-pixbuf/gdk-pixbuf.h> in headers in app/
      - instead, include it in many .c files instead of <glib-object.h>,
        finally acknowledging the fact that app/ depends on gdk-pixbuf almost
        globally
      - fix up includes as if libgimpbase depended in GIO, which it soon will
      697572cc
  10. 02 May, 2012 2 commits
  11. 11 Apr, 2010 1 commit
  12. 17 Jan, 2009 1 commit
    • Michael Natterer's avatar
      Change licence to GPLv3 (and to LGPLv3 for libgimp). · d9b5207a
      Michael Natterer authored
      2009-01-17  Michael Natterer  <mitch@gimp.org>
      
      	* all files with a GPL header and all COPYING files:
      
      	Change licence to GPLv3 (and to LGPLv3 for libgimp).
      
      	Cleaned up some copyright headers and regenerated the parsers in
      	the ImageMap plugin.
      
      
      svn path=/trunk/; revision=27913
      d9b5207a
  13. 09 Dec, 2006 1 commit
  14. 12 Nov, 2006 1 commit
    • Michael Natterer's avatar
      app/base/base.c app/core/gimp-user-install.c · 85cecec5
      Michael Natterer authored
      2006-11-12  Michael Natterer  <mitch@gimp.org>
      
      	* app/base/base.c
      	* app/core/gimp-user-install.c
      	* app/core/gimpbrushgenerated-load.c
      	* app/core/gimpcontainer.c
      	* app/core/gimpgradient-load.c
      	* app/core/gimppalette-load.c
      	* app/core/gimpparamspecs-desc.c
      	* app/dialogs/tips-parser.c
      	* app/menus/plug-in-menus.c
      	* app/plug-in/gimppluginmanager.c
      	* app/plug-in/gimppluginprocedure.c
      	* app/text/gimptext-parasite.c
      	* app/tools/gimpforegroundselecttool.c
      	* app/widgets/gimpselectiondata.c
      	* app/xcf/xcf.c: use g_str_has_prefix() instead of strncmp().
      85cecec5
  15. 04 Oct, 2006 1 commit
    • Michael Natterer's avatar
      app/core/gimpbrushgenerated-load.c app/core/gimpgradient-load.c · 544d679e
      Michael Natterer authored
      2006-10-04  Michael Natterer  <mitch@gimp.org>
      
      	* app/core/gimpbrushgenerated-load.c
      	* app/core/gimpgradient-load.c
      	* app/core/gimppalette-load.c
      	* app/core/gimppalette-save.c: read and write all files in binary
      	mode. Improved parser error messages (added line numbers). Minor
      	changes to simply read DOS files instead of barfing on them.
      544d679e
  16. 03 Oct, 2006 1 commit
    • Michael Natterer's avatar
      app/core/Makefile.am app/core/gimpbrushgenerated-load.[ch] · c42e8147
      Michael Natterer authored
      2006-10-03  Michael Natterer  <mitch@gimp.org>
      
      	* app/core/Makefile.am
      	* app/core/gimpbrushgenerated-load.[ch]
      	* app/core/gimpbrushgenerated-save.[ch]
      	* app/core/gimpbrushpipe-load.[ch]: new files.
      
      	* app/core/gimpbrushgenerated.[ch]
      	* app/core/gimpbrushpipe.[ch]: removed loading and saving code here.
      
      	* app/core/gimp.c: changed accordingly.
      c42e8147
  17. 14 Aug, 2006 1 commit
  18. 29 May, 2006 1 commit
  19. 23 May, 2006 1 commit
    • Sven Neumann's avatar
      It makes more sense to have GimpData::dirty indicate a name change than to · c3448b2c
      Sven Neumann authored
      2006-05-23  Sven Neumann  <sven@gimp.org>
      
      	It makes more sense to have GimpData::dirty indicate a name change
      	than to invalidate the previews whenever the name changes.
      
      	* app/core/gimpdata.c: call gimp_object_name_changed() from
      	gimp_data_real_dirty() instead of implementing
      	GimpObject::name-changed and calling gimp_data_dirty() from there.
      
      	* app/core/gimpbrushclipboard.c
      	* app/core/gimppalette.c
      	* app/core/gimppatternclipboard.c: call gimp_data_dirty() in place
      	of gimp_object_name_changed().
      
      	* app/core/gimpbrushgenerated.c (gimp_brush_generated_dirty):
      	chain up unconditionally.
      c3448b2c
  20. 15 May, 2006 1 commit
  21. 18 Jan, 2006 1 commit
    • Michael Natterer's avatar
      define GIMP_PARAM_STATIC_STRINGS which is G_PARAM_STATIC_NAME|NICK|BLURB. · e1ceed51
      Michael Natterer authored
      2006-01-18  Michael Natterer  <mitch@gimp.org>
      
      	* app/config/config-types.c: define GIMP_PARAM_STATIC_STRINGS
      	which is G_PARAM_STATIC_NAME|NICK|BLURB. Also define
      	GIMP_PARAM_READABLE, _WRITABLE and _READWRITE which include
      	GIMP_PARAM_STATIC_STRINGS.
      
      	* app/*/*.c: use them for all object properties so their
      	strings are not copied.
      e1ceed51
  22. 10 Dec, 2005 1 commit
  23. 01 Nov, 2005 2 commits
    • Sven Neumann's avatar
      fixed compiler warning. · 275c9b4d
      Sven Neumann authored
      2005-11-01  Sven Neumann  <sven@gimp.org>
      
      	* app/core/gimpbrushgenerated.c: fixed compiler warning.
      
      	* app/core/gimpobject.c: turned "name" into a construct property.
      275c9b4d
    • Sven Neumann's avatar
      use gimp_brush_generated_new() to create the brush object. Removed · a6bb2b57
      Sven Neumann authored
      2005-11-01  Sven Neumann  <sven@gimp.org>
      
      	* app/core/gimpbrushgenerated.c (gimp_brush_generated_load): use
      	gimp_brush_generated_new() to create the brush object. Removed
      	redundant calls to gimp_data_dirty().
      
      	* app/core/gimpdata.c: freeze the data object during construction.
      a6bb2b57
  24. 08 Jun, 2005 1 commit
    • Sven Neumann's avatar
      Removed "stingy-memory-use" all over the place. This feature was really · c1363db8
      Sven Neumann authored
      2005-06-08  Sven Neumann  <sven@gimp.org>
      
      	Removed "stingy-memory-use" all over the place. This feature was
      	really not that useful anymore. The GUI for the preference option
      	was already removed for GIMP 2.2.  Fixes bug #306617.
      
      	* app/config/gimpbaseconfig.[ch]: set IGNORE flag on
      	"stingy-memory-use".
      
      	* app/config/gimpcoreconfig.h: added a comment that the
      	font_path_writable variable is unused.
      
      	* app/base/temp-buf.[ch]: removed code that used to deal with
      	swapping temp-bufs to disk.
      
      	* app/base/base.c: made base_config a static variable.
      
      	* app/core/gimpdata.[ch]
      	* app/core/gimpdatafactory.[ch]: removed stingy_memory_use
      	parameter from data construction methods.
      
      	* app/core/gimp-gradients.c
      	* app/core/gimpbrush-load.[ch]
      	* app/core/gimpbrush.[ch]
      	* app/core/gimpbrushgenerated.[ch]
      	* app/core/gimpbrushpipe.[ch]
      	* app/core/gimpcontext.c
      	* app/core/gimpgradient-load.[ch]
      	* app/core/gimpgradient.[ch]
      	* app/core/gimppalette-import.c
      	* app/core/gimppalette.[ch]
      	* app/core/gimppattern.[ch]: changed accordingly.
      c1363db8
  25. 25 May, 2005 1 commit
    • Sven Neumann's avatar
      added MIME type as a construct property to GimpData. · 59cb5d75
      Sven Neumann authored
      2005-05-26  Sven Neumann  <sven@gimp.org>
      
      	* app/core/gimpdata.[ch]: added MIME type as a construct property
      	to GimpData.
      
      	* app/core/gimpbrush-load.c
      	* app/core/gimpbrushgenerated.c
      	* app/core/gimpbrushpipe.c
      	* app/core/gimpgradient-load.c
      	* app/core/gimppalette.c
      	* app/core/gimppattern.c: set the MIME type when loading a data
      	object from file. MIME types needs review and GimpPalette isn't
      	quite done yet...
      
      	* app/core/gimpdashpattern.c: cosmetics.
      59cb5d75
  26. 07 Feb, 2005 1 commit
    • Sven Neumann's avatar
      app/base/base.c app/base/temp-buf.c app/base/tile-swap.c · 648cccde
      Sven Neumann authored
      2005-02-07  Sven Neumann  <sven@gimp.org>
      
      	* app/base/base.c
      	* app/base/temp-buf.c
      	* app/base/tile-swap.c
      	* app/config/gimpconfig-file.c
      	* app/core/gimpbrush.c
      	* app/core/gimpbrushgenerated.c
      	* app/core/gimpbrushpipe.c
      	* app/core/gimpdata.c
      	* app/core/gimpenvirontable.c
      	* app/core/gimpgradient-load.c
      	* app/core/gimpgradient-save.c
      	* app/core/gimppalette-import.c
      	* app/core/gimppalette.c
      	* app/core/gimppattern.c
      	* app/dialogs/user-install-dialog.c
      	* app/gui/session.c
      	* app/menus/menus.c
      	* app/widgets/gimpdevices.c: use gstdio wrappers.
      648cccde
  27. 14 Nov, 2004 1 commit
    • Manish Singh's avatar
      Fix a bunch of warnings from Sparse: · 5d015810
      Manish Singh authored
      2004-11-13  Manish Singh  <yosh@gimp.org>
      
              Fix a bunch of warnings from Sparse:
      
              * app/actions/dockable-commands.c
              * app/actions/layers-actions.c
              * app/actions/view-commands.c
              * app/base/pixel-surround.c
              * app/config/gimpconfig-utils.c
              * app/config/gimpscanner.c
              * app/core/gimpbrushgenerated.c
              * app/core/gimpcontainer.c
              * app/core/gimpimage.c
              * app/dialogs/palette-import-dialog.c
              * app/file/gimprecentlist.c
              * app/plug-in/plug-in-params.c
              * app/text/gimptext-compat.c
              * app/text/gimptext-parasite.c
              * app/vectors/gimpbezierstroke.c
              * app/vectors/gimpstroke.c
              * app/widgets/gimpcellrendereraccel.c
              * app/widgets/gimpselectiondata.c
              * app/xcf/xcf.c
              * libgimp/gimp.c
              * libgimpthumb/gimpthumb-utils.c
              * libgimpthumb/gimpthumbnail.c
              * modules/cdisplay_proof.c
              * plug-ins/Lighting/lighting_ui.c
              * plug-ins/common/csource.c
              * plug-ins/common/glasstile.c
              * plug-ins/common/nova.c
              * plug-ins/common/pcx.c
              * plug-ins/common/pnm.c
              * plug-ins/common/randomize.c
              * plug-ins/common/screenshot.c
              * plug-ins/common/sel_gauss.c
              * plug-ins/common/spheredesigner.c
              * plug-ins/common/wind.c
              * plug-ins/gfig/gfig-dialog.c
              * plug-ins/gfig/gfig-dobject.c
              * plug-ins/gimpressionist/gimpressionist.c
              * plug-ins/ifscompose/ifscompose.c
              * plug-ins/print/gimp_main_window.c
              * plug-ins/print/print.c: Cleanup integer vs. pointer confusion.
      
              * app/base/temp-buf.c
              * app/dialogs/about-dialog.c
              * plug-ins/common/bumpmap.c
              * plug-ins/common/jigsaw.c
              * plug-ins/gfig/gfig-dobject.c: Cosmetic cleanups.
      
              * app/config/gimpconfig-deserialize.c
              * app/config/gimpconfig-path.c
              * app/config/gimpconfigwriter.c
              * app/core/gimpgradient.c
              * app/tools/gimpdrawtool.c
              * plug-ins/common/nlfilt.c
              * plug-ins/common/unsharp.c
              * plug-ins/common/zealouscrop.c: Define inline functions before they
              are used.
      
              * app/core/gimpdrawable-blend.c: PixelRegion definition was changed
              some time ago, but the initialization here didn't change. Fix it.
      
              * app/plug-in/plug-in-rc.c (plug_in_extra_deserialize): No need to
              assign token twice in a row.
      
              * libgimpbase/gimpdatafiles.c (gimp_datafiles_read_directories): No
              need to initialize file_data, since the code fills out all the fields.
      
              * plug-ins/common/CML_explorer.c
              * plug-ins/common/vpropagate.c: Declare function pointers fully.
      
              * plug-ins/common/grid.c (pix_composite): G_INLINE_FUNC isn't needed,
              we assume we can use the "inline" keyword always.
      
              * plug-ins/common/psd_save.c
              * plug-ins/common/vinvert.c
              * plug-ins/gfig/gfig-arc.c
              * plug-ins/gfig/gfig-bezier.c
              * plug-ins/gfig/gfig-circle.c
              * plug-ins/gfig/gfig-dialog.c
              * plug-ins/gfig/gfig-dobject.c
              * plug-ins/gfig/gfig-ellipse.c
              * plug-ins/gfig/gfig-line.c
              * plug-ins/gfig/gfig-poly.c
              * plug-ins/gfig/gfig-spiral.c
              * plug-ins/gfig/gfig-star.c
              * plug-ins/gfig/gfig.c
              * plug-ins/gimpressionist/orientmap.c
              * plug-ins/gimpressionist/placement.c
              * plug-ins/gimpressionist/sizemap.c
              * plug-ins/imagemap/imap_grid.c
              * plug-ins/imagemap/imap_main.c
              * plug-ins/imagemap/imap_preferences.c
              * plug-ins/imagemap/imap_settings.c
              * plug-ins/maze/maze.c
              * plug-ins/sel2path/curve.c
              * plug-ins/sel2path/fit.c
              * plug-ins/sel2path/pxl-outline.c
              * plug-ins/sel2path/spline.c
              * plug-ins/xjt/xjt.c: Functions with no args should be declared
              with (void).
      
              * plug-ins/common/retinex.c (MSRCR): Initialize max_preview to quiet
              the compiler.
      5d015810
  28. 06 Nov, 2004 1 commit
  29. 04 Oct, 2004 1 commit
    • Michael Natterer's avatar
      tools/pdbgen/pdb/brush.pdb tools/pdbgen/pdb/gradient.pdb disallow the · 3eb69a85
      Michael Natterer authored
      2004-10-04  Michael Natterer  <mitch@gimp.org>
      
      	* tools/pdbgen/pdb/brush.pdb
      	* tools/pdbgen/pdb/gradient.pdb
      	* tools/pdbgen/pdb/palette.pdb: disallow the empty string for
      	new brushes, gradients and palettes and check the return value
      	of gimp_data_factory_data_new(). Cleanup.
      
      	* app/core/gimpbrushgenerated.c (gimp_brush_generated_new)
      	* app/core/gimpgradient.c (gimp_gradient_new)
      	* app/core/gimpdatafactory.c (gimp_data_factory_data_new): same
      	here. Fixes bug #154264.
      
      	* app/core/gimpdata.[ch] (gimp_data_set_filename): added boolean
      	"deletable" parameter because it's not derivable from "writable".
      
      	* app/core/gimpdatafactory.c (gimp_data_factory_load_data): need
      	to figure "deletable" separately from "writable" to be able to
      	delete unsavable stuff in the user-writable data directories.
      	Fixes bug #154410.
      
      	(gimp_data_factory_data_save_single): cleaned up.
      
      	* app/pdb/brush_cmds.c
      	* app/pdb/gradient_cmds.c
      	* app/pdb/palette_cmds.c
      	* libgimp/gimpbrush_pdb.c
      	* libgimp/gimpgradient_pdb.c
      	* libgimp/gimppalette_pdb.c: regenerated.
      3eb69a85
  30. 10 Aug, 2004 2 commits
  31. 04 Aug, 2004 1 commit
    • Simon Budig's avatar
      Enhanced the range of the hardness parameter to make more soft brushes · 428c4a8d
      Simon Budig authored
      2004-08-04  Simon Budig  <simon@gimp.org>
      
      	* app/core/gimpbrushgenerated.c: Enhanced the range of the hardness
      	parameter to make more soft brushes possible. Please note that this
      	makes existing generated brushes look more soft. But since people
      	apparently rarely use more than one or two generated brushes and
      	these get changed frequently I guess it should be OK.
      428c4a8d
  32. 03 Aug, 2004 1 commit
    • Michael Natterer's avatar
      don't leak the brush's name if parsing the shape fails. · 36d5f97b
      Michael Natterer authored
      2004-08-03  Michael Natterer  <mitch@gimp.org>
      
      	* app/core/gimpbrushgenerated.c (gimp_brush_generated_load): don't
      	leak the brush's name if parsing the shape fails.
      
      	(gimp_brush_generated_dirty): shut up bogus compiler warnings
      	about uninitialized variables.
      36d5f97b
  33. 02 Aug, 2004 1 commit
  34. 01 Aug, 2004 2 commits
    • Simon Budig's avatar
      Added optional spikes for the generated brushes, enabling star shaped · 1eb3009f
      Simon Budig authored
      2004-08-01  Simon Budig  <simon@gimp.org>
      
      	* app/core/gimpbrushgenerated.[ch]: Added optional spikes for
      	the generated brushes, enabling star shaped generated brushes.
      
      	* app/widgets/gimpbrusheditor.[ch]: GUI for this.
      
      	* app/core/gimpbrush.c: changed accordingly.
      1eb3009f
    • Simon Budig's avatar
      app/core/core-enums.h Implement three different brush shapes for generated · c40e2939
      Simon Budig authored
      2004-08-01  Simon Budig  <simon@gimp.org>
      
      	* app/core/core-enums.h
      	* app/core/gimpbrushgenerated.[ch]: Implement three different
      	brush shapes for generated brushes.
      
      	* app/core/gimpbrush.c: changed accordingly.
      	* app/core/core-enums.c: regenerated.
      
      	* app/widgets/gimpbrusheditor.[ch]: Add toggles for the shape.
      	* themes/Default/images/stock-brush-generated-*-16.png: New stock
      	icons for the brush shapes.
      
      	* themes/Default/images/Makefile.am
      	* libgimpwidgets/gimpstock.[ch]: changed accordingly
      
      	untabified the files touched.
      c40e2939