1. 22 Jan, 2005 1 commit
    • Sven Neumann's avatar
      no point in crashing if gimp_enum_get_desc() returns NULL. · 180f9eb0
      Sven Neumann authored
      2005-01-22  Sven Neumann  <sven@gimp.org>
      
      	* libgimpbase/gimputils.c (gimp_enum_value_get_desc): no point in
      	crashing if gimp_enum_get_desc() returns NULL.
      
      	* modules/cdisplay_colorblind.c
      	* modules/cdisplay_proof.c: register enum descriptions, use
      	GimpEnumComboBox.
      180f9eb0
  2. 10 Jan, 2005 1 commit
  3. 25 Nov, 2004 1 commit
  4. 24 Nov, 2004 2 commits
    • Simon Budig's avatar
      Accept >= 0 return values of the ioctl() to figure out the device name. · b349746f
      Simon Budig authored
      2004-11-24  Simon Budig  <simon@gimp.org>
      
      	* modules/controller_linux_input.c: Accept >= 0 return values of the
      	ioctl() to figure out the device name. Apparently it is the number of
      	bytes written to the string, so we might omit the strlen() following,
      	but I don't like to rely on that...
      b349746f
    • Michael Natterer's avatar
      guarded the whole header with GIMP_ENABLE_CONTROLLER_UNDER_CONSTRUCTION · 6d63d500
      Michael Natterer authored
      2004-11-24  Michael Natterer  <mitch@gimp.org>
      
      	* libgimpwidgets/gimpcontroller.[ch]: guarded the whole header
      	with GIMP_ENABLE_CONTROLLER_UNDER_CONSTRUCTION because it's no
      	fixed API yet. Added a "state" property bacause "name" was abused
      	as the controller's state. Added "help_domain" to the controller
      	class.
      
      	* libgimpwidgets/gimpwidgets.h: don't include gimpcontroller.h
      
      	* modules/controller_linux_input.c
      	* modules/controller_midi.c: set the "name" property to the name
      	retrieved from the device, or to a default string if no name is
      	available. Store the status in the "state" property. Added and
      	changed some strings, but it's better to have the controller
      	strings untranslated than to have no tooltips at all or misleading
      	labels.
      
      	* app/widgets/gimpcontrollerkeyboard.c
      	* app/widgets/gimpcontrollerwheel.c: set default strings for both.
      
      	* app/widgets/gimpcontrollereditor.c: added a GUI for the "state"
      	property.
      
      	* app/widgets/gimpcontrollerkeyboard.h
      	* app/widgets/gimpcontrollerwheel.h
      	* app/widgets/gimpcontrollerinfo.c
      	* app/widgets/gimpcontrollers.c: #define
      	GIMP_ENABLE_CONTROLLER_UNDER_CONSTRUCTION (just as in all files
      	above).
      
      	* app/widgets/gimphelp-ids.h: added the IDs of all controller
      	modules and also of all other modules. The defines are not
      	actually used, but this file is the canonical place to collect all
      	the core's help IDs.
      6d63d500
  5. 18 Nov, 2004 1 commit
    • Michael Natterer's avatar
      pasted the complete alsa.m4 so compiling from CVS doesn't require alsa.m4 · bf08b8fd
      Michael Natterer authored
      2004-11-18  Michael Natterer  <mitch@gimp.org>
      
      	* acinclude.m4: pasted the complete alsa.m4 so compiling from
      	CVS doesn't require alsa.m4 to be installed.
      
      	* configure.in: check for alsa >= 1.0.0 and define HAVE_ALSA
      	if found.
      
      	* modules/Makefile.am: build controller_midi with ALSA_CFLAGS
      	and ALSA_LIBS.
      
      	* modules/controller_midi.c: s/HAVE_ALSALIB_H/HAVE_ALSA/.
      bf08b8fd
  6. 17 Nov, 2004 2 commits
  7. 14 Nov, 2004 1 commit
    • Manish Singh's avatar
      Fix a bunch of warnings from Sparse: · 5d015810
      Manish Singh authored
      2004-11-13  Manish Singh  <yosh@gimp.org>
      
              Fix a bunch of warnings from Sparse:
      
              * app/actions/dockable-commands.c
              * app/actions/layers-actions.c
              * app/actions/view-commands.c
              * app/base/pixel-surround.c
              * app/config/gimpconfig-utils.c
              * app/config/gimpscanner.c
              * app/core/gimpbrushgenerated.c
              * app/core/gimpcontainer.c
              * app/core/gimpimage.c
              * app/dialogs/palette-import-dialog.c
              * app/file/gimprecentlist.c
              * app/plug-in/plug-in-params.c
              * app/text/gimptext-compat.c
              * app/text/gimptext-parasite.c
              * app/vectors/gimpbezierstroke.c
              * app/vectors/gimpstroke.c
              * app/widgets/gimpcellrendereraccel.c
              * app/widgets/gimpselectiondata.c
              * app/xcf/xcf.c
              * libgimp/gimp.c
              * libgimpthumb/gimpthumb-utils.c
              * libgimpthumb/gimpthumbnail.c
              * modules/cdisplay_proof.c
              * plug-ins/Lighting/lighting_ui.c
              * plug-ins/common/csource.c
              * plug-ins/common/glasstile.c
              * plug-ins/common/nova.c
              * plug-ins/common/pcx.c
              * plug-ins/common/pnm.c
              * plug-ins/common/randomize.c
              * plug-ins/common/screenshot.c
              * plug-ins/common/sel_gauss.c
              * plug-ins/common/spheredesigner.c
              * plug-ins/common/wind.c
              * plug-ins/gfig/gfig-dialog.c
              * plug-ins/gfig/gfig-dobject.c
              * plug-ins/gimpressionist/gimpressionist.c
              * plug-ins/ifscompose/ifscompose.c
              * plug-ins/print/gimp_main_window.c
              * plug-ins/print/print.c: Cleanup integer vs. pointer confusion.
      
              * app/base/temp-buf.c
              * app/dialogs/about-dialog.c
              * plug-ins/common/bumpmap.c
              * plug-ins/common/jigsaw.c
              * plug-ins/gfig/gfig-dobject.c: Cosmetic cleanups.
      
              * app/config/gimpconfig-deserialize.c
              * app/config/gimpconfig-path.c
              * app/config/gimpconfigwriter.c
              * app/core/gimpgradient.c
              * app/tools/gimpdrawtool.c
              * plug-ins/common/nlfilt.c
              * plug-ins/common/unsharp.c
              * plug-ins/common/zealouscrop.c: Define inline functions before they
              are used.
      
              * app/core/gimpdrawable-blend.c: PixelRegion definition was changed
              some time ago, but the initialization here didn't change. Fix it.
      
              * app/plug-in/plug-in-rc.c (plug_in_extra_deserialize): No need to
              assign token twice in a row.
      
              * libgimpbase/gimpdatafiles.c (gimp_datafiles_read_directories): No
              need to initialize file_data, since the code fills out all the fields.
      
              * plug-ins/common/CML_explorer.c
              * plug-ins/common/vpropagate.c: Declare function pointers fully.
      
              * plug-ins/common/grid.c (pix_composite): G_INLINE_FUNC isn't needed,
              we assume we can use the "inline" keyword always.
      
              * plug-ins/common/psd_save.c
              * plug-ins/common/vinvert.c
              * plug-ins/gfig/gfig-arc.c
              * plug-ins/gfig/gfig-bezier.c
              * plug-ins/gfig/gfig-circle.c
              * plug-ins/gfig/gfig-dialog.c
              * plug-ins/gfig/gfig-dobject.c
              * plug-ins/gfig/gfig-ellipse.c
              * plug-ins/gfig/gfig-line.c
              * plug-ins/gfig/gfig-poly.c
              * plug-ins/gfig/gfig-spiral.c
              * plug-ins/gfig/gfig-star.c
              * plug-ins/gfig/gfig.c
              * plug-ins/gimpressionist/orientmap.c
              * plug-ins/gimpressionist/placement.c
              * plug-ins/gimpressionist/sizemap.c
              * plug-ins/imagemap/imap_grid.c
              * plug-ins/imagemap/imap_main.c
              * plug-ins/imagemap/imap_preferences.c
              * plug-ins/imagemap/imap_settings.c
              * plug-ins/maze/maze.c
              * plug-ins/sel2path/curve.c
              * plug-ins/sel2path/fit.c
              * plug-ins/sel2path/pxl-outline.c
              * plug-ins/sel2path/spline.c
              * plug-ins/xjt/xjt.c: Functions with no args should be declared
              with (void).
      
              * plug-ins/common/retinex.c (MSRCR): Initialize max_preview to quiet
              the compiler.
      5d015810
  8. 27 Oct, 2004 2 commits
  9. 26 Oct, 2004 1 commit
  10. 15 Sep, 2004 1 commit
  11. 20 Aug, 2004 1 commit
  12. 18 Aug, 2004 2 commits
    • Sven Neumann's avatar
      no need to set a size_request here. · 0620ee06
      Sven Neumann authored
      2004-08-18  Sven Neumann  <sven@gimp.org>
      
      	* app/gui/color-notebook.c: no need to set a size_request here.
      
      	* libgimpwidgets/gimpcolorselection.c: HIG-ified spacings.
      
      	* libgimpwidgets/gimpcolorscales.c
      	* modules/colorsel_cmyk.c: don't set a minimum width on the color
      	scales. Improves behaviour for narrow color dockables.
      0620ee06
    • Sven Neumann's avatar
      fixed crashes that occured with small sizes, some code cleanups and a · d5cd7ae3
      Sven Neumann authored
      2004-08-18  Sven Neumann  <sven@gimp.org>
      
      	* modules/colorsel_triangle.c: fixed crashes that occured with
      	small sizes, some code cleanups and a simple optimization.
      d5cd7ae3
  13. 17 Aug, 2004 2 commits
    • Simon Budig's avatar
      Made the triangle colorselector resizeable. Removed minimum size request · f960771b
      Simon Budig authored
      2004-08-17  Simon Budig  <simon@gimp.org>
      
      	* modules/colorsel_triangle.c: Made the triangle colorselector
      	resizeable. Removed minimum size request (would probably need some
      	testing for *very* small sizes though).
      f960771b
    • Sven Neumann's avatar
      minor cleanups. · 7b1cc4ae
      Sven Neumann authored
      2004-08-17  Sven Neumann  <sven@gimp.org>
      
      	* modules/colorsel_cmyk.c: minor cleanups.
      
      	* modules/colorsel_water.c: let the widget take the available
      	space, don't set a minimum size.
      7b1cc4ae
  14. 15 Aug, 2004 2 commits
  15. 01 Aug, 2004 1 commit
    • Hans Breuer's avatar
      build but *dont link* display-enums.obj, widget-enums.obj and · 3b303914
      Hans Breuer authored
      2004-07-31  Hans Breuer  <hans@breuer.org>
      
      	* app/display/makefile.msc app/widgets/makefile.msc : build
      	but *dont link* display-enums.obj, widget-enums.obj and
      	gimpdisplayoptions.obj. They must be in the dll
      	* app/makefile.msc : build gimp.exe and gimp-console.exe both
      	using the same gimp-core.dll
      	* app/gimpcore.def : new file, exports for gimp-core.dll
      	* app/Makefile.am : added to EXTRA_DIST
      
      	* cursors/makefile.msc : new file to create gimp-tool-cursors.h
      	* cursors/Makefile.am : added to EXTRA_DIST
      
      	* **/makefile.msc : updated
      
      	* app/main.c app/app_procs.c : moved code to close the console
      	from the former to the later. It only is to be used if The Gimp
      	is not build as console app.
      
      	* plug-ins/gfig/gfig.c : dont gimp_drawable_detach() the same
      	drawable twice
      	* plug-ins/gfig-dialog.c() : added a g_return_if_fail() to avoid
      	crashing on File/Import
      3b303914
  16. 06 Jul, 2004 1 commit
  17. 05 Jul, 2004 3 commits
    • Michael Natterer's avatar
      removed #define GIMP_CONTROLLER_PARAM_SERIALIZE. · cade89ab
      Michael Natterer authored
      2004-07-06  Michael Natterer  <mitch@gimp.org>
      
      	* libgimpwidgets/gimpcontroller.h: removed #define
      	GIMP_CONTROLLER_PARAM_SERIALIZE.
      
      	* libgimpmodule/gimpmoduletypes.h: added
      	GIMP_MODULE_PARAM_SERIALIZE instead.
      
      	* modules/controller_linux_input.c
      	* modules/controller_midi.c: changed accordingly.
      
      	* modules/cdisplay_colorblind.c
      	* modules/cdisplay_gamma.c
      	* modules/cdisplay_highcontrast.c
      	* modules/cdisplay_proof.c: made the new properties serializable.
      cade89ab
    • Sven Neumann's avatar
      link all modules with libgimpmodule. · ee163c04
      Sven Neumann authored
      2004-07-05  Sven Neumann  <sven@gimp.org>
      
      	* modules/Makefile.am: link all modules with libgimpmodule.
      ee163c04
    • Sven Neumann's avatar
      use object properties for the configurable values. · e119a2eb
      Sven Neumann authored
      2004-07-05  Sven Neumann  <sven@gimp.org>
      
      	* modules/cdisplay_proof.c: use object properties for the
      	configurable values.
      e119a2eb
  18. 04 Jul, 2004 2 commits
  19. 24 Jun, 2004 2 commits
  20. 23 Jun, 2004 1 commit
  21. 19 Jun, 2004 4 commits
  22. 17 Jun, 2004 1 commit
    • Michael Natterer's avatar
      removed "enabled" property. Removed GIMP_CONTROLLER_PARAM_RERIALIZE from · 5f4eabdb
      Michael Natterer authored
      2004-06-17  Michael Natterer  <mitch@gimp.org>
      
      	* libgimpwidgets/gimpcontroller.[ch]: removed "enabled"
      	property. Removed GIMP_CONTROLLER_PARAM_RERIALIZE from the "name"
      	property because it's the hardware-determined name of this
      	controller instance.
      
      	* app/widgets/gimpcontrollerwheel.c
      	* modules/controller_linux_input.c: set the name.
      
      	* libgimpwidgets/gimpwidgets.h: #include gimpcontroller.h.
      
      	* app/widgets/gimpcontrollerinfo.[ch]: added "enabled" here
      	instead.  Don't dispatch events if the controller is
      	disabled. Made everything work (not crash) with info->mapping
      	being NULL.
      
      	* etc/controllerrc: updated again with the changed format.
      
      	* app/widgets/gimpcontrollers.[ch]: added
      	gimp_controllers_get_list() which returns the container of
      	controllers.
      
      	* app/widgets/gimphelp-ids.h
      	* app/gui/preferences-dialog.c: added controller configuration
      	(can't change anything yet, just view the current settings).
      	Resurrected the "Input Devices" page and removed the "Session"
      	page by moving its widgets to other pages. Pack the various
      	"Save now"/"Clear now" buttons vertically, not horizontally.
      	Fixes bug #139069.
      
      	* themes/Default/images/preferences/Makefile.am
      	* themes/Default/images/preferences/controllers.png
      	* themes/Default/images/preferences/theme.png: new icons for new
      	prefs pages. Someone needs to make them nice...
      5f4eabdb
  23. 16 Jun, 2004 5 commits
    • Manish Singh's avatar
      put BTN_{WHEEL,GEAR_DOWN,GEAR_UP} usage in #ifdefs, since pre-2.6 kernels · efe3ff1b
      Manish Singh authored
      2004-06-16  Manish Singh  <yosh@gimp.org>
      
              * modules/controller_linux_input.c: put BTN_{WHEEL,GEAR_DOWN,GEAR_UP}
              usage in #ifdefs, since pre-2.6 kernels do not have them.
      
              * modules/controller_linux_input.c (linux_input_read_event): n_bytes
              should be a gsize.
      efe3ff1b
    • Simon Budig's avatar
      removed BTN_MISC, since it is the same as BTN_0 in the input.h header · 1209fb5d
      Simon Budig authored
      2004-06-16  Simon Budig  <simon@gimp.org>
      
      	* modules/controller_linux_input.c: removed BTN_MISC,
      	since it is the same as BTN_0 in the input.h header file.
      1209fb5d
    • Michael Natterer's avatar
      always return a non-NULL string (return "<invalid event id>" as fallback). · 004a9572
      Michael Natterer authored
      2004-06-16  Michael Natterer  <mitch@gimp.org>
      
      	* libgimpwidgets/gimpcontroller.c (gimp_controller_get_event_name)
      	(gimp_controller_get_event_blurb): always return a non-NULL
      	string (return "<invalid event id>" as fallback).
      
      	* modules/controller_linux_input.c: reenabled button event
      	dispatching.
      
      	* app/widgets/gimpcontrollerinfo.c: fixed debugging output.
      004a9572
    • Simon Budig's avatar
      break out of the loop after we handled the first matching rel_event. · a1d67f0e
      Simon Budig authored
      2004-06-16  Simon Budig  <simon@gimp.org>
      
      	* modules/controller_linux_input.c: break out of the
      	loop after we handled the first matching rel_event.
      a1d67f0e
    • Michael Natterer's avatar
      added #define GIMP_CONTROLLER_PARAM_SERIALIZE. Made all properties · 3a7f7d54
      Michael Natterer authored
      2004-06-16  Michael Natterer  <mitch@gimp.org>
      
      	* libgimpwidgets/gimpcontroller.[ch]: added #define
      	GIMP_CONTROLLER_PARAM_SERIALIZE. Made all properties serializable.
      
      	* modules/controller_linux_input.c: made "device-name"
      	serializable.
      
      	* app/config/gimpconfig-params.h: added macro
      	GIMP_CONFIG_INSTALL_PROP_POINTER() which needs to be handled
      	by custom (de)serialize_property() implementations.
      
      	* app/config/gimpconfig-deserialize.c
      	* app/config/gimpconfig-serialize.c: made object (de)serialization
      	work for object properties which are *not* GIMP_PARAM_AGGREGATE.
      	Write/parse the exact type of the object to create to enable this.
      
      	* app/core/gimpmarshal.list: new marshaller for GimpControllerInfo.
      
      	* app/widgets/gimpcontrollerinfo.[ch]: implement GimpConfigInterface
      	and add "controller" and "mapping" properties. Add "event-mapped"
      	signal which carries the action_name.
      
      	* app/widgets/gimpcontrollers.c: removed all deserialization code
      	and simply (de)serialize the controller container. Install a
      	container handler for "event-mapped" and do the action_name ->
      	action mapping in the callback.
      
      	* etc/controllerrc: regenerated with new syntax. Delete your old one!
      3a7f7d54